Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp222219pxt; Wed, 11 Aug 2021 19:17:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJykCoJPwvAzn2Sq2KXPNmt4BuTIhzETQVxs3Qq2fW4wS0nHCA1M9g6gybhnieMzL/GsTCnH X-Received: by 2002:a05:6e02:611:: with SMTP id t17mr1124949ils.216.1628734623675; Wed, 11 Aug 2021 19:17:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628734623; cv=none; d=google.com; s=arc-20160816; b=XwLrCm8n4ri4nHwiHQjCihEyl4395CEGH2rCt3FF4HHDdyTaz+gCCLC5+KYf4mYa3h JJWpQVUaRhQsDt1c4NHThTgnQOYhCp4NkfAB4wBb08dsHr0rPMxq71YKyiydqHESpjzI pijloZBQWScQoVoWvzlrQFTINBslVYBBG3rXHdk8Yju20S9nRMIr0SOc3AwvMDm4dUZS iTcq0VWZEoZnPRVAE/20sAGZTmJImtQKpDAnFSMS6KcRAFB8mg7bf8/qDVTu4tx51c07 DUzHDsidx/ox/T6ZvIYQVXCEc3WnYngWxRt3tlCBU2iUhyC9cAT9702YBkryrXDWc9jK dpQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=iBBkm+jCVnHmgcnMZ5wOJauY5qKedYVT4bfG7j0L/cA=; b=QIzjmM1Pi5AX1PJ3aJkXLeZ1OWI+nLluUromlZZcFrDc7LftCubG9tqjUG4+a/y9cA 3lvowHOSYYaoHuoX7G5PxjKWPeYMd2ifXBR7zHUFqfj8YOVn6zHgKdvSjv/9vbEMbboZ gG4ZfOTJHbrW1v9WYw0+XVFLWPB9fWoiL/VtxA6Ux0C5v/DavQfaLOTpQ5yiZq6Hi8h+ GslEuPC8OKJsfEuSm4n+DchMNOStwHXP2Gkehtv2/vFJ6edR681YZEeBC3rhJ1DMJD9w /mxUIdWq55414T9TbqpGFZat9lLt0Tqb2INUkGy3OO1dN4NuBfDXJ4jGfC0+s9GCfohB n0Pw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r17si1320453iov.104.2021.08.11.19.16.52; Wed, 11 Aug 2021 19:17:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233354AbhHLCIS (ORCPT + 99 others); Wed, 11 Aug 2021 22:08:18 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:8400 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229851AbhHLCIR (ORCPT ); Wed, 11 Aug 2021 22:08:17 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4GlVNS1Kwvz86Nx; Thu, 12 Aug 2021 10:03:52 +0800 (CST) Received: from dggpeml500006.china.huawei.com (7.185.36.76) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 12 Aug 2021 10:07:48 +0800 Received: from [10.174.176.127] (10.174.176.127) by dggpeml500006.china.huawei.com (7.185.36.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 12 Aug 2021 10:07:47 +0800 Subject: Re: [PATCH 0/5] block: replace incorrect uses of GENHD_FL_UP To: Christoph Hellwig CC: Luis Chamberlain , , , , , , , , References: <20210720182048.1906526-1-mcgrof@kernel.org> <051ab019-5163-e691-43ed-052401b6b95a@huawei.com> From: luomeng Message-ID: <200816d2-4cfe-a26d-88c8-a0cde0b8614b@huawei.com> Date: Thu, 12 Aug 2021 10:07:46 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.176.127] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpeml500006.china.huawei.com (7.185.36.76) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ?? 2021/8/11 13:19, Christoph Hellwig ะด??: > On Wed, Aug 11, 2021 at 10:42:20AM +0800, luomeng wrote: >> Hi: >> When the fuzz test injected memory allocation failed, I had this BUG_ON: >> kernel BUG at fs/sysfs/group.c:116. >> The cause of the bug_ON is that the add_disk memory fails to be allocated >> but no error processing is performed. >> I find your patches add error processing. So what is your next step with >> these patches. > I have one more pending series on top of this one I need to submit here: > > http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/alloc_disk > > to make sure the disk always has a valid queue reference. After that > Luis work to return an error from add_disk should be much easier bause > we not have defined state. > . Thanks. So how about this series, when this series will merge into linux master? And do you submit these patches ( http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/alloc_disk) on liunx? Luo Meng