Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   William Kucharski <william.kucharski@oracle.com>
To:     John Hubbard <jhubbard@nvidia.com>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        Christoph Hellwig <hch@lst.de>,
        Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v2 3/3] mm/gup: Remove try_get_page(), call
 try_get_compound_head() directly
Thread-Topic: [PATCH v2 3/3] mm/gup: Remove try_get_page(), call
 try_get_compound_head() directly
Thread-Index: AQHXjvBdcLHj6CuNF0ypEXBwDT9dtqtu3JwAgABF6AA=
Date:   Thu, 12 Aug 2021 02:17:28 +0000
Message-ID: <1BBAB7A1-6334-4462-8E2C-A878B3E902A1@oracle.com>
References: <20210811070542.3403116-1-jhubbard@nvidia.com>
 <20210811070542.3403116-4-jhubbard@nvidia.com>
 <20FB1F52-61FB-47DB-8777-E7C880FD875E@oracle.com>
 <0253d7e6-8377-a197-f131-e73249d8dbe8@nvidia.com>
In-Reply-To: <0253d7e6-8377-a197-f131-e73249d8dbe8@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zfjHjQd3x5AuQqT66EPXDo6mpfSvMOe37l+0wbr5sq61oOhcg69N50Y7V38R?=
 =?us-ascii?Q?KR5TE3Bc35VN6EkoUDan8MsN0y6ip+/cwExrLwyaXH8uwfhYs6Lhbw4rGTg/?=
 =?us-ascii?Q?EhC5Uq613XkSMEYJtq3R/msIQ8UxxXqR5yo97T+U2Vb4v8ATLeFTU+bPvtzc?=
 =?us-ascii?Q?BQ+26sMQTSnS6eEhmewbgpNsGerOCSseSMZIwgo1ASli1KKfK/CCwE1GkooQ?=
 =?us-ascii?Q?U/XuyCHstCEploEJwegMUwWvIHZL4r9mXyaf6KBAXPRWgWvRDdk3snoJoMXB?=
 =?us-ascii?Q?W23xMErDB5wEyz8VdSG7zA4VvhoFER8Z/L1YBUZJXUGwXllBcc0cCOeNGoUC?=
 =?us-ascii?Q?NPOUzWZDenzn/nIrb+XeZN3+wWRibjv88ven0QUkQ23rhR0DUmBtz2BBMcqb?=
 =?us-ascii?Q?Xn+eVqC+4hq+80/hPOJQe2SQcLPlA5adgi0pWLI++tmtm9mR7cGMSCbmhh3Z?=
 =?us-ascii?Q?OS6q3uvmj7VPiJ47RjljZY9KTMAmYw6jkfgTCkIFX4fqujnTfnzTsCn36lHG?=
 =?us-ascii?Q?PluDSJQoau1D/x/vDrovr4VWZepv810mALjTPOjk0yM2Wz/tbNmzsG/YvTeH?=
 =?us-ascii?Q?C9kTwNxFOpyJXDcpQlajbL4pa0Zft7COIe6ltBpdj25sKmCmQDuvSFnpeF5D?=
 =?us-ascii?Q?W/p/Y+MTt+8bsQlSqVDZaLm8c/ZlmgeHCEAg3f42PDVnyg6G6VqHJyUGFq/W?=
 =?us-ascii?Q?K8R0RQjn+ldz8faDPoeVjEiIV0kv+xVilWbqvJZXA6TO84ZWdq4kAM/ko7Wp?=
 =?us-ascii?Q?XGSSX3SDE1gbF+W4FCbQoFxkFEHriPteWEbV1l1WoK+VrtvNaV47hkKmxew/?=
 =?us-ascii?Q?4OMgJwfqhAyQ7Nu5GZMIoJlty2ybaFaWgP9U0QR+fWbM24dQFvM8REFQGbuo?=
 =?us-ascii?Q?uZZWioGh4N1cnwcc1urVuteM7Wtgfd2Irv6uXwrOp9JloscGmONG9uXSikri?=
 =?us-ascii?Q?sYwAtQUf88Lsq+JptpD35JjianMi8VdVOlfubiS107aGqoX28fPNCT84/eiT?=
 =?us-ascii?Q?SZahumjMllOCySSkfHNZOIWNbnsrA24GmyP3WTZIsHIF8uqGnXNizvEi3PIk?=
 =?us-ascii?Q?wl/RWDC0jY2fvfo8McGHANhWbItqkiDQOrtF58so/qe18pNSbCrajEY5ScRg?=
 =?us-ascii?Q?HCn88X1CPp8lj2ti0VS2kx8znkXoCqOPdmhAksuW4l6qSkW2bCO9kpmcrm94?=
 =?us-ascii?Q?No1x/k2990cn+cmdRwmaDv0paT7trFlfwcOWVwEc55uHWayR7SEgeHsvy2rd?=
 =?us-ascii?Q?anxZkYvdR+cS/4kRvMRuy9b//D3+OrQ4p2HgAnI60938PzOC2wwrLRJFPaqC?=
 =?us-ascii?Q?YUQMi+c25RBqzdt/d3hZgcTfMSHXgdldpWhKTM6tvoXOF/54c1McvnHVRZxb?=
 =?us-ascii?Q?meQUlswjyrn4JHqmrSVI6IfKXK+w?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6FFA5E276807E341862A1A32AFA339E0@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY4PR1001MB2357.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4de715c9-bbae-4f3e-cce0-08d95d3755a7
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Aug 2021 02:17:28.9771
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TcjhUuIdcOxAv4otQ/fWGSi3OuMHvzH1gYUPgeBhnWh91wfRDPsiWlKy8JLAfw8U30vgGxNs3xSKq/erVuxUCghSd+L/vamenb9k67ll1gU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1001MB2053
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10073 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=919
 malwarescore=0 adultscore=0 spamscore=0 bulkscore=0 mlxscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2107140000 definitions=main-2108120013
X-Proofpoint-GUID: Buq3OJzll9nODs8oFoS690urc94q_SFv
X-Proofpoint-ORIG-GUID: Buq3OJzll9nODs8oFoS690urc94q_SFv
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Aug 11, 2021, at 4:07 PM, John Hubbard <jhubbard@nvidia.com> wrote:
>=20
> On 8/11/21 1:35 PM, William Kucharski wrote:
>> I agree that try_get_page() should probably be removed entirely; is ther=
e
>> a reason you didn't in v2 of the patch?
>=20
> Hi William,
>=20
> This patch *does* remove try_get_page() entirely! Look below. I'll reply
> inline, below, to show where that happens.

Ah, my bad.  I was conflating it with try_grab_page() in patch 2/3, which
also seems like it should be an inline, but given your explanation re:
try_get_compound_head() it makes perfect sense.
=20
For the series:

Reviewed-by: William Kucharski <william.kucharski@oracle.com>