Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 12 Aug 2021 07:18:55 +0200
From:   Oleksij Rempel <o.rempel@pengutronix.de>
To:     Rob Herring <robh@kernel.org>
Cc:     Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>, kernel@pengutronix.de,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        devicetree@vger.kernel.org, Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v1] dt-bindings: timer: fsl,imxgpt: add optional osc_per
 clock
Message-ID: <20210812051855.vrwisusfqkbb5v6a@pengutronix.de>
References: <20210803072958.4815-1-o.rempel@pengutronix.de>
 <YRQRNrLXIYERa6FT@robh.at.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <YRQRNrLXIYERa6FT@robh.at.kernel.org>
User-Agent: NeoMutt/20170113 (1.7.2)
Precedence: bulk

On Wed, Aug 11, 2021 at 12:04:38PM -0600, Rob Herring wrote:
> On Tue, Aug 03, 2021 at 09:29:58AM +0200, Oleksij Rempel wrote:
> > Add optional osc_per and fix dts validation warnings on imx6 SoCs.
> > 
> > Fixes: df8cad689eae ("dt-bindings: timer: Convert i.MX GPT to json-schema")
> 
> I don't think you can say the above commit was broken.
>
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> >  .../devicetree/bindings/timer/fsl,imxgpt.yaml   | 17 +++++++++++++++++
> >  1 file changed, 17 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> > index a4f51f46b7a1..e496dd9f4988 100644
> > --- a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> > +++ b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> > @@ -43,11 +43,15 @@ properties:
> >      items:
> >        - description: SoC GPT ipg clock
> >        - description: SoC GPT per clock
> > +      - description: optional SoC GPT oscillator
> > +    minItems: 2
> 
> The 3rd clock is valid on every version of the h/w?

No.

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |