Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 12 Aug 2021 09:32:14 +0200
From:   Gerd Hoffmann <kraxel@redhat.com>
To:     Pavel Skripkin <paskripkin@gmail.com>
Cc:     sumit.semwal@linaro.org, christian.koenig@amd.com,
        dongwon.kim@intel.com, linux-media@vger.kernel.org,
        linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org,
        syzbot+e9cd3122a37c5d6c51e8@syzkaller.appspotmail.com
Subject: Re: [PATCH next] udmabuf: fix general protection fault in
 udmabuf_create
Message-ID: <20210812073214.xwflqw7c6cpt3n7p@sirius.home.kraxel.org>
References: <20210811175052.21254-1-paskripkin@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210811175052.21254-1-paskripkin@gmail.com>
Precedence: bulk

On Wed, Aug 11, 2021 at 08:50:52PM +0300, Pavel Skripkin wrote:
> Syzbot reported general protection fault in udmabuf_create. The problem
> was in wrong error handling.
> 
> In commit 16c243e99d33 ("udmabuf: Add support for mapping hugepages (v4)")
> shmem_read_mapping_page() call was replaced with find_get_page_flags(),
> but find_get_page_flags() returns NULL on failure instead PTR_ERR().
> 
> Wrong error checking was causing GPF in get_page(), since passed page
> was equal to NULL. Fix it by changing if (IS_ER(!hpage)) to if (!hpage)
> 
> Reported-by: syzbot+e9cd3122a37c5d6c51e8@syzkaller.appspotmail.com
> Fixes: 16c243e99d33 ("udmabuf: Add support for mapping hugepages (v4)")
> Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>

Pushed to drm-misc-next.

thanks,
  Gerd