Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210727112328.18809-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <20210727112328.18809-3-prabhakar.mahadev-lad.rj@bp.renesas.com> <CAMuHMdWy4JNZ2=Z+FdMdHukN6rGQMma7cc+Pm06AtsOk8j_eGA@mail.gmail.com>
In-Reply-To: <CAMuHMdWy4JNZ2=Z+FdMdHukN6rGQMma7cc+Pm06AtsOk8j_eGA@mail.gmail.com>
From:   "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Date:   Thu, 12 Aug 2021 09:25:13 +0100
Message-ID: <CA+V-a8unn87anEBKfMLg4D2fK20B7=2ctMQ1x9W5+Jq9RdtikQ@mail.gmail.com>
Subject: Re: [PATCH v4 2/4] pinctrl: renesas: Add RZ/G2L pin and gpio
 controller driver
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        Rob Herring <robh+dt@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Magnus Damm <magnus.damm@gmail.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Biju Das <biju.das.jz@bp.renesas.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Geert,

Thank you for the review.

On Tue, Aug 10, 2021 at 10:13 AM Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Tue, Jul 27, 2021 at 1:23 PM Lad Prabhakar
> <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> > Add support for pin and gpio controller driver for RZ/G2L SoC.
> >
> > Based on a patch in the BSP by Hien Huynh <hien.huynh.px@renesas.com>.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
>
> Thanks for your patch!
>
> > --- /dev/null
> > +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
>
> > +static void rzg2l_pinctrl_clk_disable(void *data)
> > +{
> > +       struct clk *clk = data;
>
> No need for the intermediate variable.
>
Agreed.

> > +
> > +       clk_disable_unprepare(clk);
> > +}
> > +
> > +static int rzg2l_pinctrl_probe(struct platform_device *pdev)
> > +{
> > +       struct rzg2l_pinctrl *pctrl;
> > +       int ret;
> > +
> > +       pctrl = devm_kzalloc(&pdev->dev, sizeof(*pctrl), GFP_KERNEL);
> > +       if (!pctrl)
> > +               return -ENOMEM;
> > +
> > +       pctrl->dev = &pdev->dev;
> > +
> > +       pctrl->data = of_device_get_match_data(&pdev->dev);
> > +       if (!pctrl->data)
> > +               return -EINVAL;
> > +
> > +       pctrl->base = devm_platform_ioremap_resource(pdev, 0);
> > +       if (IS_ERR(pctrl->base))
> > +               return PTR_ERR(pctrl->base);
> > +
> > +       pctrl->clk = devm_clk_get(pctrl->dev, NULL);
> > +       if (IS_ERR(pctrl->clk)) {
> > +               ret = PTR_ERR(pctrl->clk);
> > +               dev_err(pctrl->dev, "failed to get GPIO clk : %i\n", ret);
> > +               return ret;
> > +       };
> > +
> > +       spin_lock_init(&pctrl->lock);
> > +
> > +       platform_set_drvdata(pdev, pctrl);
> > +
> > +       ret = clk_prepare_enable(pctrl->clk);
> > +       if (ret) {
> > +               dev_err(pctrl->dev, "failed to enable GPIO clk: %i\n", ret);
> > +               return ret;
> > +       };
> > +
> > +       ret = devm_add_action_or_reset(&pdev->dev, rzg2l_pinctrl_clk_disable, pctrl->clk);
>
> This line is a bit long.
>
> > +       if (ret) {
> > +               dev_err(pctrl->dev, "failed to register pinctrl clk disable devm action, %i\n",
>
> Elsewhere, this is called the "GPIO clk".
> This line is a bit long.
>
agreed.

> > +                       ret);
> > +               return ret;
> > +       }
> > +
> > +       ret = rzg2l_pinctrl_register(pctrl);
> > +       if (ret)
> > +               return ret;
> > +
> > +       dev_info(pctrl->dev, "%s support registered\n", DRV_NAME);
> > +       return 0;
> > +}
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> i.e. will queue in renesas-pinctrl-for-v5.15, with the above fixed, so no need
> to resend.
>
Thank you.

Cheers,
Prabhakar

> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds