Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp482787pxt; Thu, 12 Aug 2021 03:06:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzHCtyjKtj5io2ompaysgoeRc0AxtvEexEnkGOuNhgmVNgdSBVA8IDBVph99VfeIqBBwEfN X-Received: by 2002:a05:6402:49a:: with SMTP id k26mr4487608edv.279.1628762760986; Thu, 12 Aug 2021 03:06:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628762760; cv=none; d=google.com; s=arc-20160816; b=uOQRdkiv/MeqadV3VHHEh+N1MToMpeub8qFB05t8ZGpAZ+9UkhUpXJOEBU5gNfSiqQ aT2aGakI+dFOqqSH9PgL0x4vQApcZ61kM00+xITRlNLCkE+NrvWZiV1p2yB6fK1myiCE LsdDl55snYLZHRoc00TFzXmpSZAnLpuBLXoTXuLSh5+oijpLmvAw1owQxIXGEy09tdNJ LOWq1ZJPAWR5O4DNMFlJ5Guwa57OvRCwwhJSRqeQHRN9UWbfIAp7h/aOqTCxwfboEot/ o4Wv6IdmURTdwJzkeN0rCae6CNzNmoCoQbNq2k2/kcc0TrZ+z4YW5ltURZb97obdzdke O0ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=SfSWlMNkRusRWrFgcNlK5f+Tq18JLveXJe/Yu78G3iI=; b=lyBt9WQFYF9RWrJqPJHEHJYLACh4bUSjjl1IaP9mKM3a+QwY/xXGzq01VI69pdxWyg 0EI6h68+JUPgICACCISiuMXuqTp7Qf/s8EbHIu9UFeU1n71TPLV4vhUU90sMMJKTQVJF FJ3yJ4d+weLflbaBmiEUQO9vr2Aiars0YrIfJMSfJDIuACxtC6PJyKEjqHXtbScTNIcS MXTrYBIBmWOZ6n9LcgiEFfhrU6F7Yf51sLd/Mv4QOsqlAv0yPCXtWPqyt/0FX3HkyG1m ym911V4J/LBOnFiorAY0MxbumJKhXWuR3GPD7UO+lM0lo8pgIOS7/oyNNJrhjcUgUsMn alGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=plSLnX8Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hg14si1892973ejc.653.2021.08.12.03.05.33; Thu, 12 Aug 2021 03:06:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=plSLnX8Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235306AbhHLJW2 (ORCPT + 99 others); Thu, 12 Aug 2021 05:22:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235618AbhHLJWY (ORCPT ); Thu, 12 Aug 2021 05:22:24 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96E26C061798 for ; Thu, 12 Aug 2021 02:21:59 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id c129-20020a1c35870000b02902e6b6135279so2562794wma.0 for ; Thu, 12 Aug 2021 02:21:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SfSWlMNkRusRWrFgcNlK5f+Tq18JLveXJe/Yu78G3iI=; b=plSLnX8ZD6s40Oveh27/GmjBzf/ucPmUjZJrNgWQI7yrpGQaw9aYJVM+/EPwmjSsbe M2jb1omyczDnezm+sqCci0R/gombAiPDnzr1tRWprhlmdv7kH/t3byAF3ioWrsB6LdZK Jq/wqDLHVxcxtVRd0Xgdm0+bbRkl5ZX+5kewjCXfdqMEeBN6cTvAgqm4iij+iaC4SfHX stibatM6EHmZXPBzJ07XXAZIMvr4IJZk4PYd4a09gxJlgGrVxcu6yYvSWB3FL9F7N9HS YHSxoaxYgB+T5ISOt4lR8Y+OpGHXie880p662vtyVO5muEGUj1zhXtzra593KDc8p5Wt hIaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SfSWlMNkRusRWrFgcNlK5f+Tq18JLveXJe/Yu78G3iI=; b=UjR/zMtg/zmQykmJepcU2RM8Pw48beh19Hm0zGIHlKTD/yHpHVjoXMcE1nnZik4Bub pas8QLrxuubbS8eaoP3zeI5ZVxBhCcRClOzf5+QSOJrmNMecSol7rhsTfvPKVwse84qD 4pHH3Gy5684j5lwmlkfdYN6/t8GxFUNAKzXLGeJ3XOtZNLAUdX3TYZfOaNO2sj0wkKqW aEqY1pDtNf5uAd3p+IFM0grrmM+e8EysOiKeSutHr0Yc2ToMbZ4AOjIIor8oY7hUUoet VwXfTj+ci6nYf5CnjEWJEbL3AwvM8jqH1y/HPTdqNp4J7fRXuMrcc8o74HwsdHS//m+C x2Lg== X-Gm-Message-State: AOAM530Rbcs72UJBEdDtM0l6hkD92dt+UT3Ovfkfj7ouGQtH8u/UwHsp 4FSwJQyV4D9i6D86q/WIEb34eQ== X-Received: by 2002:a7b:cd10:: with SMTP id f16mr2922862wmj.104.1628760118152; Thu, 12 Aug 2021 02:21:58 -0700 (PDT) Received: from xps7590.fritz.box ([2a02:2454:3e5:b700:3e3:aaac:9c1f:b942]) by smtp.gmail.com with ESMTPSA id s10sm2720586wrv.54.2021.08.12.02.21.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Aug 2021 02:21:57 -0700 (PDT) From: Robert Foss To: robert.foss@linaro.org, todor.too@gmail.com, agross@kernel.org, bjorn.andersson@linaro.org, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Naresh Kamboju , Marek Szyprowski Cc: Linux Kernel Functional Testing Subject: [PATCH v2] media: camss: vfe: Don't call hw_version() before its dependencies are met Date: Thu, 12 Aug 2021 11:21:52 +0200 Message-Id: <20210812092152.726874-1-robert.foss@linaro.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org vfe->ops->hw_version(vfe) is being called before vfe->base has been assigned, and before the hardware has been powered up. Fixes: b10b5334528a9 ("media: camss: vfe: Don't read hardware version needlessly") Reported-by: Linux Kernel Functional Testing Reported-by: Marek Szyprowski Signed-off-by: Robert Foss --- drivers/media/platform/qcom/camss/camss-vfe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c index 6b2f33fc9be2..71f78b40e7f5 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe.c +++ b/drivers/media/platform/qcom/camss/camss-vfe.c @@ -604,6 +604,8 @@ static int vfe_get(struct vfe_device *vfe) vfe_reset_output_maps(vfe); vfe_init_outputs(vfe); + + vfe->ops->hw_version(vfe); } else { ret = vfe_check_clock_rates(vfe); if (ret < 0) @@ -1299,7 +1301,6 @@ int msm_vfe_subdev_init(struct camss *camss, struct vfe_device *vfe, return -EINVAL; } vfe->ops->subdev_init(dev, vfe); - vfe->ops->hw_version(vfe); /* Memory */ -- 2.30.2