Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp484413pxt; Thu, 12 Aug 2021 03:08:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzyf9VLXJgyRgN5PPC9Rgkb9xF6Nv9vJkPDkvUhod8EGzuCi1uSTQHB28GyW9EV6Ppmxy56 X-Received: by 2002:a05:6402:291d:: with SMTP id ee29mr4642115edb.289.1628762885671; Thu, 12 Aug 2021 03:08:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628762885; cv=none; d=google.com; s=arc-20160816; b=HhXQl9fFp7ojOK1qgu+1R/Erc31X45l/2cG7Mij4Ac18BoRpDKGK5ICEoP+114p11a YmeXA1lujB43tB5FOZbM510xTOASGJfEYV/2h9VOTejXr/FikYx1bC5pfvJ9rQrpdEW4 zB0DCV5aGQafFvycDOaShIpQgsWQvJ5acdH4QBAoQN0F8UZCVcMqqBsGv4sDL0Ulz/xv GFjuS8bXT8dzwj1LxsoLDwm7I4bgKQYvmq60xV2vvl3Ff9eWQA1t7xC+kXGFjgkugwAs VttTxytasxEZ2sGLFJyC6mflgH93OEKC60x8GzsTbwZQPUGQm2sfNHfMSlY+4sN5AzCj ohvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=cFzPFu3/MgvikWY91LYf8gsuLxxVbxO56YLCr9fbdMg=; b=v7f5/iCR+h9z9czWf/gYtEtBjD4FKzd/mYmj6mMFFKFgX51bMJUqsuE7HIPh0MRX2s 82eKLCyhYGVjUWiYaq3FbTYo6z5JkwTANsn7eZmF0ycgL/7Z8+fL9F3a+Td7lIKqEXhp o2yGMRP+pqdnCdSKSr7nWdX9gxUGmj/G1jCW9P1vm0Jo6ogojXv6dJSnR6v21o8pV4CV VK4Q2n+Nid0fnoVwDWXkZb/N7fe+FQLxC8rWNAnI2Qa5gyOjyVba4XC9k4Vq1+JGj0xz ty0j7KRQGeyW9+mIpi1izgqtFQyuwrVkYcG5Wk0ESrDaWRWTHLwxSgyV91goXiG3v+J/ se2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rs17si1950725ejb.193.2021.08.12.03.07.41; Thu, 12 Aug 2021 03:08:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236038AbhHLJWE (ORCPT + 99 others); Thu, 12 Aug 2021 05:22:04 -0400 Received: from verein.lst.de ([213.95.11.211]:43609 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235618AbhHLJWC (ORCPT ); Thu, 12 Aug 2021 05:22:02 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 8DC3A67373; Thu, 12 Aug 2021 11:20:44 +0200 (CEST) Date: Thu, 12 Aug 2021 11:20:43 +0200 From: Christoph Hellwig To: John Hubbard Cc: Andrew Morton , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , LKML , linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , Matthew Wilcox Subject: Re: [PATCH v2 2/3] mm/gup: small refactoring: simplify try_grab_page() Message-ID: <20210812092043.GA4827@lst.de> References: <20210811070542.3403116-1-jhubbard@nvidia.com> <20210811070542.3403116-3-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210811070542.3403116-3-jhubbard@nvidia.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks good, Reviewed-by: Christoph Hellwig Note: the __maybe_unused on try_grab_compound_head should be dropped now that there is always a user.