Received: by 2002:a05:6a10:c604:0:0:0:0 with SMTP id y4csp727746pxt; Thu, 12 Aug 2021 08:19:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw4rsmXB5j230gtnmBMqEAEVaYfHKz8bIKdvIxO+fb/4fXxZ/AfXBPDeqlJ6svDtOP4qvjO X-Received: by 2002:a50:ec0a:: with SMTP id g10mr5990498edr.125.1628781544344; Thu, 12 Aug 2021 08:19:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628781544; cv=none; d=google.com; s=arc-20160816; b=ByIu5sY3mdLBlgYZmA2UEIqXxQuhWqXLpMj178Ll/dU44oIHtPg9IXrKsz0Gg1c+Im +YgeJouTz4KvGeSWzSqXQBJpnIbLMM6xjGUtfR0qK/O6EYK8JlxKPqwSmtk+RU1fH8SU yB59c9RSUeqDOtoILOoreWvaPFbjVm03sj/SeLACtYTlhFUoTfIqHAOzpm+eX06F/M3V 9B+ElVNFY1bnFJHaOyOY1dKUJQryXYhdo/HKNI/KC1uOSgtSX2lHNp+TEjT5UvJODa+4 vunoxikQUyZJ+1nV2PTkahpCHVbXpZX+jSz/TNSzF9JR089htE1lAA1hesIkMuAVJZIh Lcgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=lI34/V4eIQUoliliSmxIRpjInkRZuDUgOhhuUQKtA0w=; b=kGl7xYfZwIvxQpejF4SVw8G+wT5GURXAVHS28nVcjo4C9aVqlalDj8b+Y+2/43TQIb GdIuiXIs5M5opvRtIBqBYPZrhzvQRPJW+H3RCgndX4TDWoItuS03Hmii64Bb4LnaK1e4 4xyKNE2DJpeaUEKWhOTrZQ/xKh1wYu+9W81X7J4m9kI+l26dwdEpshZYdRwQpNbfqaLb NuZmSOeox5FWVBirAA7mtNOwHfF+F41Sk72V6onAosX0GHlB0baMS4Q1VARrvYh8ahD4 C8XxFsC0epWX6oAqPfc40+zlpM6uq6+rhK/vYAXmSszUQ/5515BCl404Ypo/pZb/C1Xm 2nEQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v2si2995891edc.86.2021.08.12.08.18.40; Thu, 12 Aug 2021 08:19:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238067AbhHLObx (ORCPT + 99 others); Thu, 12 Aug 2021 10:31:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233293AbhHLObw (ORCPT ); Thu, 12 Aug 2021 10:31:52 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DE5AC061756; Thu, 12 Aug 2021 07:31:26 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1mEBjs-0007tz-Pr; Thu, 12 Aug 2021 16:31:20 +0200 Date: Thu, 12 Aug 2021 16:31:20 +0200 From: Florian Westphal To: Kangmin Park Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Jakub Kicinski , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: remove duplicate code Message-ID: <20210812143120.GD607@breakpoint.cc> References: <20210807062106.2563-1-l4stpr0gr4m@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kangmin Park wrote: > I checked the Changes Requested state in patchwork. > But I have not received any review mails. I did not see any either. > I wonder if there is any problem. I don't think its worth doing, the 'extra' check avoids the need for two additional function arguments (and those are not free either).