Received: by 2002:a05:6a10:8a4d:0:0:0:0 with SMTP id dn13csp506pxb; Thu, 12 Aug 2021 09:24:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwrDvJMwEbbrptzpfVIJvOxPh84hwEBHh9Vjqozrfv4AY0fF70oO8vQAewpNSTgrMBmKD/4 X-Received: by 2002:a92:cc86:: with SMTP id x6mr3679661ilo.119.1628785457565; Thu, 12 Aug 2021 09:24:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628785457; cv=none; d=google.com; s=arc-20160816; b=Tv/TrN6CtGUEvW0FQUCnq/qHEV308Wz+X4IDSUZgh+xpDpR8KZiKiv9KiT3T+l9eDq srZ4qxrOIljjTTbIjDaxoEAWd3GZIiGITr0YUMfJS/e4LicwJg2EYfryQKYmwUiLzYa7 z309mHYpfbfYesh3+uTr+njbazfpuZ4q9+xUH2aeHRqd/6ngbCyvqTRKmoN0/owui6WI 5TsKrY/A7eCdMzdS3Hc0neTE2BCZU/K/yYnSy57zsDS1VP2lWIhx/4cB7wk0TqCCLQgr bK3PKcAjSNKGWQWpfVuXtaxMYvAxqERhACZGw6K3PJu1+GpuYXhYM5JmLqE1xknXVbJ/ XeBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature:dkim-signature; bh=ppTMYje51Px+0V+L0Ygr5i3EGkcSrH/dpX1HN2hDd/0=; b=zwZZrUIq8ICd8ruMpAmqjs4Lsgr6ma35+BHLG3w5grlWBUATd6/bKIJbl1BHy78CUX 0stjprC0b8hDc57A/qvUxUEsHSKqR2RfzJpQ018qlR0H/S2BzRJiUoUy3jMJPgwKdN5A I4YE/wWX6D9BLcvMcq/3FXCnCkQ97rft4EwdoypBRzn5Mj76ek+SUeY2sZp94kYd4YGL dCz1YV3E8Mx0dP1Kx4h7vBxEYN20OU0zYQOZnMjSwpsBEuJknc5hSH/DmNZBgGLI0t+r xOB+2uIyZQcr1j49WBLBJErLpx3J5f5hvHZTikP8ZfcmfRnDKG21PqG3NXpk1OJ5wBRb ULVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=YwuBWMZH; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=5uJlCAvK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w5si3497705ilg.94.2021.08.12.09.24.05; Thu, 12 Aug 2021 09:24:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=YwuBWMZH; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=5uJlCAvK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230160AbhHLQWF (ORCPT + 99 others); Thu, 12 Aug 2021 12:22:05 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:53730 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229519AbhHLQWE (ORCPT ); Thu, 12 Aug 2021 12:22:04 -0400 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7ECB41FD64; Thu, 12 Aug 2021 16:21:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1628785298; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ppTMYje51Px+0V+L0Ygr5i3EGkcSrH/dpX1HN2hDd/0=; b=YwuBWMZHq6JzJK1VThBUHkluUBZ8Yxpb07g+Ad+YVXm73E7tWYiz6oPpk0vEiKkeecMSni eY7DoP+OqKg7Cgzi3mog+v/MNAIHV1N5Wg2TTIIJeRokXiyEMOur0iJYxFRMlwt/EIWe9f XbZcNyxWGSNFbihTh9X00EE0pawe3ZU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1628785298; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ppTMYje51Px+0V+L0Ygr5i3EGkcSrH/dpX1HN2hDd/0=; b=5uJlCAvKZZvTPJLi0Ug5Fg0AACkX8+hy8kXXAWA44yftj029lmJZ6765mga699jhJPD2il 9c2FJB2E0CV4fNAg== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 695DF13ACC; Thu, 12 Aug 2021 16:21:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id xvgRGZJKFWHmfwAAGKfGzw (envelope-from ); Thu, 12 Aug 2021 16:21:38 +0000 Subject: Re: [PATCH v14 073/138] mm/writeback: Add folio_cancel_dirty() To: "Matthew Wilcox (Oracle)" , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig References: <20210715033704.692967-1-willy@infradead.org> <20210715033704.692967-74-willy@infradead.org> From: Vlastimil Babka Message-ID: Date: Thu, 12 Aug 2021 18:21:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210715033704.692967-74-willy@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/15/21 5:35 AM, Matthew Wilcox (Oracle) wrote: > Turn __cancel_dirty_page() into __folio_cancel_dirty() and add wrappers. > Move the prototypes into pagemap.h since this is page cache functionality. > Saves 44 bytes of kernel text in total; 33 bytes from __folio_cancel_dirty > and 11 from two callers of cancel_dirty_page(). > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig Acked-by: Vlastimil Babka