Received: by 2002:a05:6a10:8a4d:0:0:0:0 with SMTP id dn13csp99328pxb; Thu, 12 Aug 2021 11:43:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy/lCSrsNde4Deyc78W4ytENf8mNeNwFi2zJptDyQCczvjPTHLEOfq0n+7L8a/NLMnK5RvM X-Received: by 2002:a05:6e02:2149:: with SMTP id d9mr4063926ilv.141.1628793786798; Thu, 12 Aug 2021 11:43:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628793786; cv=none; d=google.com; s=arc-20160816; b=jlJPymbytFjZbpjdo+MsoHftLl0zCBLWK+7tWv/wTxSoFYmzDT+HoWJa5vsp83jnLq Fq/lFO5/8i7Hmpuvoa6DQeY9Dc7ERvECkx2EkTCKqY/Na2mcVGq0NkPU7DXA3PsNP2R+ XVLpz5UJoy87kJzYPURket8KqEcEX3mC9+RahakcCs+TqDiYuXWzHb1q/i0mJ/+3sA4s jN/1+wHdlR5vQkTX2GJwiroq7DCmQQMn5Jvk6NmK6MIwMhyRDzAZfTUHJuEhMnFVD+1w Q1S5cD4AJz5TQ+y1XWG6Zm2TJqmVaDg9OwyhngqpbxPbnlPp7XnBwml60X26kM1pU6KU SJlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature:dkim-signature; bh=rtvikXvVzhf77pjK9DX6g9U2RJhd2kjezc1u1IrW7D0=; b=DCJNVMv5ijSono9n2LAJhIjc2xbTYrtGOZGw016P18rKc20YEkUGbG+GdooaAL3vtB UxuM5Q6ceusaQxkxA5Uu8gzQfiNMdy7wuluP4e46tEZ4VvukmDFV9yl1vkhXQqi7tYjp zK2rjcGnYESQ1NwSlTcek8dMX9kKw4SZ2AO7Q54uPVgriDlUkXMxIekXhemiObZIFahZ Ybn3xRNAhfdQFYOu+dOvHkFjzWK88D+198vxJ4Sv/2b/x+sBI/RQ8GmPzMzb4jRcwdPT sbwegbm0EAHJ+EFRv8yX7UotPWLn8UT2VVIUlobjzXQ9Jb2fEs3kD5Nqdh9oPIsreqPC SP4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=jsvWY403; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=YIp8Up3O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f10si4230331ila.58.2021.08.12.11.42.56; Thu, 12 Aug 2021 11:43:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=jsvWY403; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=YIp8Up3O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236390AbhHLRhl (ORCPT + 99 others); Thu, 12 Aug 2021 13:37:41 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:51322 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230018AbhHLRhk (ORCPT ); Thu, 12 Aug 2021 13:37:40 -0400 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C1ABA22258; Thu, 12 Aug 2021 17:37:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1628789833; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rtvikXvVzhf77pjK9DX6g9U2RJhd2kjezc1u1IrW7D0=; b=jsvWY403o1qR2yyFGI0LQZYk1erQXkl0GHfrYzrPmFOLKEdReDDgLKaenzLnZMa5/Fclog XjOzsWREdkRGd8a9F13RFKaHNMGSFjv8pFTg4yp6wzHZCXvjaZJHw6/zPUMwIKIpcCiaMN rK2hCXjnT4xKb6eoK0W1/gUfo43jA5c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1628789833; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rtvikXvVzhf77pjK9DX6g9U2RJhd2kjezc1u1IrW7D0=; b=YIp8Up3ObmAebni6fHUvyUd6o31EV6p+p8IHj51NHWAuEE9N5YpBJz9HXbtB/dIIhCxl6s TY5H/wb70mSpVoCw== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 9E9A013AC3; Thu, 12 Aug 2021 17:37:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id oC8/JUlcFWHoEQAAGKfGzw (envelope-from ); Thu, 12 Aug 2021 17:37:13 +0000 Subject: Re: [PATCH v14 087/138] mm/filemap: Convert mapping_get_entry to return a folio To: "Matthew Wilcox (Oracle)" , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig References: <20210715033704.692967-1-willy@infradead.org> <20210715033704.692967-88-willy@infradead.org> From: Vlastimil Babka Message-ID: Date: Thu, 12 Aug 2021 19:37:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210715033704.692967-88-willy@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/15/21 5:36 AM, Matthew Wilcox (Oracle) wrote: > The pagecache only contains folios, so indicate that this is definitely > not a tail page. Shrinks mapping_get_entry() by 56 bytes, but grows > pagecache_get_page() by 21 bytes as gcc makes slightly different hot/cold > code decisions. A net reduction of 35 bytes of text. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig Acked-by: Vlastimil Babka