Received: by 2002:a05:6a10:8a4d:0:0:0:0 with SMTP id dn13csp113507pxb; Thu, 12 Aug 2021 12:04:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx9dXC+6ZEXlLhHISZhGX3cIqgHy1258vaKfjSGcguxRJTF4pVokio2/6aKUTFVTRwuee1X X-Received: by 2002:a05:6402:54a:: with SMTP id i10mr59046edx.172.1628795053046; Thu, 12 Aug 2021 12:04:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628795053; cv=none; d=google.com; s=arc-20160816; b=seu4GT4Mv8I8jRZri0YM+9487k8uXk0dS3BLiq+xONGuCtO3BL8e8rwjuudUadA+BX egAX2hEtZmWHZRsyiVCab4jTrHZXcUEvNp7S1gpZpScpkroxt18gwcfNZaRYsP4BdOZK tFvSNyoMHb2XYJxqWF8OPY35a05MGD7W9o4hbL2FlIMu3ou1lQLZoUoaMEjosuwSy6rh KV7N4b0CfeT+HFIPJlEdRGmynqaD//PVGyZrfNORzRQEhhZBMYNUVm/G7ptQg3iOWKXT 0zxI67t4v5qOy7zO3cRrImPBz56jbc2E/uuTYiQawB/oLR+e+MOEc75HsdfUvctNpnpS FnaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature:dkim-signature; bh=Nt13wCC1vTCNH5LpjxYew01TnAzZbKvQXsUqzFCe7IU=; b=pdPo22/AOHCCXNTrvA6ExCjDeqdenFmPcontbmWItkwTRoorHFzk3h7gqV8YU3LO1y knVT38S7LBYqziiBISOTONpX8HkOCQHVSORcjIxMhuAwX4dSeOzCt+O7T0a4JmiZOoAv VEDbPY9EH0NiD1mAUll1JUNLjZu9zBefgpkvGf7pahDqlgYUMV6geksn1CRe32K1SQJZ hoIPZe6XgpgOf5dYWhJRDzA0t8MgeD8cQGtXZAp+CRqoYUCaDQ3Obd16mvRjAZDDNUZs lHceKMAqMSibjtQ6J6Py8CBC2YnYkEdC4UrXPw3Zp73r0hfrslFQM4XLCGO5NcJ6iKRm MLUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=pDbunGNV; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t4si2908706eju.720.2021.08.12.12.03.31; Thu, 12 Aug 2021 12:04:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=pDbunGNV; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236966AbhHLRs6 (ORCPT + 99 others); Thu, 12 Aug 2021 13:48:58 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:52570 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229851AbhHLRs5 (ORCPT ); Thu, 12 Aug 2021 13:48:57 -0400 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 991BA221F8; Thu, 12 Aug 2021 17:48:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1628790511; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Nt13wCC1vTCNH5LpjxYew01TnAzZbKvQXsUqzFCe7IU=; b=pDbunGNVt4PAAzII8myrj+MEsYwGrC+ERYPFticrMA3x4bH3XG5yS/G0/Ik2NbU9ZSMN53 z7rkkGMKgkEDOPNtK1thM4w4iYB0i7LPde98MQ2ZfND0x9t5M9BTM0D7mDtd/uyg4w6bgJ ja5Z46DgzQ+BqdlBnhVrqCuUo/Slu6M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1628790511; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Nt13wCC1vTCNH5LpjxYew01TnAzZbKvQXsUqzFCe7IU=; b=4XC//al3bI2/RnL8kSyIQe+zllUq5N4zyhl1Pi6nvx3BNT/3cwcJX5D/5ChmDB5u6kqIKO YW5SWMUgTla47BBA== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 7D94313AC3; Thu, 12 Aug 2021 17:48:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id yoJfHe9eFWE1FAAAGKfGzw (envelope-from ); Thu, 12 Aug 2021 17:48:31 +0000 Subject: Re: [PATCH v14 089/138] mm/filemap: Add FGP_STABLE To: "Matthew Wilcox (Oracle)" , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org References: <20210715033704.692967-1-willy@infradead.org> <20210715033704.692967-90-willy@infradead.org> From: Vlastimil Babka Message-ID: <98fae935-a50c-c604-82de-2dab5e18b6b0@suse.cz> Date: Thu, 12 Aug 2021 19:48:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210715033704.692967-90-willy@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/15/21 5:36 AM, Matthew Wilcox (Oracle) wrote: > Allow filemap_get_folio() to wait for writeback to complete (if the > filesystem wants that behaviour). This is the folio equivalent of > grab_cache_page_write_begin(), which is moved into the folio-compat > file as a reminder to migrate all the code using it. This paves the > way for getting rid of AOP_FLAG_NOFS once grab_cache_page_write_begin() > is removed. > > Kernel grows by 11 bytes. filemap_get_folio() grows by 33 bytes but > grab_cache_page_write_begin() shrinks by 22 bytes to make up for it. > > Signed-off-by: Matthew Wilcox (Oracle) Acked-by: Vlastimil Babka