Received: by 2002:a05:6a10:8a4d:0:0:0:0 with SMTP id dn13csp133843pxb; Thu, 12 Aug 2021 12:33:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwFjJD97FCivPAAABgBnijzWaPEMe7g9+OKLK5scnYXmGc4jeC3kcG8env8Ar9ql1S0xQsr X-Received: by 2002:a05:6638:148f:: with SMTP id j15mr5175701jak.61.1628796832686; Thu, 12 Aug 2021 12:33:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628796832; cv=none; d=google.com; s=arc-20160816; b=vHVbIUF9IpvZobJywMwaIajEt9Eg0xbH0Dq33yDHBaLnVoqUXC0o0p41NKZFODidI8 XfiA2g1QYm8dvZlmJ+1bsv5HKb6DtkCdosGiMnTlco7eYd3rpaChxet+OiNXH0FI93op /Gc/pOLz53KSE6mRT25DdZIpaOITp83C+VvG/pOxAbxJl1SQEjNijzNey5faGohkiAze MKVwtgdu/qAUpv2wPPPzBMXy3a54Y1HzuShc2atJA8JC0+A300flTzjj5ZmKAjg1c2Mo v6bDwWwSxQRtgOGfe9hE8JJ7/VJsPIQANU1G6LiOieVkmewHWwkCUWdgo1h9OMZzf3OS Wj1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature:dkim-signature; bh=+oIb/f55c+3egx/QhP8HshNAhJJ04qmEMqONaepnbu8=; b=EQ3woDd1dwxFsfbO04KeXqDgJotgK5VbxdpUGMcIGvtCu19W5eIOERJ/YVd8ajIxJe nuuYysMVMprrA7n2CLYp4+ULKos4SOv/2HtDIXsYiJ+GDbOOVRVax8hi3IbGpWYk1OQX H6iK9jTvA6y9JLtqB4J7PSGFGY9e8HK61Nqoty8AYIjwhNbw4cPjklPJlXmGUgMapHig C/Dv1wF4vFA+GxJY2lns2vBzhLFG69XaQbkKsnJuEJy2DT5wpyLSaHmZhYAfadpolzXi 3wzIg/IBny6co8Xs49eBTvDyftsD4TxguxvzLitgqgW5RCsu/CfIJzptNtGfxdy6WGi9 0OEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=WDMMlHYC; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=FpUSDrG2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j15si4769175ile.95.2021.08.12.12.33.41; Thu, 12 Aug 2021 12:33:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=WDMMlHYC; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=FpUSDrG2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231253AbhHLQHd (ORCPT + 99 others); Thu, 12 Aug 2021 12:07:33 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:39592 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229728AbhHLQHc (ORCPT ); Thu, 12 Aug 2021 12:07:32 -0400 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3191F222AC; Thu, 12 Aug 2021 16:07:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1628784426; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+oIb/f55c+3egx/QhP8HshNAhJJ04qmEMqONaepnbu8=; b=WDMMlHYCLY1XN65yO+0Pq+Vsd6reljX6jQm0SCfllsJc6Mhk000r/P9qocNxFkUfW2G0mX SKvBBLq2u6zWLYA/NmI9jlHhwu9Fx9MhibEDi8cUYTty7TJcBh5Mrw17fJA6qBTkBELKtJ ZLYF28c/7LyvRkYqhr5Uwd2BhQBVBRw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1628784426; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+oIb/f55c+3egx/QhP8HshNAhJJ04qmEMqONaepnbu8=; b=FpUSDrG2VlF2ApljuXOkh75NupRm4mN1igl0LD+W9yvYGnLst63PIbgTyVkg7dh22u8ZpA EOahwVRyJuwFG6Ag== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 1CA2813ACC; Thu, 12 Aug 2021 16:07:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id 7HhaBipHFWGCfAAAGKfGzw (envelope-from ); Thu, 12 Aug 2021 16:07:06 +0000 Subject: Re: [PATCH v14 071/138] mm/writeback: Add filemap_dirty_folio() To: "Matthew Wilcox (Oracle)" , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig References: <20210715033704.692967-1-willy@infradead.org> <20210715033704.692967-72-willy@infradead.org> From: Vlastimil Babka Message-ID: Date: Thu, 12 Aug 2021 18:07:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210715033704.692967-72-willy@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/15/21 5:35 AM, Matthew Wilcox (Oracle) wrote: > Reimplement __set_page_dirty_nobuffers() as a wrapper around > filemap_dirty_folio(). I assume it becomes obvious later why the new "mapping" parameter instead of taking it from the folio, but maybe the changelog should say it here? > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig Acked-by: Vlastimil Babka