Received: by 2002:a05:6a10:8a4d:0:0:0:0 with SMTP id dn13csp162452pxb; Thu, 12 Aug 2021 13:18:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxU1aSMe2+3kTqLZ4qSCq/4W9OCz5tuTEGDnAUh1YwZ3lX0zOoVOlT2O2Ci70HaujTv0jvU X-Received: by 2002:a50:d509:: with SMTP id u9mr7767300edi.35.1628799491896; Thu, 12 Aug 2021 13:18:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628799491; cv=none; d=google.com; s=arc-20160816; b=Pum9L5lZt3T0iPQ/IFQDHLX644Rokc3ChQDEYZKXokLfzaWiBGLRtRvUBX3XW26fdq Ai+ox89pjkWcMCkOZZJcWrrAHLUbYJN7j/UvwqEY50IOTnwKhR1Rours9QN2njwlyFvk i2ez1wNbzYAH384Xw/z4381lqqpeCxRMhM0HL91gi3Ilcm2UJB/qj4a4T9NRBJOujWdM OiOc5BvIblRbDuRojVuNFwQApI57NlWDu9grRNQrxy0oxdROokI7xgQ1UT+Od+UsUBlY dRcMB2hIZ6P7vLNiZuz674UFu5NAtVuan1V5oSkg9oD7tPUa87t32DbS3sIl/RUZqsyL 6SoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature:dkim-signature; bh=9B71ilSqnQ/ieejOi0NpIUgNioslQTGW0vdnNjivzJU=; b=0rX06e0w3Ee8T3OFl1g7kS94+BUR0UF4l90r3oFCgjdVJtyfmJV00WIMBz7ThKXeDp 3UbcILUvaeyfP9zoqRhhqoGBaUxciq/VI41kqwSVN3b394clWzMtptX+qzFm07lLjKjO b9mgeQp2J0ti8em12iWJ0A/xYzPLwdCrloPpWHVM3K5QSBleCyGrk8bRu7o3zbU0VNjX oJIF7rhH+NwdMPb9XF+wax3+ktsQH/hNDEpOs+j3NVz8lq0rhGXlGJAxZPsp7S2rLpKo PHWTK0WgO4m+MqToKY9LPtIHWt1vy+eeC8lQh8/hXQGqu/1MZhcj+iB02fRmEQd4vq2T DQPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=Z6c28alX; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=80VqvTuB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hp20si2993547ejc.700.2021.08.12.13.17.46; Thu, 12 Aug 2021 13:18:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=Z6c28alX; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=80VqvTuB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235318AbhHLRMb (ORCPT + 99 others); Thu, 12 Aug 2021 13:12:31 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:49366 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234825AbhHLRMa (ORCPT ); Thu, 12 Aug 2021 13:12:30 -0400 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 40FBB222A8; Thu, 12 Aug 2021 17:12:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1628788324; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9B71ilSqnQ/ieejOi0NpIUgNioslQTGW0vdnNjivzJU=; b=Z6c28alXowkONma/JF497BGrOg5gQyyb/p1Q5quuSi/+9guJenUfgPzepgJmxearm0X2C3 GyvgaNLemZY+SEUbpyMm/H97dK/nsvLx+Zq92b5oF9MT1KtKDK323QQOq+RXunkTM3BOFF LhUCSh5HNNFfxDSyF9NInU0n3giXqdg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1628788324; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9B71ilSqnQ/ieejOi0NpIUgNioslQTGW0vdnNjivzJU=; b=80VqvTuBHa2ZIR7MNsF3o0mFGllkLaHeTemCWWos+Fs8zE6FWnqEeGfJtAVO0cAyuxQT9N 8WNL0AZLLZsWHqAA== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 242D413AC3; Thu, 12 Aug 2021 17:12:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id iIatB2RWFWFjDAAAGKfGzw (envelope-from ); Thu, 12 Aug 2021 17:12:04 +0000 Subject: Re: [PATCH v14 079/138] mm/filemap: Add readahead_folio() To: "Matthew Wilcox (Oracle)" , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig References: <20210715033704.692967-1-willy@infradead.org> <20210715033704.692967-80-willy@infradead.org> From: Vlastimil Babka Message-ID: Date: Thu, 12 Aug 2021 19:12:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210715033704.692967-80-willy@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/15/21 5:36 AM, Matthew Wilcox (Oracle) wrote: > The pointers stored in the page cache are folios, by definition. > This change comes with a behaviour change -- callers of readahead_folio() > are no longer required to put the page reference themselves. This matches > how readpage works, rather than matching how readpages used to work. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig Acked-by: Vlastimil Babka