Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Waiman Long <llong@redhat.com>
Subject: Re: [PATCH -tip] locking: Move CONFIG_LOCK_EVENT_COUNTS into Kernel
 hacking section
To:     Davidlohr Bueso <dave@stgolabs.net>, peterz@infradead.org,
        mingo@redhat.com
Cc:     will@kernel.org, linux-kernel@vger.kernel.org,
        Davidlohr Bueso <dbueso@suse.de>
References: <20210330020636.112594-1-dave@stgolabs.net>
 <20210812190526.mfrz5ifdodbncz3w@offworld>
Message-ID: <de40081c-82c8-e22a-4b24-f9fd91e3921e@redhat.com>
Date:   Thu, 12 Aug 2021 15:42:18 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210812190526.mfrz5ifdodbncz3w@offworld>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk

On 8/12/21 3:05 PM, Davidlohr Bueso wrote:
> Ping?
>
> On Mon, 29 Mar 2021, Davidlohr Bueso wrote:
>
>> It's a lot more intuitive to have it in the locking section of the 
>> kernel
>> hacking part rather than under "General architecture-dependent options".
>>
>> Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
>> ---
>> arch/Kconfig      | 9 ---------
>> lib/Kconfig.debug | 9 +++++++++
>> 2 files changed, 9 insertions(+), 9 deletions(-)
>>
>> diff --git a/arch/Kconfig b/arch/Kconfig
>> index ecfd3520b676..d6f9aeaaf9f2 100644
>> --- a/arch/Kconfig
>> +++ b/arch/Kconfig
>> @@ -1113,15 +1113,6 @@ config HAVE_ARCH_PREL32_RELOCATIONS
>> config ARCH_USE_MEMREMAP_PROT
>>     bool
>>
>> -config LOCK_EVENT_COUNTS
>> -    bool "Locking event counts collection"
>> -    depends on DEBUG_FS
>> -    help
>> -      Enable light-weight counting of various locking related events
>> -      in the system with minimal performance impact. This reduces
>> -      the chance of application behavior change because of timing
>> -      differences. The counts are reported via debugfs.
>> -
>> # Select if the architecture has support for applying RELR relocations.
>> config ARCH_HAS_RELR
>>     bool
>> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
>> index 2779c29d9981..76639ff5998c 100644
>> --- a/lib/Kconfig.debug
>> +++ b/lib/Kconfig.debug
>> @@ -1401,6 +1401,15 @@ config DEBUG_LOCKING_API_SELFTESTS
>>       The following locking APIs are covered: spinlocks, rwlocks,
>>       mutexes and rwsems.
>>
>> +config LOCK_EVENT_COUNTS
>> +    bool "Locking event counts collection"
>> +    depends on DEBUG_FS
>> +    help
>> +      Enable light-weight counting of various locking related events
>> +      in the system with minimal performance impact. This reduces
>> +      the chance of application behavior change because of timing
>> +      differences. The counts are reported via debugfs.
>> +
>> config LOCK_TORTURE_TEST
>>     tristate "torture tests for locking"
>>     depends on DEBUG_KERNEL
>> -- 
>> 2.26.2
>>
>
I have no objection to that.

Acked-by: Waiman Long <longman@redhat.com>