Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933924AbWLAHVK (ORCPT ); Fri, 1 Dec 2006 02:21:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933892AbWLAHVK (ORCPT ); Fri, 1 Dec 2006 02:21:10 -0500 Received: from smtp.osdl.org ([65.172.181.25]:60336 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S933603AbWLAHVI (ORCPT ); Fri, 1 Dec 2006 02:21:08 -0500 Date: Thu, 30 Nov 2006 23:21:02 -0800 From: Andrew Morton To: Nick Piggin Cc: OGAWA Hirofumi , Linux Kernel Mailing List , linux-fsdevel@vger.kernel.org Subject: Re: [patch 3/3] fs: fix cont vs deadlock patches Message-Id: <20061130232102.0cc7fc0b.akpm@osdl.org> In-Reply-To: <20061201050852.GA31347@wotan.suse.de> References: <20061130072058.GA18004@wotan.suse.de> <20061130072202.GB18004@wotan.suse.de> <20061130072247.GC18004@wotan.suse.de> <20061130113241.GC12579@wotan.suse.de> <87r6vkzinv.fsf@duaron.myhome.or.jp> <20061201020910.GC455@wotan.suse.de> <87mz68xoyi.fsf@duaron.myhome.or.jp> <20061201050852.GA31347@wotan.suse.de> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2209 Lines: 59 On Fri, 1 Dec 2006 06:08:52 +0100 Nick Piggin wrote: > On Fri, Dec 01, 2006 at 12:41:25PM +0900, OGAWA Hirofumi wrote: > > > > Yes, this patch doesn't pass zero-length to prepare_write. However, > > I'm not checking this patch is ok for reiserfs... > > OK, vfat wasn't working correctly for me -- I needed the following patch: Now I'm confused. What relationship does this patch have to the below? revert-generic_file_buffered_write-handle-zero-length-iovec-segments.patch revert-generic_file_buffered_write-deadlock-on-vectored-write.patch generic_file_buffered_write-cleanup.patch mm-only-mm-debug-write-deadlocks.patch mm-fix-pagecache-write-deadlocks.patch mm-fix-pagecache-write-deadlocks-comment.patch mm-fix-pagecache-write-deadlocks-xip.patch mm-fix-pagecache-write-deadlocks-mm-pagecache-write-deadlocks-efault-fix.patch mm-fix-pagecache-write-deadlocks-zerolength-fix.patch mm-fix-pagecache-write-deadlocks-stale-holes-fix.patch fs-prepare_write-fixes.patch fs-prepare_write-fixes-fuse-fix.patch fs-prepare_write-fixes-jffs-fix.patch fs-prepare_write-fixes-fat-fix.patch fs-fix-cont-vs-deadlock-patches.patch > Index: linux-2.6/fs/buffer.c > =================================================================== > --- linux-2.6.orig/fs/buffer.c 2006-12-01 15:31:22.000000000 +1100 > +++ linux-2.6/fs/buffer.c 2006-12-01 16:02:23.000000000 +1100 > @@ -2102,6 +2102,7 @@ Please always use `diff -p' > *bytes |= (blocksize-1); > (*bytes)++; > } > + > status = __block_prepare_write(inode, new_page, zerofrom, > PAGE_CACHE_SIZE, get_block); > if (status) > @@ -2110,7 +2111,7 @@ > memset(kaddr+zerofrom, 0, PAGE_CACHE_SIZE-zerofrom); > flush_dcache_page(new_page); > kunmap_atomic(kaddr, KM_USER0); > - generic_commit_write(NULL, new_page, zerofrom, PAGE_CACHE_SIZE); > + __block_commit_write(inode, new_page, zerofrom, PAGE_CACHE_SIZE); Whatever function this is doesn't need to update i_size? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/