Received: by 2002:a05:6a10:8a4d:0:0:0:0 with SMTP id dn13csp268611pxb; Thu, 12 Aug 2021 16:10:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwH5ZBQmc2ja7MwVGF9Nz52/1BpOfDPqA41C2WTsBw2Ff4EfQBSZppCJc7hYFHTBvZ2MW2v X-Received: by 2002:a05:6402:50d4:: with SMTP id h20mr8386749edb.7.1628809849932; Thu, 12 Aug 2021 16:10:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628809849; cv=none; d=google.com; s=arc-20160816; b=rnaSCsIGjMhCoL1AFUmNHXIfxmNz8iDPL57/HfqZJ6ww7JguvrCvlDDGsQPWfTJp66 mTPq5JmMpbPaP/fI4W1MjHyjFQSxgNIpEWBrh+dlsOWhhSMWM3wpom2H3dqBDtoAXDy4 W7VfyTqfDashKrCBDVpkrSSObOEPxIFPREbcXGnyVV1r/Bmgvj73OxO3P08w4mMBwZpH yt+NBsU+6Fvxp/CioYKeWA2gOTpJRxG2Bx5umEMheN16tCNSVLW5xfYYsTZb2LT3k2RV 70ENUQqplVBwpP5Q71VT1Md11QHU7e8Lh6W6azLniMqIERf1XrEknkUmCZtrVqUR3KEj Qo2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject; bh=ZR7GMVczHSMOI6p6wis7jr3/vhPLDABjimYutH2qJYY=; b=sbuK6Nmb2p9CCexi12yx5vd8+L+Ip7HcnaD/QJitSrN0vhoAtqwHB1kzu8FugBUzkn 7SIeYajO887uZPN5xtybcx2185tFyv5kju1acY4jCWh/u9UNxnn1T3Hk7EAOBUR6ECRI WZW0eqTmV3nik4fL6Oe9ugPSKwzW5QJAYIjwYZYGISNIeATOX/2nmtprA7Z4qJAuw8o7 QcbY2eoQLhMFRx+9bTKODjtdZBqdfHSQ6zsd9YLf0FguWIuI5k89GMd/Tuu3rYbWSXUG SXLtvyYLJy7zcZD/wDCCTYdiV0/Sf+Yh+eWF1kt3KjDofLZpmCL6XCCrSVzQzbKNE0FM gu4w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id du15si3732370ejc.498.2021.08.12.16.10.24; Thu, 12 Aug 2021 16:10:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232353AbhHLVnv (ORCPT + 99 others); Thu, 12 Aug 2021 17:43:51 -0400 Received: from mga12.intel.com ([192.55.52.136]:22897 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234019AbhHLVnt (ORCPT ); Thu, 12 Aug 2021 17:43:49 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10074"; a="195041478" X-IronPort-AV: E=Sophos;i="5.84,317,1620716400"; d="scan'208";a="195041478" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Aug 2021 14:43:22 -0700 X-IronPort-AV: E=Sophos;i="5.84,317,1620716400"; d="scan'208";a="517630152" Received: from wtharris-mobl1.amr.corp.intel.com (HELO [10.209.22.190]) ([10.209.22.190]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Aug 2021 14:43:21 -0700 Subject: Re: [PATCH 2/5] efi/x86: Implement support for unaccepted memory To: "Kirill A. Shutemov" Cc: Borislav Petkov , Andy Lutomirski , Sean Christopherson , Andrew Morton , Joerg Roedel , Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Vlastimil Babka , Tom Lendacky , Thomas Gleixner , Peter Zijlstra , Paolo Bonzini , Ingo Molnar , Varad Gautam , Dario Faggioli , x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, "Kirill A. Shutemov" References: <20210810062626.1012-1-kirill.shutemov@linux.intel.com> <20210810062626.1012-3-kirill.shutemov@linux.intel.com> <142bccc6-0e67-dfc1-9069-b773c2bad585@intel.com> <20210812211449.5bsblj6lphtu7zsd@box.shutemov.name> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <6cf6199c-3c3f-3f36-5570-eadfadb89b30@intel.com> Date: Thu, 12 Aug 2021 14:43:19 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210812211449.5bsblj6lphtu7zsd@box.shutemov.name> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/12/21 2:14 PM, Kirill A. Shutemov wrote: > On Tue, Aug 10, 2021 at 10:50:33AM -0700, Dave Hansen wrote: >>> + if ((start & PMD_MASK) == (end & PMD_MASK)) { >>> + npages = (end - start) / PAGE_SIZE; >>> + __accept_memory(start, start + npages * PAGE_SIZE); >>> + return; >>> + } >> >> Hmm, is it possible to have this case hit, but neither of the two below >> cases? This seems to be looking for a case where the range is somehow >> entirely contained in one PMD_SIZE area, but where it doesn't consume a >> whole area. >> >> Wouldn't that mean that 'start' or 'end' must be unaligned? > > The problem is that if both of them unaligned round_up() and round_down() > in the cases below would step outside the requested range. Ahh, got it. You might want to add some comments like: /* Immediately accept whole thing if within a PMD_SIZE block: */ /* Immediately accept a >> + if (start & ~PMD_MASK) { >>> + npages = (round_up(start, PMD_SIZE) - start) / PAGE_SIZE; >>> + __accept_memory(start, start + npages * PAGE_SIZE); >>> + start = round_up(start, PMD_SIZE); >>> + } >>> + >>> + if (end & ~PMD_MASK) { >>> + npages = (end - round_down(end, PMD_SIZE)) / PAGE_SIZE; >>> + end = round_down(end, PMD_SIZE); >>> + __accept_memory(end, end + npages * PAGE_SIZE); >>> + } >>> + npages = (end - start) / PMD_SIZE; >>> + bitmap_set((unsigned long *)params->unaccepted_memory, >>> + start / PMD_SIZE, npages); >>> +} One note as I'm looking at this again: 'npages' can be 0. Imagine if you had an 8k region that started with the last 4k page of a 2M area and ended on the first 4k page of the next 2M area, like 0x1ff000->0x201000. I think it's harmless and bitmap_set() seems to handle it correctly. But, it's probably worth a comment because it's not obvious.