DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=ab4ZOQpaNoDnJowhvClJzMROofYO43dfECtPwNFJ1gzoup3qCU10T4NvC3BdSSnLGt2Y0d0gsrO2s+OfAESeHRG4u/OeGBod0RFa1IagERbyMvar5nw6LzRAAYKJpCbSc6wP1rGufY56r++lneV9cgMD82cf2NSZJNAvchF/xs4=
Message-ID: <3a5b1be00612010040r5ee24696h71119adb0a9bbffe@mail.gmail.com>
Date: Fri, 1 Dec 2006 10:40:27 +0200
From: "Komal Shah" <komal.shah802003@gmail.com>
To: "Paul Jackson" <pj@sgi.com>
Subject: =?ISO-8859-1?Q?Re:_bitmap=AD=5Ffind=5Ffree=5Fregio?= =?ISO-8859-1?Q?n_and_bitmap=5Ffull_arg_doubts?=
Cc: "Paul Mundt" <lethal@linux-sh.org>, "M. R. Brown" <mrbrown@0xd6.org>,
       linux-kernel@vger.kernel.org, akpm@osdl.org
In-Reply-To: <20061130161008.5417c8b4.pj@sgi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <3a5b1be00611300733y121ef089m66bf46852ec0866d@mail.gmail.com>
	 <20061130161008.5417c8b4.pj@sgi.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2147
Lines: 54

On 12/1/06, Paul Jackson <pj@sgi.com> wrote:
>
>   M. R. Brown and Paul Mundt -- take a look at the question at end of this post.
>
> Komal wrote:
> >
> > I have attached the test module code. I have confusion about the what
> > to pass as second argument of bitmap_find_free_region for 2nd layer
> > bitmap.
> >
> > Do we have to pass "total size of the block...here 128MB" as the
> > second argument or no. of bits in that block, which 32768 (128 >>
> > PAGE_SHIFT) ?
> >
> > This confusion arised as store queue implementation (sq.c) of sh arch,
> > passes total size of the bitmap (64M) as the second argument instead
> > of bits.
> >
> > Same is the case with bitmap_full, where I have to pass total size of
> > the block (here 128MB) instead of no. of bits, in-order it to make my
> > test module work correctly.
>
> A bitmap is essentially an array of bits.  The bitmap_* routines should
> take a count of how many bits are in the bitmap array (or in your case,
> how many bits are in the segment that you expect to be used in that call.)
>
> So I'm guessing you will be passing L2_BM_BITS for that second argument.
>
> The call to bitmap_find_free_region(), in arch/sh/kernel/cpu/sh4/sq.c
> looks bogus:
>
>         page = bitmap_find_free_region(sq_bitmap, 0x04000000,
>                                        get_order(map->size));
>
> It says the bitmap has 0x04000000 bits.  This would take 0x04000000 / 8
> which is 8388608 (decimal) bytes to hold.  That's an insanely
> huge bitmap - 8 million bytes worth of bits.
>
> I can't make entire sense of the the code you attached.  I get confused
> over the various sizes of maps and what the maps represent, and of bits
> and bytes, and of the two levels.
>

Thanx for clarifying. I am now able to understand it properly, and I
will modify my code, so that it will be easy to understand/read :)

-- 
---Komal Shah
http://komalshah.blogspot.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/