Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210811225442.9537-1-rdunlap@infradead.org>
In-Reply-To: <20210811225442.9537-1-rdunlap@infradead.org>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Fri, 13 Aug 2021 16:27:56 +0900
Message-ID: <CAK7LNASJi3HWY9ut8+mkSOAWD=QxB7ftnkHdqZRW0fLbO5NDhg@mail.gmail.com>
Subject: Re: [PATCH] kbuild: allow "make" targets 'versioncheck' and
 'includecheck' withoug .config file
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Michal Marek <michal.lkml@markovi.net>,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Aug 12, 2021 at 7:54 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Top-level Makefile targets 'versioncheck' and 'includecheck' don't
> need a configured kernel (i.e., don't need a .config file), so add
> them the the list of "no-dot-config-targets".
> This eliminates the 'make' error:
>
> ***
> *** Configuration file ".config" not found!
> ***
> *** Please run some configurator (e.g. "make oldconfig" or
> *** "make menuconfig" or "make xconfig").
> ***
> Makefile:759: include/config/auto.conf.cmd: No such file or directory
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Cc: Michal Marek <michal.lkml@markovi.net>
> Cc: linux-kbuild@vger.kernel.org
> ---
> Fixes: I couldn't determine this.
>
>  Makefile |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- linux-next-20210811.orig/Makefile
> +++ linux-next-20210811/Makefile
> @@ -274,7 +274,8 @@ no-dot-config-targets := $(clean-targets
>                          cscope gtags TAGS tags help% %docs check% coccicheck \
>                          $(version_h) headers headers_% archheaders archscripts \
>                          %asm-generic kernelversion %src-pkg dt_binding_check \
> -                        outputmakefile rustfmt rustfmtcheck
> +                        outputmakefile rustfmt rustfmtcheck \
> +                        versioncheck includecheck
>  # Installation targets should not require compiler. Unfortunately, vdso_install
>  # is an exception where build artifacts may be updated. This must be fixed.
>  no-compiler-targets := $(no-dot-config-targets) install dtbs_install \


There is no good reason to invoke checkincludes.pl via GNU Make
in the first place.


A better solution is to do it by a shell script
or to make checkincludes.pl traverse the
subdirectories by itself.


[1] An easy solution

Add scripts/checkincludes-all:


#!/bin/sh
find . -name '*.[hcS]' -type f -print | sort \
  | xargs $(dirname $0)/checkincludes.pl


Then, remove the 'includecheck' target from the Makefile.

You can do 'scripts/checkincludes-all'
instead of 'make includecheck'.


[2] A better solution

Extend scripts/checkincludes.pl so that it checks
all *.[hcS] files under the current directory
when no argument is passed.

You can simply do 'scripts/checkincludes.py'


-- 
Best Regards
Masahiro Yamada