Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v14 062/138] mm/migrate: Add folio_migrate_copy()
To:     Matthew Wilcox <willy@infradead.org>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        linux-fsdevel@vger.kernel.org
References: <20210715033704.692967-1-willy@infradead.org>
 <20210715033704.692967-63-willy@infradead.org>
 <b9c3038a-56af-95e9-b5dd-8e88f508719e@suse.cz>
 <YRXyGg7MWZTLA+YU@casper.infradead.org>
From:   Vlastimil Babka <vbabka@suse.cz>
Message-ID: <c33999ee-64ce-cf00-a457-66fb6b90a64d@suse.cz>
Date:   Fri, 13 Aug 2021 10:33:19 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <YRXyGg7MWZTLA+YU@casper.infradead.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/13/21 6:16 AM, Matthew Wilcox wrote:
> On Thu, Aug 12, 2021 at 01:56:24PM +0200, Vlastimil Babka wrote:
>> On 7/15/21 5:35 AM, Matthew Wilcox (Oracle) wrote:
>> > This is the folio equivalent of migrate_page_copy(), which is retained
>> > as a wrapper for filesystems which are not yet converted to folios.
>> > Also convert copy_huge_page() to folio_copy().
>> > 
>> > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
>> 
>> Acked-by: Vlastimil Babka <vbabka@suse.cz>
>> 
>> The way folio_copy() avoids cond_resched() for single page would IMHO deserve a
>> comment though, so it's not buried only in this thread.
> 
> I think folio_copy() deserves kernel-doc.
> 
> /**
>  * folio_copy - Copy the contents of one folio to another.
>  * @dst: Folio to copy to.
>  * @src: Folio to copy from.
>  *
>  * The bytes in the folio represented by @src are copied to @dst.
>  * Assumes the caller has validated that @dst is at least as large as @src.
>  * Can be called in atomic context for order-0 folios, but if the folio is
>  * larger, it may sleep.
>  */
> 
LGTM.