Received: by 2002:a05:6a10:8a4d:0:0:0:0 with SMTP id dn13csp838483pxb; Fri, 13 Aug 2021 07:27:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyfmBR70YHY2cC5qSGiBkSYRF6LsQ+T6J8OuZIpTk0twfjjOG7ErDIjYe2hkjosZIMMBH81 X-Received: by 2002:a05:6602:583:: with SMTP id v3mr2184777iox.91.1628864862111; Fri, 13 Aug 2021 07:27:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628864862; cv=none; d=google.com; s=arc-20160816; b=L8TYs38MexKZebIkLPOMfCqbZsXXqIyr2u2HgIAusum6xIzOV0HnC0pUrtiRX77yEY Cebni8MztW9zi5UUnkWI7PgwvUcTPOjhpRNhq5vVW8cpHhcZYG2XMWiphsNcfYz71hJj YAy9emuTPNJ09z9yaqIMswcEqPDEAX6XjnstddgSLvX8Of+Tlb0xBSmlQ3DiSOb44Ca7 S+wXHB9vYnVB6KkLJCd5I87zqmJhgUV+DYqrFOOXduzjEsIuA+MEhVmDPpKp6kMnUVMp oeolF4knGfb6SlvVf3t7btLTNSgbtyJmlcLlH9PY0YQuIENdDkSp4PrwL94Sfdn4XtbT fD1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=aUDtlGi3kW5PjimkWmIWUVsfjpe7bJQtlrvZYOmJzQY=; b=0Hl3t+dI8N2ekGNi7DvedPcwcI3mQoOJvE9Hoxr0L1tn0yX47ySG/wHbChgEjrgry0 fY7PtCF+X5TC2XEzlqnh3Lqc6YBU9vCcpv8SYhkJhvJAL4mHBSKDgtnSArfkZqEAuXD2 fj/CI9rNlJZo3Ch8MR86o9v8KzTrk3zuGzNSUiFYtwweRMoj2gPeaRl9Yu5CZVEId7jq CO/M1Py/yi1nr/1dl1Jew7nYtK7I8ChRinsPs+4dsVpmmNDx3MyZzSAEUChnrbaDZDwA eGlSEtQjk0bjA2AZZrBnXcNP/Z5SQqrgp6bCCAS1YJqrTeFCOVHDIwXM92LCJNCpbb8h GMqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q23si1599633jav.118.2021.08.13.07.27.31; Fri, 13 Aug 2021 07:27:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240678AbhHMNyj (ORCPT + 99 others); Fri, 13 Aug 2021 09:54:39 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:3648 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240753AbhHMNyh (ORCPT ); Fri, 13 Aug 2021 09:54:37 -0400 Received: from fraeml737-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4GmQ4p5mwHz6GDFx; Fri, 13 Aug 2021 21:53:30 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml737-chm.china.huawei.com (10.206.15.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Fri, 13 Aug 2021 15:54:08 +0200 Received: from localhost.localdomain (10.69.192.58) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 13 Aug 2021 14:54:06 +0100 From: John Garry To: , , , , CC: , , , , , John Garry Subject: [PATCH 2/3] scsi: fnic: Stop setting scsi_cmnd.tag Date: Fri, 13 Aug 2021 21:49:12 +0800 Message-ID: <1628862553-179450-3-git-send-email-john.garry@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1628862553-179450-1-git-send-email-john.garry@huawei.com> References: <1628862553-179450-1-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.69.192.58] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is never read. Setting it and the request tag seems dodgy anyway. Signed-off-by: John Garry --- drivers/scsi/fnic/fnic_scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c index 0f9cedf78872..f8afbfb468dc 100644 --- a/drivers/scsi/fnic/fnic_scsi.c +++ b/drivers/scsi/fnic/fnic_scsi.c @@ -2213,7 +2213,7 @@ fnic_scsi_host_start_tag(struct fnic *fnic, struct scsi_cmnd *sc) if (IS_ERR(dummy)) return SCSI_NO_TAG; - sc->tag = rq->tag = dummy->tag; + rq->tag = dummy->tag; sc->host_scribble = (unsigned char *)dummy; return dummy->tag; -- 2.26.2