Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <42a2672432301de9beee593765bb49f739ce493a.camel@kernel.org>
Subject: Re: [PATCH 0/1] tracing: Provide more parseable hist trigger output
From:   Tom Zanussi <zanussi@kernel.org>
To:     Masami Hiramatsu <mhiramat@kernel.org>
Cc:     rostedt@goodmis.org, bristot@kernel.org,
        linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Date:   Fri, 13 Aug 2021 10:31:03 -0500
In-Reply-To: <20210813182436.0ca56fe333a80fb7188f0b14@kernel.org>
References: <cover.1628807056.git.zanussi@kernel.org>
         <20210813182436.0ca56fe333a80fb7188f0b14@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Masami,

On Fri, 2021-08-13 at 18:24 +0900, Masami Hiramatsu wrote:
> Hi Tom,
> 
> On Thu, 12 Aug 2021 17:43:23 -0500
> Tom Zanussi <zanussi@kernel.org> wrote:
> 
> > Hi Steve and Daniel,
> > 
> > Following our discussion last week about more parseable hist
> > trigger
> > output, I started trying to implement the 'csv' output you had
> > mentioned, but realized that since it was more than just table
> > output
> > that was needed, JSON would be a better fit, so implemented that in
> > this patch instead.
> 
> This seems really good feature! BTW, what about adding an tracing
> option to switch the hist output format?
> e.g.
> 
> $ echo 1 > /sys/kernel/tracing/options/hist-json
> 
> This will no need to add additional pseudo file but just add an
> option to
> the ftrace.
> 

That sounds like a good idea, thanks for the suggestion!

Tom