Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Hongbo Wang <hongbo.wang@nxp.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     Hongjun Chen <hongjun.chen@nxp.com>, Po Liu <po.liu@nxp.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        Leo Li <leoyang.li@nxp.com>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
        "vivien.didelot@gmail.com" <vivien.didelot@gmail.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH v1] arm64: dts: fsl: ls1028a-rdb: Add dts file
 to choose swp5 as dsa master
Thread-Topic: [EXT] Re: [PATCH v1] arm64: dts: fsl: ls1028a-rdb: Add dts file
 to choose swp5 as dsa master
Thread-Index: AQHXj+75u2Pfw5dj90eW5XnXIP17J6txaSUAgAAItjA=
Date:   Fri, 13 Aug 2021 13:56:53 +0000
Message-ID: <VI1PR04MB56773CC01AB86A8AA1A33F9AE1FA9@VI1PR04MB5677.eurprd04.prod.outlook.com>
References: <20210813030155.23097-1-hongbo.wang@nxp.com>
 <YRZvItRlSpF2Xf+S@lunn.ch>
In-Reply-To: <YRZvItRlSpF2Xf+S@lunn.ch>
Accept-Language: zh-CN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?A6qSiSxRcXqVPA+clWCa+RWd0xjzOHi91UWlouqe6nIzkutQIDH/YrH6nAJf?=
 =?us-ascii?Q?euNXk6u2XqjPzrJspVAkZJ8cHB8eHhe2tqgZbRU8PS5ZxvHzYHBq1dZ/GQce?=
 =?us-ascii?Q?OLFPuT9j/0Y/3RNdw1ffS1KXdkaBGu0jH4lHKIntg/swz6ZVAR6sV4BAX3Py?=
 =?us-ascii?Q?UsTZgXivbITP9xjbpi4+Xi0W1MMJxHUt5BnN4ea2OxgHqX8Qd4qf0J3dt7w4?=
 =?us-ascii?Q?WX1X1xoNelfx2lIfkENJ//XepMOvX09S1Y8GU8CY1PVunZYseWESNh3FyCok?=
 =?us-ascii?Q?uXX0Py4I+VpRIC8QMKsgiGSeCR/xy/VRY/3V5kR3nfv0PNMpStskSfpfAXHb?=
 =?us-ascii?Q?YXLjvAqW+P76lyPo6GMyUoT+NFUuub6F4PnV8zlm0+OQGhTM07zozKyFQ1re?=
 =?us-ascii?Q?oSHLHuHLcPoo8GgC+ugQqaONzK+mDNhKH9uQ/OwscZlOK/2edCcsSZXFweGJ?=
 =?us-ascii?Q?GTIea9DGUwndfS0Bl2iIZ6KI87Y/dF/PXrYSrJ3H7xzSG/DGszSKKNf+VOJ+?=
 =?us-ascii?Q?HqfV8vnnT9K4h397MdE94PyqWAznSbrq4YbxBBPk75fyJkk9TZL6R/YXH8P1?=
 =?us-ascii?Q?FblzQ+fu+ukBocMy0vJw/ZM40HUzqPcM0vwKYjsge41ZDMQgTJFcHnUUa67A?=
 =?us-ascii?Q?PBfc51/rUwO1F3ve/lCTf+ilLKz7o7AU7b4lwWISbrbNhwc13msd6+vAVI36?=
 =?us-ascii?Q?HcVJAAT7TsG3bKlfbj8N0i3Y0pDi3CKIHqlWtiTznlSt/h1MyUoxMIjvp6p6?=
 =?us-ascii?Q?wsdOAjCYfQHQBTyMBO9I5/AT1exv4aZnjx22PTUwt2auxQbojdpElv2eQqiK?=
 =?us-ascii?Q?oP011RIQHYQcbtp4gT55gwHxGowT7lETpgPWwI7jOU1U6Kljp8XEQb0pa9RL?=
 =?us-ascii?Q?ECi0SDhCnIDTsXa1dGNw109l+uq0YyAfDV6w7Kkr9C2KeQLQV9igH1Av6hIe?=
 =?us-ascii?Q?4H0OlttPhv568fxm5e7iCMueLLCIZ4b8DsVgMebjH7lWqOWL6oE76tos0QdB?=
 =?us-ascii?Q?Switrb8amTjbjBYznLgDUubNFklBaeBlBOAX0GccpZMnd9+55p5F8vQpgZWb?=
 =?us-ascii?Q?Sc1ZSJNRvOgVuqcg4kF+BILJgK4kIPtZuK2FlJH0UJiQK+I1npKFm17aBuXi?=
 =?us-ascii?Q?XQ1v/L2O8YitTnsBXXS6bNqnDp4KQ96X+9R7iiDW7N6dRfi9w+kw2RSgP43o?=
 =?us-ascii?Q?E7HOihJNsMJhYAzBfgBcgCKZjYBdzT41NsaWK8X5ggtE8D5PhC1OaC/usgtV?=
 =?us-ascii?Q?h466PZN3n3TV/LV3bXRQ0l2qIP0fkuzodDmebt/ZhZJGlAIIn0YIgb7oGG8V?=
 =?us-ascii?Q?AT0I/b8HfRnMKNt4E/lyMp0c?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5677.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e36a14c8-88b4-4a21-6953-08d95e6234fc
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Aug 2021 13:56:53.6080
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dNExaafcsnvxeG0D1u6LXRNJDICqKgpb0Vs27MJXXqzDZwmfPhTSmoGHV7R2Ek+W3maqVbsJQgQheg164lDNYg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7213
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Fri, Aug 13, 2021 at 11:01:55AM +0800, hongbo.wang@nxp.com wrote:
> > From: hongbo wang <hongbo.wang@nxp.com>
> >
> > some use cases want to use swp4-eno2 link as ordinary data path, so we
> > can enable swp5 as dsa master, the data from kernel can be transmitted
> > to eno3, then send to swp5 via internal link, switch will forward it
> > to swp0-3.
> >
> > the data to kernel will come from swp0-3, and received by kernel via
> > swp5-eno3 link.
>=20
> > new file mode 100644
> > index 000000000000..a88396c137a1
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb-dsa-swp5-eno3.dts
> > @@ -0,0 +1,27 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > + * Device Tree file for NXP LS1028A RDB with dsa master swp5-eno3.
> > + *
> > + * Copyright 2018-2021 NXP
> > + *
> > + * Hongbo Wang <hongbo.wang@nxp.com>
> > + *
> > + */
> > +
> > +/dts-v1/;
> > +#include "fsl-ls1028a-rdb.dts"
>=20
> You will end up with two DT blobs with the same top level compatible. Thi=
s is
> going to cause confusion. I suggest you add an additional top level compa=
tible
> to make it clear this differs from the compatible =3D "fsl,ls1028a-rdb",
> "fsl,ls1028a" blob.
>=20
>    Andrew

hi Andrew,=20

  thanks for comments.

  this "fsl-ls1028a-rdb-dsa-swp5-eno3.dts" is also for fsl-ls1028a-rdb plat=
form,
the only difference with "fsl-ls1028a-rdb.dts" is that it use swp5 as dsa m=
aster, not swp4,
and it's based on "fsl-ls1028a-rdb.dts", so I choose this manner,
if "fsl-ls1028a-rdb.dts" has some modification for new version, this file d=
on't need be changed.

thanks,
hongbo