Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 13 Aug 2021 19:56:44 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     David Howells <dhowells@redhat.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        linux-fsdevel@vger.kernel.org, Michal Hocko <mhocko@suse.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v14 035/138] mm/memcg: Use the node id in
 mem_cgroup_update_tree()
Message-ID: <YRbAbHraZjY1dwSG@casper.infradead.org>
References: <20210715033704.692967-36-willy@infradead.org>
 <20210715033704.692967-1-willy@infradead.org>
 <1809568.1628626012@warthog.procyon.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1809568.1628626012@warthog.procyon.org.uk>
Precedence: bulk

On Tue, Aug 10, 2021 at 09:06:52PM +0100, David Howells wrote:
> Matthew Wilcox (Oracle) <willy@infradead.org> wrote:
> 
> > By using the node id in mem_cgroup_update_tree(), we can delete
> > soft_limit_tree_from_page() and mem_cgroup_page_nodeinfo().  Saves 42
> > bytes of kernel text on my config.
> > 
> > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> > Acked-by: Michal Hocko <mhocko@suse.com>
> > Acked-by: Johannes Weiner <hannes@cmpxchg.org>
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
> 
> Reviewed-by: David Howells <dhowells@redhat.com>
> 
> Though I wonder if:
> 
> > -		mz = mem_cgroup_page_nodeinfo(memcg, page);
> > +		mz = memcg->nodeinfo[nid];
> 
> should still have some sort of wrapper function.

I was asked to remove the wrapper function as it didn't provide enough
utility to warrant the indirection.