Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210813151734.1236324-1-jim.cromie@gmail.com>
 <20210813151734.1236324-4-jim.cromie@gmail.com> <YRaU6fbGjcV7BGC/@smile.fi.intel.com>
 <CAJfuBxzkWuK-Xh-2gynmLeHx+gb6bwhbKTG02pydYvQzNBiPjA@mail.gmail.com>
In-Reply-To: <CAJfuBxzkWuK-Xh-2gynmLeHx+gb6bwhbKTG02pydYvQzNBiPjA@mail.gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Fri, 13 Aug 2021 22:33:04 +0300
Message-ID: <CAHp75Vf5ZGg77OSXSbL8b03g41AKUUtaXwcEEqFXtSvV2aubmQ@mail.gmail.com>
Subject: Re: [PATCH v5 3/9] dyndbg: add DEFINE_DYNAMIC_DEBUG_CATEGORIES and callbacks
To:     Jim Cromie <jim.cromie@gmail.com>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Aug 13, 2021 at 8:54 PM <jim.cromie@gmail.com> wrote:
> > > There is still plenty of bikeshedding to do.
> >
> > > ---
> > > v4+:
> > >
> > > . rename to DEFINE_DYNAMIC_DEBUG_CATEGORIES from DEFINE_DYNDBG_BITMAP
> > > . in query, replace hardcoded "i915" w kp->mod->name
> > > . static inline the stubs
> > > . const *str in structs, const array. -Emil
> > > . dyndbg: add do-nothing DEFINE_DYNAMIC_DEBUG_CATEGORIES if !DD_CORE
> > > . call MOD_PARM_DESC(name, "$desc") for users
> > > . simplify callback, remove bit-change detection
> > > . config errs reported by <lkp@intel.com>
> > >
> > > ddh-helpers
> >
> > > Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
> >
> > So, it is signed or not? I didn't get (perhaps due to misplaced changlog?).
> >
>
> It might be my --- snip, and reliance on format-patch -s
>
> would it work if I used --  2char snip ?

The right thing to do is to have

SoB ...
'--- ' line
Changelog is _here_


-- 
With Best Regards,
Andy Shevchenko