Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 14 Aug 2021 02:30:03 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Vlastimil Babka <vbabka@suse.cz>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
        Michal Hocko <mhocko@kernel.org>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH v14 040/138] mm/memcg: Convert mem_cgroup_charge() to
 take a folio
Message-ID: <YRccm0lwTkzlxqCX@casper.infradead.org>
References: <20210715033704.692967-1-willy@infradead.org>
 <20210715033704.692967-41-willy@infradead.org>
 <40a868bf-61dc-1832-4799-ff85018ebcec@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <40a868bf-61dc-1832-4799-ff85018ebcec@suse.cz>
Precedence: bulk

On Wed, Aug 11, 2021 at 12:54:05PM +0200, Vlastimil Babka wrote:
> > -static int __mem_cgroup_charge(struct page *page, struct mem_cgroup *memcg,
> > +static int __mem_cgroup_charge(struct folio *folio, struct mem_cgroup *memcg,
> >  			       gfp_t gfp)
> 
> The git/next version also renames this function to charge_memcg(), why? The new
> name doesn't look that internal as the old one. I don't have a strong opinion
> but CCing memcg maintainers who might.

Ah, this is Suren's fault :-)

https://lore.kernel.org/linux-mm/20210710003626.3549282-2-surenb@google.com/

Renaming it here makes the merge resolution cleaner.