Received: by 2002:a05:6a10:8a4d:0:0:0:0 with SMTP id dn13csp1260795pxb; Fri, 13 Aug 2021 18:48:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8oFUwPrV2XCRJrOxecH31XttvfcZfivXF4j+wXevhR3lHMDJU4IRX0HkzMBRJwOG4i/VI X-Received: by 2002:a05:6e02:ed1:: with SMTP id i17mr3753240ilk.272.1628905736483; Fri, 13 Aug 2021 18:48:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628905736; cv=none; d=google.com; s=arc-20160816; b=iPheJXcRQcIlpn/jOPd2m1gVQuL8m+ArGlXB4HL3Ng6RW2+FRLxjlPM5B5HrBH7lPl owyG1147jwgLUawbMoQNKGirLbRAfcmgzcgDKZfgNTwQnOGEBc/Db3JnTlpuAAmnTRFi kMe+HVvJ5pWEym5hjLnxzj5UWJSBnQnh/EVJwpMFKYVY7eUublPyCeTop+rVY6nt2X09 GQ7c9m0giQ/xt1IWYRqtcOk+Zhmfm1jWKVQFMsyQcdv0Zw566ntPVFdiUearDdih9u7A 0dPg2u0ZVOe6XVi9QJwda4vpe+xJq24RWDSwdWaq7wJB93oKDbv1X62DSkc6mcqrJO45 Ka+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=YBCG6DUzabhViDkKsHcNn5rCLhJqBUXGkKq7mmvd4r4=; b=QEDiAgel1VhHN3watr0r8dgeoHJ395kmatLpdnBp3npW8qvQ6d/qR2ZABNRxLonbDJ YVBNM5f72/Lhp0DaD0MeotKqgNdUXpKrca+6CpGVGJ/A527XxPTdScQy3guW/M+ePrIV YKahgri5a6a3XLIUmG67t2LcT5GJ43Du2UdoOkJWlzT5fVbrXw5Ejj6cya7uXq1YVwdU gs6GOm5AejGL3URiMQm7Dr4OwuymjINhrS1hL/bsSzdU00ZhGDGRfufe+0/uxjGVfvZR imGmguwCHrqmXUr7H6Pu7ptak8KEhP5g8S3KXYsVmf8NUJPMdZGYN+CF3GovbPyb+jLR /TcQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n16si3128641jap.23.2021.08.13.18.48.44; Fri, 13 Aug 2021 18:48:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236420AbhHNBpr (ORCPT + 99 others); Fri, 13 Aug 2021 21:45:47 -0400 Received: from netrider.rowland.org ([192.131.102.5]:34635 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S236320AbhHNBpr (ORCPT ); Fri, 13 Aug 2021 21:45:47 -0400 Received: (qmail 56475 invoked by uid 1000); 13 Aug 2021 21:45:18 -0400 Date: Fri, 13 Aug 2021 21:45:18 -0400 From: Alan Stern To: Maxim Devaev Cc: balbi@kernel.org, gregkh@linuxfoundation.org, ruslan.bilovol@gmail.com, mika.westerberg@linux.intel.com, maze@google.com, jj251510319013@gmail.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: gadget: f_hid: optional SETUP/SET_REPORT mode Message-ID: <20210814014518.GA56183@rowland.harvard.edu> References: <20210813114551.72898-1-mdevaev@gmail.com> <20210813145823.GA38198@rowland.harvard.edu> <20210813232212.5cba6d33@reki> <20210813234022.5d5644ae@reki> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210813234022.5d5644ae@reki> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 13, 2021 at 11:40:22PM +0300, Maxim Devaev wrote: > В Fri, 13 Aug 2021 23:22:12 +0300 > Maxim Devaev пишет: > > > Alan Stern wrote: > > > In other words, a device does not need to have an interrupt-OUT > > > endpoint, but if it does have one then the host must use it. > > > > You're right. Although the actual behavior of the hosts is not different > > from what I wrote - they really just ignore out endpoint. > > I will eventually fix this in the patch description. > > It seems that I have confused everything even more, sorry. I will explain. > There are three possible host behaviors: > > (1) The host works with the OUT endpoint as it describes the standard > and transmits reports through it. > > (2) The host works with IN endpoint, but refuses to transmit reports > via OUT endpoint at all. In the case of the keyboard, it will work, > but it will not receive the status of the LEDs. > > (3) The host sees OUT endpoint and either refuses to use such a device at all, > or goes crazy in various ways. > > In both cases (2) and (3), using SETUP/SET_REPORT solves the problem. > Therefore, I offer this as an option to solve compatibility problems. > Yes, in fact, this is not our problem, but it is impossible to fix the drivers > of all these proprietary devices. Moreover, I have never met a keyboard > with OUT endpoint, absolutely all of them use SETUP/SET_REPORT. Okay. I appreciate the more detailed explanations; thanks. Please resubmit the patch with appropriate changes to the description. Alan Stern