Received: by 2002:a05:6a10:8a4d:0:0:0:0 with SMTP id dn13csp1298979pxb; Fri, 13 Aug 2021 20:14:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxKDOaehITbNy/gb+B7oljtr423MVHXrXuAoQICrWvfVSdiUeNxgJM7cptv71LhwgqP7xp2 X-Received: by 2002:a05:6e02:1b0e:: with SMTP id i14mr3678518ilv.69.1628910848124; Fri, 13 Aug 2021 20:14:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628910848; cv=none; d=google.com; s=arc-20160816; b=KYlc2zvcAGmliDf7/B/fL1lXoZiQWdpXWXTmFCL8OF01hH4Q824WbN9ddEZO0qy9mv wHv6gf01klQ4a4U1mI8ITT2adgWkCk0NJFVJeL4q1Pz7UUABX9O/S5+bOOjvYiSf1t4K Zubw3KOnHv3qfn8ISDZZcXKLNkGfm2b3Y+Es9DVRewB7P/xv2Z5k/NsL2cVR25h3trRU U+u52/AUVR0p+lGnWLEGVqAcCLEHodZ02NCg2FzFZFndpu0fhHKTy4VtzR5NzcSkLo3O yf+mHA7jnzlkp+MOWchGBYkZ1yo1DwplDI1wSyy+fKAA/q+CAHFzlkO48GO7n6/c/EYp z6hA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=kfw00GVSdXBrainH+8NLVWPIBE8UHBhusGRtecxsNW8=; b=xMjHflg7yQ9PUKt1HrHKZl+RfdlD6mcwiLm9Xc+jIuXNqRzMtD4s/r0axkc1OKHeEP 6Z25lgXux8IWKbZv3VnDq/yorz0n7R0yQD8go0DvR1e8BxALxU2fDcUJp8VGIEcjub47 4869GFGD3wfTeESmqaNlXVkWW97Oc/8/Pwm/ADDLX9ahCp2dNSJ7Q6YqGV0N62WMRSPG lnJ2HSaxyqb3uMFuyRxtp2cQErtF3bAREc+NmlQDa9/2rzhYiCTOQ+Q0Jk4nyrMMMI7W TxuyvW8K+r9Equc1inXSKpW1hq8FjhsYX2GwSKATQ9LLA52IZoctc8lOTU2rjdnKHEMe FW8w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 14si3353650ilt.110.2021.08.13.20.13.48; Fri, 13 Aug 2021 20:14:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236717AbhHNDMZ (ORCPT + 99 others); Fri, 13 Aug 2021 23:12:25 -0400 Received: from mail-pj1-f47.google.com ([209.85.216.47]:33677 "EHLO mail-pj1-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236466AbhHNDLf (ORCPT ); Fri, 13 Aug 2021 23:11:35 -0400 Received: by mail-pj1-f47.google.com with SMTP id 28-20020a17090a031cb0290178dcd8a4d1so12667844pje.0; Fri, 13 Aug 2021 20:11:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kfw00GVSdXBrainH+8NLVWPIBE8UHBhusGRtecxsNW8=; b=NOpX+F2TSnAQm01Um3rEsledzVFOSlooPSpBAsuf1S9QGbKjNFGU/H5LbiffqseD5y k2OzkmDdlbQWYRTonCOWLHLY7FGpZ1Jhhpy/fkwnOa8t/hrBSx12IzlePxXPCVsLnHKO Gnn7Ym0VgcpF3xfqBaEudfWOvvNf1f36rgqbdyIC1K5dIxqdqGlbvEpS/j/SW/PugU1/ VC10fk2U2GvsL/AvFWL9D3/gJnu96eXLWTfMEpt6HugX/Xl4ZC3BobR+IpTl1GYKmzAt LaP1wF5zfZwi+C9KMh4ydUPWYjB6bPEBWKxlcvj5ws+SgPL5IQBe1cVjJwP6MhFD9W9l o/Aw== X-Gm-Message-State: AOAM531x0TbXg++RJdKbJtz8u3J2nI9M0s+5lhhDeCPtcqUKAFUGAL37 YaAo6qjmaJWHA7dNKYM9lUU= X-Received: by 2002:a65:40c4:: with SMTP id u4mr5122562pgp.186.1628910667212; Fri, 13 Aug 2021 20:11:07 -0700 (PDT) Received: from ?IPv6:2601:647:4000:d7:55d6:7aa0:a6ad:d964? ([2601:647:4000:d7:55d6:7aa0:a6ad:d964]) by smtp.gmail.com with ESMTPSA id w2sm3023744pjq.5.2021.08.13.20.11.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Aug 2021 20:11:06 -0700 (PDT) Subject: Re: [PATCH 1/3] scsi: wd719: Stop using scsi_cmnd.tag To: John Garry , satishkh@cisco.com, sebaddel@cisco.com, kartilak@cisco.com, jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, hare@suse.de, hch@lst.de References: <1628862553-179450-1-git-send-email-john.garry@huawei.com> <1628862553-179450-2-git-send-email-john.garry@huawei.com> From: Bart Van Assche Message-ID: <2fdb9ef3-fb2d-e8bc-4489-cb0c332398ae@acm.org> Date: Fri, 13 Aug 2021 20:11:04 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <1628862553-179450-2-git-send-email-john.garry@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/13/21 6:49 AM, John Garry wrote: > - action = /*cmd->tag ? WD719X_CMD_ABORT_TAG : */WD719X_CMD_ABORT; > + action = /*tag ? WD719X_CMD_ABORT_TAG : */WD719X_CMD_ABORT; If this patch series would be reposted, please remove the commented-out code instead of modifying it. Anyway: Reviewed-by: Bart Van Assche