Received: by 2002:a05:6a10:c7d3:0:0:0:0 with SMTP id h19csp185154pxy; Sat, 14 Aug 2021 04:16:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx9IX+GYGbLzqP0NY5wxRZKsM1kbAlYRQya0cZc3xZ7q3qbLEiE/Zp7+Id1ExXAQ/dWzeey X-Received: by 2002:a50:d548:: with SMTP id f8mr8807662edj.357.1628939819028; Sat, 14 Aug 2021 04:16:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628939819; cv=none; d=google.com; s=arc-20160816; b=L55eZOGlu30AU3PaDc+aLIZFSCrtWVezCtUFtaVjRh2ogLEtQ0wh0ykundzPw+Nfj6 Igtj1aWuLL1pZT300lVL30r2psLGvqzpBE36OHzUq7xyF5vEqW4fGHzGHodG/ZwB6yW2 lzOEHn4Fvf/wEtcS4sKvBoL54+9Y6u32D0xrowhnyeuQLHD4zp8TK4C7/0vhEmecR8Pc F2so02YNiH8Yq91GKRHW+glclbZ1zwPcOD/fZxTwKXt9ONuDHJFdVNGiqr0ZJqSCG9wk VK1xwdpblxiQdzCc+LtcL1W2Rweg+yja0JO7hmaIc2Ou/Ah92RO+9+KRUM3Xg4ZW11DU xbow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=zyLTEao8GoUQ5VMv7Ikv+o0Q4wNAX8MPGnCruQejids=; b=AfFlce1Ytx6G5QS8mwiA4vS9cg0uYw7KK3pDdLjdagyb5jOs0edF3lLYAqv9YiR377 hXp5jc1+AMjBinJ8dOC5kUlHQjANk/ZEZyk9h5UP54BOgPI6XJvnSx17ds70P+fmclZX AEdVaGbZX8ltdDhPusStqsoyNTm7ca5OsKLIND1wNrXaDbGMDtdY3aoq2WpbfBTS/s0g khPcuvTefHwMjRIrNmau+wrSr9cncEU3xmWGKsMlAJCdaum7xqRdyZY9ZTAtYsfzORB0 lxjwUlqXXVk24Sk2DFWof6lwvLAX9qPjvAbZ+rV5r7gPY7Oep/2/AjoI1NJA3VGcnYCr SvKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=AimOhyrI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l21si5086933edw.175.2021.08.14.04.16.36; Sat, 14 Aug 2021 04:16:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=AimOhyrI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238213AbhHNLPr (ORCPT + 99 others); Sat, 14 Aug 2021 07:15:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232881AbhHNLPl (ORCPT ); Sat, 14 Aug 2021 07:15:41 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC28AC061764; Sat, 14 Aug 2021 04:15:12 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id w5so23068586ejq.2; Sat, 14 Aug 2021 04:15:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zyLTEao8GoUQ5VMv7Ikv+o0Q4wNAX8MPGnCruQejids=; b=AimOhyrIEK/nBoXMt6oUsKR6TdfYbL1w+oLAQ+jdX5/0xs4DL8U5rvqs7CgmWDMLKW wvslvSIcz+Ym28vRU9/sxDlIGZnsFtfalf14+xGPpg2njX50jPOotSHh1pl6wZBBvOVT CNr08GTjhd2hRTXwHHO+418Hla+qX40pN79lNlVo3wZTW+y/n1mj9nReuSY/H2hDIU0q 9yXwDE6ZQNWy+h8B0O2kfBtDbOdmUXhtx5BBZpFto/fjTOnZMESji10aTB24M2gbQuek XIqi/Egqqa93uwOFKIt4J+ZeQBlj0IEgapFheLqmIM5sWVDK0b4ByN2U5lKf37P/kPlT cJ0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zyLTEao8GoUQ5VMv7Ikv+o0Q4wNAX8MPGnCruQejids=; b=YpL3JFoyBJ3ofXXCtfxTEDWIfgPpoWRRjhppnV9Oqctih8Ne7+RK9cJ0HEyHajso+I kVBN+sbr5JOxo/jQrAZZsu9OWLnSbC8x3EZmgkwAlAGlE6qXzhXzhRs5CV/Xx45981nX hir1LFtvBh9gw7mQyT8XJtj1ctrIsLcmd+Vc0ysRBWaNSJ6iNtnXq0eJO1HtXZKXv+VQ Zn5tPyE7riCDUtqw9HR2txDuVXTdxaC8EymLq/g4rZTPWhs2uPasoBUiSrcXHIoUBuPl +hAf+Mw8fIRJrosFUDDWdjT31QFJ6lYLKkD6+BvIkOxFZIHlDLWh+E5ErzoP6LCLu2Ju MUJw== X-Gm-Message-State: AOAM533cPws70Lqr+/wN2ap1Uje+OMP3b94wmzpnUra99TYZwHZ4dWIn SgqNBexD5j8bX3mVlsgZZMs= X-Received: by 2002:a17:907:104f:: with SMTP id oy15mr7085148ejb.46.1628939711482; Sat, 14 Aug 2021 04:15:11 -0700 (PDT) Received: from skbuf ([188.25.144.60]) by smtp.gmail.com with ESMTPSA id n15sm2110779edw.70.2021.08.14.04.15.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Aug 2021 04:15:11 -0700 (PDT) Date: Sat, 14 Aug 2021 14:15:09 +0300 From: Vladimir Oltean To: Colin Foster Cc: andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org, claudiu.manoil@nxp.com, alexandre.belloni@bootlin.com, UNGLinuxDriver@microchip.com, hkallweit1@gmail.com, linux@armlinux.org.uk, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v3 net-next 06/10] net: mscc: ocelot: split register definitions to a separate file Message-ID: <20210814111509.p2ypda3yj5em5ro4@skbuf> References: <20210814025003.2449143-1-colin.foster@in-advantage.com> <20210814025003.2449143-7-colin.foster@in-advantage.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210814025003.2449143-7-colin.foster@in-advantage.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 13, 2021 at 07:49:59PM -0700, Colin Foster wrote: > Moving these to a separate file will allow them to be shared to other > drivers. > > Signed-off-by: Colin Foster > --- What about the VCAP bit fields?