Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 14 Aug 2021 17:51:25 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     David Howells <dhowells@redhat.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v14 052/138] mm: Add folio_raw_mapping()
Message-ID: <YRf0jTttJIjMcnkp@casper.infradead.org>
References: <20210715033704.692967-53-willy@infradead.org>
 <20210715033704.692967-1-willy@infradead.org>
 <1811270.1628628133@warthog.procyon.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1811270.1628628133@warthog.procyon.org.uk>
Precedence: bulk

On Tue, Aug 10, 2021 at 09:42:13PM +0100, David Howells wrote:
> Matthew Wilcox (Oracle) <willy@infradead.org> wrote:
> 
> > Convert __page_rmapping to folio_raw_mapping and move it to mm/internal.h.
> > It's only a couple of instructions (load and mask), so it's definitely
> > going to be cheaper to inline it than call it.  Leave page_rmapping
> > out of line.
> > 
> > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> 
> I assume you're going to call it from another source file at some point,
> otherwise this is unnecessary.

Yes, it gets called from mm/ksm.c in a later patch in this series.
__page_rmapping() assumes it's being passed a head page and
folio_raw_mapping() asserts that.  Eventually, page_rmapping() can
go away (and maybe it should have been moved to folio-compat.c),
but I'm not inclined to do that now.

> Apart from that,
> 
> Reviewed-by: David Howells <dhowells@redhat.com>
>