Received: by 2002:a05:6a10:c7d3:0:0:0:0 with SMTP id h19csp474558pxy; Sat, 14 Aug 2021 12:53:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw0iwG4fmw2XIozW41sqr0QVHuYV8ChNFwFGBoBMUDLooVZwYmTiRBoFrroX8Bu0Xplfio7 X-Received: by 2002:a05:6e02:1546:: with SMTP id j6mr6024568ilu.154.1628970805964; Sat, 14 Aug 2021 12:53:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628970805; cv=none; d=google.com; s=arc-20160816; b=Dg//zFLYb5SUygwjNkAA2/HwJQZn49XzEgxs81rh+QVmQUUi25hylwj4EB1ue94r7n oQ1fI4QgflTQWjrkRRoqNOcNsNWFA20UdzuXRgKfJLR+p6nbMPs4iw0k0GNWSFsk0EPP dNHDu5A3qK5L+SHwvaM2J9C+5byIIsAJ2l33F8NhXOMhZP59P2piLPGmehVcQ+rX1fGn Qf0g2Z6u8wsrwyilcJwDMdRE34X8h7b1AuVXAgiiW0erDDjg0fHA0LH0xgoUiOqr8ILw L6wVFxeaJEvv9lFe3al3oU2TgZnav1zSCj5neyaz8BCgzpFSsQ0OAZpzmyBv20BaiDre atAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=MxxGG+b1/SO8O7pZQFU6nsAVt6WPk1hghVx+kIHzs1U=; b=iqK5YY81FdcKGslIFdyyO5eWb6uGzmYwZH70sWeCf1lz/Pz8hj4xZSfbqS3Ir6fhtn tp7p4Xf1THrGCJpC/t2z3ibB4pPt9ditIQKeJgKkqKoATs3cZzMHjsP3D+Yy/lN5Xd7J kTcnwX30Ya7o7hpmSy3Vx/5Tz7heYOVORiJuLo/7eg2cKkHpVN+LleIj8PS02yODvLJM jTwo7CehL+msJ/4pBbFFdDUq1Fnx+9YpfPOLq1v4ooYXdzKSBXtOM0VcyJjlOxUMO1Ho DCGM+LKIc2v4wDAsxUXsnOQOMChcyyjJXTrjWCJwNaQxrorX0SUnS5sFW2B4LSZS1avc bjtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ce4Hm7th; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w5si6496321ilu.14.2021.08.14.12.53.14; Sat, 14 Aug 2021 12:53:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ce4Hm7th; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230029AbhHNTwX (ORCPT + 99 others); Sat, 14 Aug 2021 15:52:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229532AbhHNTwW (ORCPT ); Sat, 14 Aug 2021 15:52:22 -0400 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4A98C061764; Sat, 14 Aug 2021 12:51:53 -0700 (PDT) Received: by mail-pl1-x634.google.com with SMTP id d1so16210125pll.1; Sat, 14 Aug 2021 12:51:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MxxGG+b1/SO8O7pZQFU6nsAVt6WPk1hghVx+kIHzs1U=; b=ce4Hm7thxTM0nRMTHfVtf7tM3GYn+4Kc3WuDFAzeUQ+kuQzj+aokoG92fDE9WfMJ8R 9DDZGwmCb3o1iWicjVTFKKjr64stYimATPF8dT2Q1BAFQLmVZ7DnZVGyH7ZYE9tYf+zx gDdb/hCYQqbFwx64yHLefc/l9oKhyiFDC+mU/6LhumT2SsMZsZH8vStKRqcRn0xsWxE6 knXkZ9ZKjzGRkmGf+otJglsgitOsUJo84edaFIuMkv5bk5EFKANxYqvFK7D2XrLsnyBj oqykMyQT5IcyyS8SnJjwmsrCmEEn4HkSj8amL09pMDDmEhYch3tkA9K7xS/Dfr8FqXgk 12LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MxxGG+b1/SO8O7pZQFU6nsAVt6WPk1hghVx+kIHzs1U=; b=N00TYuBJEXxjZkzoIKuIoHJo8HZQSExPhoiFhlHQUBZxYMDGJbwHBlcvVFrGp7YLtP dC1QEp0pdLWZHNGiqzO+AZI5D1gMfdjRvi2huRxUBFxhYKhwTeaDdroCuXQwI1m1RZLI 4TUuILQ2l1PZysg3rtiA15YIsFdT7numiAIayppsS74O99fVRa54qsaLguiluu+tR8Rb voVEuruitMMOQ6KrbqafAGNvhJFwisX7T77WCB/2PkSH8o5vLopxoQ5q8ueA4kLtWeC9 nrooYcrFtR6UQq5uQj/JghP4vAIB+z9WyOCg2snPEfHnekyNfXrvQXTwNvVpd+N+wYdu v1Lw== X-Gm-Message-State: AOAM531EqMVsUGRlD+VKJY5rE+vgbGo4IHeNtm1c+nTLS9d48u/84F7c wP/AkLrsH0HM6nF5rnpbKpyH2FAk+IvZ7NIdneg= X-Received: by 2002:aa7:800b:0:b029:330:455f:57a8 with SMTP id j11-20020aa7800b0000b0290330455f57a8mr8355749pfi.7.1628970713254; Sat, 14 Aug 2021 12:51:53 -0700 (PDT) MIME-Version: 1.0 References: <20210814043103.2535842-1-luke@ljones.dev> <20210814043103.2535842-2-luke@ljones.dev> In-Reply-To: From: Andy Shevchenko Date: Sat, 14 Aug 2021 22:51:17 +0300 Message-ID: Subject: Re: [PATCH v3 1/1] asus-wmi: Add support for platform_profile To: Luke Jones Cc: Linux Kernel Mailing List , Hans de Goede , Bastien Nocera , Platform Driver Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 14, 2021 at 3:47 PM Luke Jones wrote: > A very quick question: should I be enabling platform_profile by default > if asus_wmi is enabled in kconfig? Very quick for you, but me. I dunno. I think the best thing is what Hans can tell here. Nevertheless, I think that this kind of default should be applied to all modules (yes, I know there might be possible exceptions). -- With Best Regards, Andy Shevchenko