Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 15 Aug 2021 09:28:57 +0300
From:   Mike Rapoport <rppt@kernel.org>
To:     Matthew Wilcox <willy@infradead.org>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v14 050/138] mm/workingset: Convert workingset_activation
 to take a folio
Message-ID: <YRi0Ke2UX9eMqEKx@kernel.org>
References: <20210715033704.692967-1-willy@infradead.org>
 <20210715033704.692967-51-willy@infradead.org>
 <YPfuPTtlhGXBjhCL@kernel.org>
 <YRdBGCATQHPXrmTD@casper.infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YRdBGCATQHPXrmTD@casper.infradead.org>
Precedence: bulk

On Sat, Aug 14, 2021 at 05:05:44AM +0100, Matthew Wilcox wrote:
> On Wed, Jul 21, 2021 at 12:51:57PM +0300, Mike Rapoport wrote:
> > >  /*
> > > - * page_memcg_rcu - locklessly get the memory cgroup associated with a page
> > > - * @page: a pointer to the page struct
> > > + * folio_memcg_rcu - Locklessly get the memory cgroup associated with a folio.
> > > + * @folio: Pointer to the folio.
> > >   *
> > > - * Returns a pointer to the memory cgroup associated with the page,
> > > - * or NULL. This function assumes that the page is known to have a
> > > + * Returns a pointer to the memory cgroup associated with the folio,
> > > + * or NULL. This function assumes that the folio is known to have a
> > >   * proper memory cgroup pointer. It's not safe to call this function
> > > - * against some type of pages, e.g. slab pages or ex-slab pages.
> > > + * against some type of folios, e.g. slab folios or ex-slab folios.
> > 
> > Maybe
> > 
> > - * Returns a pointer to the memory cgroup associated with the page,
> > - * or NULL. This function assumes that the page is known to have a
> > + * This function assumes that the folio is known to have a
> >   * proper memory cgroup pointer. It's not safe to call this function
> > - * against some type of pages, e.g. slab pages or ex-slab pages.
> > + * against some type of folios, e.g. slab folios or ex-slab folios.
> > + *
> > + * Return: a pointer to the memory cgroup associated with the folio,
> > + * or NULL.
> 
> I substantially included this change a few days ago and forgot to reply
> to this email; sorry.  It now reads:
> 
> /**
>  * folio_memcg_rcu - Locklessly get the memory cgroup associated with a folio.
>  * @folio: Pointer to the folio.
>  *
>  * This function assumes that the folio is known to have a
>  * proper memory cgroup pointer. It's not safe to call this function
>  * against some type of folios, e.g. slab folios or ex-slab folios.
>  *
>  * Return: A pointer to the memory cgroup associated with the folio,
>  * or NULL.
>  */

I like it.

-- 
Sincerely yours,
Mike.