Received: by 2002:a05:6a10:c7d3:0:0:0:0 with SMTP id h19csp800214pxy; Sun, 15 Aug 2021 00:32:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyWj8FfXxb6VKxlf99udtXSB3KDwPLzDIeHLzeg1Zydno5lycVOAtsf5ne8uc7Q6m8fQL9i X-Received: by 2002:a92:d304:: with SMTP id x4mr7741076ila.82.1629012768789; Sun, 15 Aug 2021 00:32:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629012768; cv=none; d=google.com; s=arc-20160816; b=PHwdsUhIDbVdzo+pQZJHduNWM1VFVUgkvGNc3SUhiNoRf5kDYMYM67WRsaOV/r/Zsg 09/3VcLIkaVGCf0Bi4IFrZqfLGUANgExVxgXGG2xarATf3CIoIbAi7+/r3ZLH+j7cp/m GzU0nBVglebX11WHj+LI3G9NzgMqHwQ2J4gNKnEXDMjxXzoB2c3AItT61l3MVVB1BZCW Cz/tJMzNGqQJBok28jMEy80pzg30GPMgP6U7vRZLfElug3wfKhUzxy+fDZGHNywc9UHL +C5CrVAIx7LSitozkd26mH8gqsQEbCin4zqbQFrrmH91spRODd8yU2aqbYF6pOb2eoNA oCww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:in-reply-to :subject:cc:to:from:message-id:date:dkim-signature:dkim-signature; bh=fQu1Y0kxtEnpxUwvGLssrYAMhEy0FrOA3iD90t/w9Zk=; b=jxWL8w4so8QIQS1niOtCE1i5ACjC4KWnKoc9idvKqrQHoyFazC0efQLb5DyigUuldB 2wK5zWSbz5aZSytyt6G+e6C+CgDxfOc/xD/3kSJict5/tBtuy9WHbUdef/+drNgxceH/ Oeo55ZLpnOvsKNR2MtqOrtkap7b8Hgk5sUm7F03ZOOB/Opzt1uvyCzR8dqZ8ct51iPKb 7LnmDQXw/kcGDw4X7AZzoQYq8QpPEWFOTzh1GUon0vfiILlP65b6ZPQSI4nfCChM1vlH 6/ffOOS8KHEtcRSnY2/sUHK2EBqkIk5cIYWMa62spvp52d5vsdqaGwcZBt1TdJQeQH1p i5cQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=yN9qjr74; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i13si8764685ilm.90.2021.08.15.00.32.37; Sun, 15 Aug 2021 00:32:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=yN9qjr74; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236546AbhHOHbU (ORCPT + 99 others); Sun, 15 Aug 2021 03:31:20 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:38298 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236146AbhHOHbU (ORCPT ); Sun, 15 Aug 2021 03:31:20 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id D443821FA2; Sun, 15 Aug 2021 07:30:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1629012649; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fQu1Y0kxtEnpxUwvGLssrYAMhEy0FrOA3iD90t/w9Zk=; b=yN9qjr74IDs+wJ+QSTHaPbRVzlfR130BViKyGd6DNF9Sa29nJbtom/EV2M9Rmim1dVD1/a giTOKoZEJwMvhXvopk9Iy+Hecv7C0nIbI/Qo32G1i8hmqaqlpGZ5F1RT/TtZjmaap/0dPm 9yNsPTEYxEEEvUYBR4fIYlYQeim8CzA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1629012649; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fQu1Y0kxtEnpxUwvGLssrYAMhEy0FrOA3iD90t/w9Zk=; b=VB0Z+o90fU42qneGrVb0LKXG+fWNgB7XwLSsvGbw1a90qAx1XZSDt7ST2FCq7nfvZKGB0x 41MsLULR9FttM/Aw== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id B2F5FA3B83; Sun, 15 Aug 2021 07:30:49 +0000 (UTC) Date: Sun, 15 Aug 2021 09:30:49 +0200 Message-ID: From: Takashi Iwai To: Kristin Paget Cc: Takashi Iwai , alsa-devel@alsa-project.org, Jaroslav Kysela , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: hda/realtek: Enable 4-speaker output for Dell XPS 15 9510 laptop In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 15 Aug 2021 00:46:05 +0200, Kristin Paget wrote: > > The 2021-model XPS 15 appears to use the same 4-speakers-on-ALC289 audio > setup as the Precision models, so requires the same quirk to enable woofer > output. Tested on my own 9510. > > Signed-off-by: Kristin Paget It seems that your MUA broken the patch (tabs converted to spaces). Since it's a trivial oneliner, I applied manually. But for the next time, please try to fix your MUA setup. Thanks! Takashi