Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 15 Aug 2021 11:53:59 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Vlastimil Babka <vbabka@suse.cz>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v14 072/138] mm/writeback: Add folio_account_cleaned()
Message-ID: <YRjyR/5DMyCChe6p@casper.infradead.org>
References: <20210715033704.692967-1-willy@infradead.org>
 <20210715033704.692967-73-willy@infradead.org>
 <ea89a40c-68b3-c54d-8e7f-3c09757ddd8d@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ea89a40c-68b3-c54d-8e7f-3c09757ddd8d@suse.cz>
Precedence: bulk

On Thu, Aug 12, 2021 at 06:14:22PM +0200, Vlastimil Babka wrote:
> On 7/15/21 5:35 AM, Matthew Wilcox (Oracle) wrote:
> > Get the statistics right; compound pages were being accounted as a
> > single page.  This didn't matter before now as no filesystem which
> > supported compound pages did writeback.  Also move the declaration
> > to filemap.h since this is part of the page cache.  Add a wrapper for
> 
> Seems to be pagemap.h :)

Ugh, right.  filemap.c.  pagemap.h.  obviously.

> > +		wb_stat_mod(wb, WB_RECLAIMABLE, -nr);
> > +		task_io_account_cancelled_write(folio_size(folio));
> 
> In "mm/writeback: Add __folio_mark_dirty()" you used nr*PAGE_SIZE. Consistency?

We don't have any ;-)  I'll change that.  Some places we use <<
PAGE_SHIFT, some places we use * PAGE_SIZE ... either are better than
calling folio_size() unnecessarily.