Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <7ad059482e56e88bfbe13830cfa06dffee9d071f.camel@gmx.de>
Subject: Re: [ANNOUNCE] v5.14-rc5-rt8
From:   Mike Galbraith <efault@gmx.de>
To:     Vlastimil Babka <vbabka@suse.cz>,
        Clark Williams <williams@redhat.com>
Cc:     Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>,
        RT <linux-rt-users@vger.kernel.org>
Date:   Sun, 15 Aug 2021 15:03:35 +0200
In-Reply-To: <c92fc2cb-03cd-d6a2-fb4a-7bc33e94e391@suse.cz>
References: <20210810163731.2qvfuhenolq2gdlv@linutronix.de>
         <20210812151803.52f84aaf@theseus.lan>
         <5f0c793d-5084-4607-8475-209fa7310ba2@suse.cz>
         <20210812162448.26274298@theseus.lan>
         <bb98b54c-6d88-2a56-4998-51a304c19e8c@suse.cz>
         <20210812164440.0426d8b7@theseus.lan>
         <96ceab8e-4bf9-147a-e931-848676003c3f@suse.cz>
         <5dbf6cf9e82ef15ce0febf070608da2d5b128763.camel@gmx.de>
         <c92fc2cb-03cd-d6a2-fb4a-7bc33e94e391@suse.cz>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.40.3 
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, 2021-08-15 at 11:35 +0200, Vlastimil Babka wrote:
> On 8/15/21 6:17 AM, Mike Galbraith wrote:
> > On Sat, 2021-08-14 at 21:08 +0200, Vlastimil Babka wrote:
> > >
> > > Aha! That's helpful. Hopefully it's just a small issue where we
> > > opportunistically test flags on a page that's protected by the local
> > > lock we didn't take yet, and I didn't realize there's the VM_BUG_ON
> > > which can trigger if our page went away (which we would have realize=
d
> > > after taking the lock).
> >
> > Speaking of optimistic peeking perhaps going badly, why is the below
> > not true?=C2=A0 There's protection against ->partial going disappearin=
g
> > during a preemption... but can't it just as easily appear, so where is
> > that protection?
>
> If it appears, it appears, we don't care, we just leave it there and
> won't use it.
>
> > If the other side of that window is safe, it could use a comment so
> > dummies reading this code don't end up asking mm folks why the heck
> > they don't just take the darn lock and be done with it instead of tap
> > dancing all around thething :)
>
> Well, with your patch, ->partial might appear just after the unlock, so
> does that really change anything?

Viewed from pov consumption is optional, it makes sense.

	-Mike