Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 15 Aug 2021 16:35:45 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Vlastimil Babka <vbabka@suse.cz>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v14 076/138] mm/writeback: Add
 folio_redirty_for_writepage()
Message-ID: <YRk0UazqhEi4xczM@casper.infradead.org>
References: <20210715033704.692967-1-willy@infradead.org>
 <20210715033704.692967-77-willy@infradead.org>
 <249863ea-8b4b-df38-545a-5f083502270d@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <249863ea-8b4b-df38-545a-5f083502270d@suse.cz>
Precedence: bulk

On Thu, Aug 12, 2021 at 06:30:51PM +0200, Vlastimil Babka wrote:
> > +/**
> > + * folio_redirty_for_writepage - Decline to write a dirty folio.
> > + * @wbc: The writeback control.
> > + * @folio: The folio.
> > + *
> > + * When a writepage implementation decides that it doesn't want to write
> > + * @folio for some reason, it should call this function, unlock @folio and
> > + * return 0.
> 
> s/0/false

... no?  This sentence describes what a writepage implementation should
do, and writepage returns an int, not bool.