Received: by 2002:a05:6a10:c7d3:0:0:0:0 with SMTP id h19csp1338077pxy; Sun, 15 Aug 2021 18:08:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxPbqy8CoPt4WZ/RpFnqK20emnvY1oc3Y/l2A+3T5vNLrXFRZlO0Ftgl1WfAahSRjHO6MUT X-Received: by 2002:a17:907:35d0:: with SMTP id ap16mr13535109ejc.456.1629076103447; Sun, 15 Aug 2021 18:08:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629076103; cv=none; d=google.com; s=arc-20160816; b=i+NM9ZGuNxylSgdPILKse+cfRqi31+0Mjd9nYYHEnvEssEKy0/5JQrWj/XR2jvjaec IKjVJLJY7fzKZnKZnZC4boExXT4ENf05s01MXkGV9kFWn7HkYAnXlHzeEbNdv7zsmMyJ exzfThlCtQNeKqpstUvNe6wdtVNrJtOHlUvqHwDO+xwoRE8TVmv/Rl5njww8fgqzsFsJ KY1ahd3hQ+4RWhm3LXWUn05tGy6YG/DFnZq9kMRY9MULC77wmm/i+r+N0GL+fQWERyUn J93NQK5hw6y7JEBnNx8RsvRY38DGKOnAsS71ktZjKiey0G00gYIbLH/Ju614+Fw7C4UC pGvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=HbfvwkokljU3OH/PzyLtJVDerFx7CfrHkMttzBcnp30=; b=oDuF7NSbkt+zlGhQkGItMwMdZuUADSfjylK4StoFWzx0D3X48LUlzThDpAHkvpY9yn IUxBq0Apa7SokAiUClNDAteNykCKHyJjNqozOC5MN8P2rpzauYlQs+nuF/joUVTPaWRD IwYGzjxr0xSuHXS0ldipPvnrevqB5M0MaIfS1Ri1UUzT1UHK0R3duETmXy34AsfTHG3L /rkKH9Czq9aCcvOrP9LIGvTJJFuTrgdrz7MORn/mu+ocQizdGiZZJr5KyfEfDXZyQuwU L7M6xt0tRmYK7AnJbkX9wRUgi6AuXG+IHyWJtTTKyCKlM+Npt96mp0pLUTPrbZ0k95Si caHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LJgPK+V4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q1si8941120ejn.480.2021.08.15.18.07.47; Sun, 15 Aug 2021 18:08:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LJgPK+V4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232077AbhHPBFM (ORCPT + 99 others); Sun, 15 Aug 2021 21:05:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:37312 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230124AbhHPBFL (ORCPT ); Sun, 15 Aug 2021 21:05:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629075880; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HbfvwkokljU3OH/PzyLtJVDerFx7CfrHkMttzBcnp30=; b=LJgPK+V4UlLe9K+z0E2k7HNPP3XQM86vu+QLx85WnsO344ZGrM9AL8oEOUQnli1hfNV7Ic UM1TAWqRyZB5F+DBtBEJPzLEyA7eIFSYnnc9+6ES/PFGbq3w4UQ/4qtP5gEHM0BT7ht0g1 iqPAkDmq+y3bY1lHRrd7DUtIBNgONvI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-142-T7wyzkvIN2yAlijX0tPMew-1; Sun, 15 Aug 2021 21:04:36 -0400 X-MC-Unique: T7wyzkvIN2yAlijX0tPMew-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4F56F108292D; Mon, 16 Aug 2021 01:04:35 +0000 (UTC) Received: from T590 (ovpn-8-17.pek2.redhat.com [10.72.8.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F184B5D9D3; Mon, 16 Aug 2021 01:04:26 +0000 (UTC) Date: Mon, 16 Aug 2021 09:04:21 +0800 From: Ming Lei To: kernel test robot Cc: Thomas Gleixner , Jens Axboe , clang-built-linux@googlegroups.com, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH 5/7] genirq/affinity: move group_cpus_evenly() into lib/ Message-ID: References: <20210814123532.229494-6-ming.lei@redhat.com> <202108150001.EBuNGcQ8-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202108150001.EBuNGcQ8-lkp@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Sun, Aug 15, 2021 at 01:01:07AM +0800, kernel test robot wrote: > Hi Ming, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on tip/irq/core] > [also build test WARNING on next-20210813] > [cannot apply to block/for-next linux/master linus/master v5.14-rc5] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Ming-Lei/genirq-affinity-abstract-new-API-from-managed-irq-affinity-spread/20210814-203741 > base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 04c2721d3530f0723b4c922a8fa9f26b202a20de > config: hexagon-randconfig-r041-20210814 (attached as .config) > compiler: clang version 12.0.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/0day-ci/linux/commit/759f72186bfdd5c3ba8b53ac0749cf7ba930012c > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Ming-Lei/genirq-affinity-abstract-new-API-from-managed-irq-affinity-spread/20210814-203741 > git checkout 759f72186bfdd5c3ba8b53ac0749cf7ba930012c > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=hexagon > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > > >> lib/group_cpus.c:344:17: warning: no previous prototype for function 'group_cpus_evenly' [-Wmissing-prototypes] > struct cpumask *group_cpus_evenly(unsigned int numgrps) > ^ > lib/group_cpus.c:344:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > struct cpumask *group_cpus_evenly(unsigned int numgrps) > ^ > static > 1 warning generated. > > > vim +/group_cpus_evenly +344 lib/group_cpus.c > > 328 > 329 /** > 330 * group_cpus_evenly - Group all CPUs evenly per NUMA/CPU locality > 331 * @numgrps: number of groups > 332 * > 333 * Return: cpumask array if successful, NULL otherwise. And each element > 334 * includes CPUs assigned to this group > 335 * > 336 * Try to put close CPUs from viewpoint of CPU and NUMA locality into > 337 * same group, and run two-stage grouping: > 338 * 1) allocate present CPUs on these groups evenly first > 339 * 2) allocate other possible CPUs on these groups evenly > 340 * > 341 * We guarantee in the resulted grouping that all CPUs are covered, and > 342 * no same CPU is assigned to different groups > 343 */ > > 344 struct cpumask *group_cpus_evenly(unsigned int numgrps) But the above symbol is exported via EXPORT_SYMBOL_GPL(), in current kernel tree, we usually keep such exported symbol as global, or is there some change in kernel coding style recently? Thanks, Ming