Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 16 Aug 2021 03:21:21 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     David Howells <dhowells@redhat.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v14 082/138] mm/lru: Convert __pagevec_lru_add_fn to take
 a folio
Message-ID: <YRnLoYRps6HXdTyD@casper.infradead.org>
References: <20210715033704.692967-83-willy@infradead.org>
 <20210715033704.692967-1-willy@infradead.org>
 <1814231.1628631867@warthog.procyon.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1814231.1628631867@warthog.procyon.org.uk>
Precedence: bulk

On Tue, Aug 10, 2021 at 10:44:27PM +0100, David Howells wrote:
> Matthew Wilcox (Oracle) <willy@infradead.org> wrote:
> 
> >  	 * looking at the same page) and the evictable page will be stranded
> >  	 * in an unevictable LRU.
> 
> Does that need converting to say 'folio'?

Changed the parapgraph (passed it through fmt too)

         * if '#1' does not observe setting of PG_lru by '#0' and
         * fails isolation, the explicit barrier will make sure that
         * folio_evictable check will put the folio on the correct
         * LRU. Without smp_mb(), folio_set_lru() can be reordered
         * after folio_test_mlocked() check and can make '#1' fail the
         * isolation of the folio whose mlocked bit is cleared (#0 is
         * also looking at the same folio) and the evictable folio will
         * be stranded on an unevictable LRU.

> Other than that:
> 
> Reviewed-by: David Howells <dhowells@redhat.com>
>