Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Song, Yoong Siang" <yoong.siang.song@intel.com>
To:     Andrew Lunn <andrew@lunn.ch>,
        "Russell King (Oracle)" <linux@armlinux.org.uk>
CC:     =?iso-8859-1?Q?Marek_Beh=FAn?= <kabel@kernel.org>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        "Jakub Kicinski" <kuba@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next 1/1] net: phy: marvell10g: Add WAKE_PHY support
 to WOL event
Thread-Topic: [PATCH net-next 1/1] net: phy: marvell10g: Add WAKE_PHY support
 to WOL event
Thread-Index: AQHXkCCVH1orffAF2Euk1FyXsMmop6tzQucAgAAKnYCAAhalcA==
Date:   Mon, 16 Aug 2021 03:19:34 +0000
Message-ID: <PH0PR11MB4950EAF1FC749EAAE3FDFCB7D8FD9@PH0PR11MB4950.namprd11.prod.outlook.com>
References: <20210813084536.182381-1-yoong.siang.song@intel.com>
 <20210814172656.GA22278@shell.armlinux.org.uk> <YRgFxzIB3v8wS4tF@lunn.ch>
In-Reply-To: <YRgFxzIB3v8wS4tF@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?Ufs9cviruIQKkpe26RJ8fGKbQM+hih/JOvdf8qQlI3Txvb08kqQ8BmY2Dn?=
 =?iso-8859-1?Q?232nlMd4w/eHo03kvZ1vfb0r3QdNDpPHXG5NoAQUUgrLrMEg2zg+tY2RAM?=
 =?iso-8859-1?Q?PH/SJccqbartCvgtwkiOe9bHEouf09d7qIip5mjgcU9j/37Z/uE2OIdzcy?=
 =?iso-8859-1?Q?ed8CyVeOY6AnvkaCeCGTj7XzOzrKlgwDyTNVAvXJ2BMPgb8iklfz6y54P7?=
 =?iso-8859-1?Q?9QG1jLd2Y7vjh6VCjfrEpWTisBtUOqLhOctRbAJ1aILXATPwnavhQcz2Oj?=
 =?iso-8859-1?Q?4pgzTVTAYGQSqJogA5PvPnNRcYmKeB5zoAhezrAQuzmE7lYLgtOp1CLD9E?=
 =?iso-8859-1?Q?m+lnrGhTdWLwkjPnuuuH3DfPPQiQJtdSXUJrv9cixl6JRTqvPYLLKx9Gqr?=
 =?iso-8859-1?Q?08fmJ776MZlzYY/ePOzLLgTLm4JCqUeWqs8REFztiFL1eRF6PNyl2xjyvx?=
 =?iso-8859-1?Q?SXEVGra+tIv2U55ANksevjGxLqCHe2G1E4vqzecwdVLlu+Qblawrp9kYnH?=
 =?iso-8859-1?Q?D+pYkLMCrktZ1wijPj3efRYTZsw4V8LyeyGsxeCyXXUbDHROLzolfATnc9?=
 =?iso-8859-1?Q?bqlUrdueKrT+19PPLMY6YvqDE2PA+XPfKIDrYMzZL7DVcaplXbsT7UHNkn?=
 =?iso-8859-1?Q?SIaBtyJqrKSPQkHcAtnz9z3XcVTPnQ36B0jBRiCUdlrRwmla1E/mtaBI+i?=
 =?iso-8859-1?Q?7Qdgo23mJpIELEj+rZ6vu6iVtWT5XjNBLpk6o2lxK8LJZ3kg6HYb4Qrd5X?=
 =?iso-8859-1?Q?AyAkNsYkWE5wFWVpyIhFDYvgC0KZoZFMfKJJR+pMwht5LVb2JDxN2hYVnI?=
 =?iso-8859-1?Q?YCinzYGCahCO2anY8SrWMCUA+OdRMFxaTyuxjY57Yr+HQUct41ECmA9LMH?=
 =?iso-8859-1?Q?pT5y/y+qeH/OeYKpzQFYQ0PKiMJse8kDPJSmzKu+wwc5B6NZ8jEQ0K0I2z?=
 =?iso-8859-1?Q?7+dl7oABpqBwDd0VJ8fgcey+T8r384u297p1Rc2G6qDd3oVKnPRBCrCy1Q?=
 =?iso-8859-1?Q?yKy6PWMmfA5psw0LJU6L0CJ4HxO/+uXOifbTvY0H9sNV7xyWFiBWEW64m2?=
 =?iso-8859-1?Q?LGPhg+oOgveY0ONe5x4YfbWqpYgIKE5p153YlhsyUOsbngScQBWyU/vdvL?=
 =?iso-8859-1?Q?tCBFNszL7MXsvlLxm2QC/89gNUsuK9rPo6lMMQNHQHMCzWiHoK39PBOOjq?=
 =?iso-8859-1?Q?slpEvbEE3+kayFKJ92PZecJJljMsrQsbf/h4gsg2jKfFjjCzs16erwJRaH?=
 =?iso-8859-1?Q?4SCGnDdRpDEHwCvXQnnHFXfreoOiA6S57BasnrPfjZGxTW4C9xA5mXUcbi?=
 =?iso-8859-1?Q?HYFvKt7IVq8V+HqZp6nYoBLu8nO089SMqaeJm8dU+bcCppVAIQ1+IinLoF?=
 =?iso-8859-1?Q?M/pAK57OsG?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4950.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5176b100-b42e-4b34-0045-08d96064abbf
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Aug 2021 03:19:34.3047
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GbEeRl7JgqScFBD+bXsYpydR7KNXtGSIOHZ/9cGj/i7xboy9dvjBnLLDRggG3PffjOeZwN0cqiuRgVutbjjV3cicUGKp1t0ycOhjZTbAglU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4790
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > How does this work if the driver has no interrupt support? What is the
> > hardware setup this has been tested with?
>=20
> Hi Russell
>=20
> We already know from previous patches that the Intel hardware is broken,
> and does not actually deliver the interrupt which caused the wake up. So =
i
> assume this just continues on with the same broken hardware, but they hav=
e
> a different PHY connected.

Hi Russell & Andrew,

This is tested on Intel Elkhart Lake (EHL) board. We are using polling mode=
.
Both WoL interrupt and link change interrupt are the same pin which is
routed to PMC. PMC will wake up the system when there is WoL event.

Regards
Siang

>=20
> > What if we later want to add interrupt support to this driver to
> > support detecting changes in link state - isn't using this bit in the
> > interrupt enable register going to confict with that?
>=20
> Agreed. If the interrupt register is being used, i think we need this pat=
chset to
> add proper interrupt support. Can you recommend a board they can buy off
> the shelf with the interrupt wired up? Or maybe Intel can find a hardware
> engineer to add a patch wire to link the interrupt output to a SoC pin th=
at can
> do interrupts.
>=20
> 	  Andrew