Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Song, Yoong Siang" <yoong.siang.song@intel.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     Russell King <linux@armlinux.org.uk>,
        =?iso-8859-1?Q?Marek_Beh=FAn?= <kabel@kernel.org>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next 1/1] net: phy: marvell10g: Add WAKE_PHY support
 to WOL event
Thread-Topic: [PATCH net-next 1/1] net: phy: marvell10g: Add WAKE_PHY support
 to WOL event
Thread-Index: AQHXkCCVH1orffAF2Euk1FyXsMmop6tzQucAgAAKnYCAAB0pgIACCFZwgAAXTQCAABQhQA==
Date:   Mon, 16 Aug 2021 05:40:18 +0000
Message-ID: <PH0PR11MB4950F854C789F610ECD88E6ED8FD9@PH0PR11MB4950.namprd11.prod.outlook.com>
References: <20210813084536.182381-1-yoong.siang.song@intel.com>
 <20210814172656.GA22278@shell.armlinux.org.uk> <YRgFxzIB3v8wS4tF@lunn.ch>
 <20210814194916.GB22278@shell.armlinux.org.uk>
 <PH0PR11MB4950652B4D07C189508767F1D8FD9@PH0PR11MB4950.namprd11.prod.outlook.com>
 <YRnmRp92j7Qpir7N@lunn.ch>
In-Reply-To: <YRnmRp92j7Qpir7N@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?NrfmDUW2L7dHDtMfji9YGge5lLCliVSa8R0cpvc/tN/Yf184z6KASn5bVc?=
 =?iso-8859-1?Q?06ilFcgzjscoIhwUIH3FyN9szdOx7cGSRwrdk/4khzN9sDfeTcbZLuiPzh?=
 =?iso-8859-1?Q?FQRf67o1EUUMEEKgUl7hcHAQtq254SphyjIQsmUYB+lnxEdnaasZgxzu8V?=
 =?iso-8859-1?Q?08XmqGxV05KrUMAszvrps+DEzJbCpKnjcOLh7oAAdvIMGz8bcQn5xCBm72?=
 =?iso-8859-1?Q?9rMNhIahnZWRdFobspkAtRMHNO8eXFpFR8aKCHgzNjbwA//vX/frCmWAXk?=
 =?iso-8859-1?Q?HmUhdxrjkM+WjCocOJHwVixyn3+LLFjgGMDkRJLtCpQ97lwmPVAyntWXoF?=
 =?iso-8859-1?Q?iOQAKaSbRarWYsP2KPpbWnlBFrh9EGIEgGMPe5qG3q/69a/hTXHSRlKd8i?=
 =?iso-8859-1?Q?n2eV2+eXR1Q3FX/QNO5F7GMzLEpgvtyhjXglUFn2taqJ7nczN6bP3myGrr?=
 =?iso-8859-1?Q?6uHPXMDCzt2LyuEO7kePEYW2ZgbGJBm3T3RfLM1CWRXrwhSDbBsxsCFR3r?=
 =?iso-8859-1?Q?DpUNbD9rHvJGUxpHLrAyaOA0Djt7h+BV+MQ00MQSefdmIQkupoJItFYRTO?=
 =?iso-8859-1?Q?gT5ILTESLjtEq4OUbkHyUClXGSG5QSbDLVf6d8Y5x90klRlIDH0DwoEDOB?=
 =?iso-8859-1?Q?TjDxwGtsDAJ3vMbBGXv9x9fey3jf675EyDTm25a0uc8I8BKlynipfzwRWs?=
 =?iso-8859-1?Q?iujuoPUvImACdGjJdPUB6G8kQtJKt92+T0Z8f7ILpwNrqBMw6er77WCSKD?=
 =?iso-8859-1?Q?RiUUGJHEwtkBJNjYAcW0ZUCNbGbbC+jOWB0XaNnMDx0RWfxTXJ4hyStnJv?=
 =?iso-8859-1?Q?4ZyyL8E8dFd5WYo40YeBdO/aApY6NBuqrfymmkFdEEs8ZImI5s8t4oqMtg?=
 =?iso-8859-1?Q?MdBrG4caCGwteMabU9Ks0b0iS0j4tBg9b+fqJZ2gHQEzD50Qn0Oe/sGbjy?=
 =?iso-8859-1?Q?myxVsR5XvtpEsuEN0Xtmhrmpy8MY/a7pyQpPJMyACiM7l493znrrbsCzdw?=
 =?iso-8859-1?Q?e8bEOXrHFlNHhenNCzlBBqikFjKbq++e+2DQ9S0+eRWtNdC/P9lVn4+WDV?=
 =?iso-8859-1?Q?eU5ovA3B3DtlDOHipJDy4/vUlL1fDxt3Um1O7NoB+6FbDCBBH/n5wh7tTz?=
 =?iso-8859-1?Q?jRSMpXb2AWDlkrEGmGk/JNCrqQrOe4wLHTjZqVbd0zbgD0Jpq4J8/tNIFx?=
 =?iso-8859-1?Q?3oSrQ6QFxQM/GHEio5VC0/Z95hF7OUaIFbXIrCsYQOs1G66lQc8g6XDZ0M?=
 =?iso-8859-1?Q?LMNuz+raN9wBElj/JX6pyWZJuM1v7bEZsszIIk4t2awqucrytpk3oLiP10?=
 =?iso-8859-1?Q?tfmfENg3l1ZlbEgtaxkCJZyw28mZ11WTVj5475xbdpmX3CcDJF7zwCfwli?=
 =?iso-8859-1?Q?qz8CvWnj6l?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4950.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1014d9af-bfa5-4840-8c59-08d96078549c
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Aug 2021 05:40:18.0229
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: r/a3F1M5PFmYzxg7A3bQPB2ywK7Zs7eD/OdjIxsf81EQCeji8og+m9kguJSZVJ5OnCIQaNK4nlqciHHFsANMtngTMT7RipRWo3geRVQ9nvU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4901
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Mon, Aug 16, 2021 at 03:52:06AM +0000, Song, Yoong Siang wrote:
> > > > Agreed. If the interrupt register is being used, i think we need
> > > > this patchset to add proper interrupt support. Can you recommend a
> > > > board they can buy off the shelf with the interrupt wired up? Or
> > > > maybe Intel can find a hardware engineer to add a patch wire to
> > > > link the interrupt output to a SoC pin that can do interrupts.
> > >
> > > The only board I'm aware of with the 88x3310 interrupt wired is the
> > > Macchiatobin double-shot. :)
> > >
> > > I forget why I didn't implement interrupt support though - I
> > > probably need to revisit that. Sure enough, looking at the code I
> > > was tinkering with, adding interrupt support would certainly conflict=
 with
> this patch.
> >
> > Hi Russell,
> >
> > For EHL board, both WoL interrupt and link change interrupt are the sam=
e
> pin.
> > Based on your knowledge, is this common across other platforms?
>=20
> Other PHYs? Yes. WoL is just another interrupt, and any interrupt can wak=
e
> the system, so longer as the interrupt controller can actually wake the
> system.
>=20
> > Can we take set wol function as one of the ways to control the
> > interrupts?
>=20
> WOl does not control the interrupt, it is an interrupt source. And you ne=
ed to
> service it as an interrupt. So long as your PMC is also an interrupt cont=
roller,
> it should all work.
>=20
> 	  Andrew

Sorry, I should not use the word "control". Actually what I am trying to sa=
id was
"can we take set_wol() as one of the ways to enable/disable link change int=
errupt?".
PMC is not an interrupt controller. I guess the confusion here is due to I =
am
using polling mode. Let me ask the question differently.

What is the conflict that will happen when interrupt support is added?=20
I can help to add config_intr() and handle_interrupt() callback support
If they will help to solve the conflict.

Regards
Siang