Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Hongbo Wang <hongbo.wang@nxp.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
CC:     Andrew Lunn <andrew@lunn.ch>, Hongjun Chen <hongjun.chen@nxp.com>,
        Po Liu <po.liu@nxp.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        Leo Li <leoyang.li@nxp.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
        "vivien.didelot@gmail.com" <vivien.didelot@gmail.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH v1] arm64: dts: fsl: ls1028a-rdb: Add dts file
 to choose swp5 as dsa master
Thread-Topic: [EXT] Re: [PATCH v1] arm64: dts: fsl: ls1028a-rdb: Add dts file
 to choose swp5 as dsa master
Thread-Index: AQHXj+75u2Pfw5dj90eW5XnXIP17J6txaSUAgAAItjCAAAd1AIAELgBQ
Date:   Mon, 16 Aug 2021 06:03:52 +0000
Message-ID: <VI1PR04MB56777E60653203A471B9864EE1FD9@VI1PR04MB5677.eurprd04.prod.outlook.com>
References: <20210813030155.23097-1-hongbo.wang@nxp.com>
 <YRZvItRlSpF2Xf+S@lunn.ch>
 <VI1PR04MB56773CC01AB86A8AA1A33F9AE1FA9@VI1PR04MB5677.eurprd04.prod.outlook.com>
 <20210813140745.fwjkmixzgvikvffz@skbuf>
In-Reply-To: <20210813140745.fwjkmixzgvikvffz@skbuf>
Accept-Language: zh-CN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?psAQgs30+UumSRgCxN81wa5nTeK5ewR25l7Xn89zEzWS+Jg7pCuUSS0ehvAo?=
 =?us-ascii?Q?LimIhPi09l/N43y90nbX12ExwQ3CPlN58oND/nQ8wNyG2jq90SjI0ePVpFBK?=
 =?us-ascii?Q?uSUqo5u2/UFNC+bZjLnwDY/jDIx1xv+LU7a25pqqjgMRiPR1JVeTi7WFeSVE?=
 =?us-ascii?Q?cZHY3r+BJXJ/RuMVqSn7uWJJ+dFNHka00pjo/HCRPyA2KRUw+Kn9xMNGqlTf?=
 =?us-ascii?Q?9vP1u81XsZ2C7gIRfMR8M+IspKUFVZGK4sIsErduqiyaAaJ5nHb3tv2P/T4G?=
 =?us-ascii?Q?0dXy45c7c2XCCidYRw3if4AlseckGMd0vxDdk1OOzzYH313qXqa709vgXqCJ?=
 =?us-ascii?Q?kR4Z5Ewbi/6hRMg2UYchJ9uPL5zwXszR2ilJvHmnn7IfSbUUJ6BvexyW9qGF?=
 =?us-ascii?Q?7UgYoF3FotS9xN0z3UaXjW+h2KIX4g/0Bcef3ndhfJa7jt2FjNiyhcLpFbD8?=
 =?us-ascii?Q?yBaE3Timsu6omEwBPPh8+/3PtWXtGv/rhveAv9bI8S49yUwqPYmmHUhg/Cdx?=
 =?us-ascii?Q?GfkrItegCxWTBoaokeplXMrcSw/iaUHTEVZITNKWzFyRq1JNyo5l2/1c/Irg?=
 =?us-ascii?Q?hiAlX2Bnij0O7KkUoOK7vUK+xYJSt0zuSkwFHckKypLnnWQ/N6X8dvru8RcT?=
 =?us-ascii?Q?4jV3JVEju5QZH3OdxdgU/zzu5f/S+PzWVoVJ7e0XwKpoJTARN+Cxg+TYrjDC?=
 =?us-ascii?Q?PracHIdoKgb20wFqoJp0OhsA92tBGKOpMOUA2v6VDuR2yuYVUYJ/7TQE+Yur?=
 =?us-ascii?Q?A61OXThOENv4r3Pc4ooo2M4ktlcV8/EDEdD6jhUTnTpCtKqbUNVOf/lppyKI?=
 =?us-ascii?Q?vMgA0NvBNzhCarQXh+GHrgt36PHzWwOdO/wpzKwOFHHW5YdyS/OP4NxLRWj1?=
 =?us-ascii?Q?f1Ad3uv6iqwxQKTrhWcV4AOL/cM1Y5jleTg8EoG1UUFo1noXO7NMu6XiRGfh?=
 =?us-ascii?Q?iv04rVefHVjSblsnPgoc+mx4IKkKxNIOtlL3tauAGuqn1QrGRW52DrPo1vmp?=
 =?us-ascii?Q?XWH9UktmF6ACw2Qq6JGTwErWEvz95NMxbiunWQu9E1S1lSpECnGVoiOBQrx5?=
 =?us-ascii?Q?9uI0MqGKif/1niNMCajr1HWQfqevW8NQk9phxCtMvfHSmANLii13zn7DWt9L?=
 =?us-ascii?Q?fI4LOTrjjeTWM7clYBQmImQqjmhW7TVTlW6h3K6tUZtnTy6/+SX6KwoAGeTS?=
 =?us-ascii?Q?9L7S+02kI7EwLkp5NAlWjy1iaOU3an/EYVedOJxJZgFgOC/SLzdabqaM3QEQ?=
 =?us-ascii?Q?YuArmy+LuxlFOqjumpA4j7TtDi3t3Z/RiMeojfpMVKdg9jOuJmfI0B0dD6Vr?=
 =?us-ascii?Q?LbM=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5677.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c4f622e-9806-42ca-3744-08d9607b9f85
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Aug 2021 06:03:52.1008
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xni/9d0aAluZ9Oj5mu8vTdE1MWEKW5+2NUgOilCYjyOWATiLIqNl019hqxKuNegzFDZRCw39fJWNLJYdvJAVFA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2654
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Fri, Aug 13, 2021 at 01:56:53PM +0000, Hongbo Wang wrote:
> > > You will end up with two DT blobs with the same top level
> > > compatible. This is going to cause confusion. I suggest you add an
> > > additional top level compatible to make it clear this differs from
> > > the compatible =3D "fsl,ls1028a-rdb", "fsl,ls1028a" blob.
> > >
> > >    Andrew
> >
> > hi Andrew,
> >
> >   thanks for comments.
> >
> >   this "fsl-ls1028a-rdb-dsa-swp5-eno3.dts" is also for fsl-ls1028a-rdb
> > platform, the only difference with "fsl-ls1028a-rdb.dts" is that it
> > use swp5 as dsa master, not swp4, and it's based on
> > "fsl-ls1028a-rdb.dts", so I choose this manner, if "fsl-ls1028a-rdb.dts=
" has
> some modification for new version, this file don't need be changed.
>=20
> I tend to agree with Hongbo. What confusion is it going to cause? It is
> fundamentally the same board, just an Ethernet port stopped having 'statu=
s =3D
> "disabled"' and another changed role, all inside of the SoC with no
> externally-visible change. If anything, I think that creating a new top-l=
evel
> compatible for each small change like this would create a bloat-fest of i=
ts own.
>=20
> I was going to suggest as an alternative to define a device tree overlay =
file with
> the changes in the CPU port assignment, instead of defining a wholly new =
DTS
> for the LS1028A reference design board. But I am pretty sure that it is n=
ot
> possible to specify a /delete-property/ inside a device tree overlay file=
, so that
> won't actually work.

hi Vladimir,

  if don't specify "/delete-property/" in this dts file, the corresponding =
dtb will not work well,
so I add it to delete 'ethernet' property from mscc_felix_port4 explicitly.

thanks,
hongbo