Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] tty: replace in_irq() with in_hardirq()
To:     Changbin Du <changbin.du@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org
References: <20210814005033.2381-1-changbin.du@gmail.com>
From:   Jiri Slaby <jirislaby@kernel.org>
Message-ID: <158e002d-3fa4-6027-29cd-33e446cddf19@kernel.org>
Date:   Mon, 16 Aug 2021 08:23:57 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <20210814005033.2381-1-changbin.du@gmail.com>
Content-Type: text/plain; charset=iso-8859-2; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 14. 08. 21, 2:50, Changbin Du wrote:
> Replace the obsolete and ambiguos macro in_irq() with new
> macro in_hardirq().

... which is just a new name.

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

> Signed-off-by: Changbin Du <changbin.du@gmail.com>
> ---
>   drivers/tty/sysrq.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
> index 6628792431dc..c911196ac893 100644
> --- a/drivers/tty/sysrq.c
> +++ b/drivers/tty/sysrq.c
> @@ -258,7 +258,7 @@ static void sysrq_handle_showallcpus(int key)
>   	if (!trigger_all_cpu_backtrace()) {
>   		struct pt_regs *regs = NULL;
>   
> -		if (in_irq())
> +		if (in_hardirq())
>   			regs = get_irq_regs();
>   		if (regs) {
>   			pr_info("CPU%d:\n", smp_processor_id());
> @@ -280,7 +280,7 @@ static void sysrq_handle_showregs(int key)
>   {
>   	struct pt_regs *regs = NULL;
>   
> -	if (in_irq())
> +	if (in_hardirq())
>   		regs = get_irq_regs();
>   	if (regs)
>   		show_regs(regs);
> 


-- 
js
suse labs