Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp78829pxb; Sun, 15 Aug 2021 23:54:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwI0nzhTdIOsGdm4mhX/8q0r5WZLHMguW2Z88oPyXVX7v6mGmPwqiJkJk2nze3t18P2oTZs X-Received: by 2002:a05:6402:358d:: with SMTP id y13mr18603447edc.300.1629096881955; Sun, 15 Aug 2021 23:54:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629096881; cv=none; d=google.com; s=arc-20160816; b=E1c3iRTUW4Zm9LNxX4gigRZyepY1tZfHHYTIzVMEYqES8qq6wPvqDMwXrMtGIV9gQY iiA89PXzav05hXndoXSZ7JRlzzCm3zGpT4E4Du569qT0zxPcJggT+7/VE1ujEV6KJqSx UQmjUsRJW8Ui8htn+akyzqmdkq3f/gTR+5JMaNTaplyjEd+WztCk2e5Wx3ON1uNNhKN5 DbzPfmUoF56P65O4xihGKAiHpAm4YwxC+HFU5HzSi4WaWaU5ujDq6kI4IVrsI8M7Iy3U 4Q4Qes9CGAlw3uys/9VMZgtD57Wlqf8fQBJ744ha3gPJjhw1RSY+YWZnFDEan5DTJhDV bn+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=r48rBz2rjRMDfj6gGULlXzSKdTH3F01XHbMn7Q49MNM=; b=QEcU1kPHMJ5c8fnEYwlU+h0mBIBEOF3thFNp9nBIM69NAPGh0cgV8MDJUrJR//DH1q ycQ8AI5hYOcU1WMFe0u8T/6EjQkqnAr4v6ZBHI+e4RTkjYv+h0rpq1UHplR8INRMbS5a yR6KzBXGrwsHffFukGwSqVXeKBHdUYgYq5sQQAhaPHrbU1qEsP752H262b1+YbWqqo3E 49L/G2IWc1MGCgeE3rsiHSnPmFBLMIQSNoFjTlYgFRtKGE6Pj6WnNxN/u1tQolABDNi5 KVPfXj2MlI3O6gCS68NMeD+Rr8lZ0UWTFruDfTocWeNGXd6yso8XG0hurqHpDs5d9ZkB Qw4w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k24si258738edv.610.2021.08.15.23.54.19; Sun, 15 Aug 2021 23:54:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233546AbhHPGxJ convert rfc822-to-8bit (ORCPT + 99 others); Mon, 16 Aug 2021 02:53:09 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:58809 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233349AbhHPGxI (ORCPT ); Mon, 16 Aug 2021 02:53:08 -0400 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 211171BF209; Mon, 16 Aug 2021 06:52:33 +0000 (UTC) Date: Mon, 16 Aug 2021 08:52:32 +0200 From: Miquel Raynal To: Clark Wang Cc: conor.culhane@silvaco.com, alexandre.belloni@bootlin.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com Subject: Re: [PATCH V4 3/8] i3c: master: svc: separate err, fifo and disable interrupt of reset function Message-ID: <20210816085232.46682b0e@xps13> In-Reply-To: <20210809063645.2289988-4-xiaoning.wang@nxp.com> References: <20210809063645.2289988-1-xiaoning.wang@nxp.com> <20210809063645.2289988-4-xiaoning.wang@nxp.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Clark, Clark Wang wrote on Mon, 9 Aug 2021 14:36:40 +0800: > Sometimes only need to reset err and fifo regs, so split the origin > reset function to three functions. > Put them at the top of the file, to let more functions can call them. > > Signed-off-by: Clark Wang > Reviewed-by: Jun Li Reviewed-by: Miquel Raynal Thanks, Miquèl