Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp106069pxb; Mon, 16 Aug 2021 00:45:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzKAah/e38rY2TAVqlSLsmbYHdse0r9aAEHP4JCzDkd0xPCwLyZOYWYKoyXmCNDDTQjNnXH X-Received: by 2002:a92:6802:: with SMTP id d2mr2098654ilc.40.1629099908571; Mon, 16 Aug 2021 00:45:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629099908; cv=none; d=google.com; s=arc-20160816; b=RCnz8z+77ZeWZ7t8AFgnjnX/fQX7gmfutPUa0hib3w4tde0rLexMIwi69jbM1+02Xw 6an9l2Jjc/dL0JaeytxTzsZri4gfgrhKjmcFog34cPEjMcA3AFmmMOz02rfJrdVQs3iT 1jiqBV8Yh7AYGQan0Nis6H15nwcCwlRL2dmQX+zluE7V/KqES/A2Uy4xPiZnJVM76nEt DL4xTLpZ+4Yh3lFpAx+3oVJximqt34NqKb3DjiUlpfiycynoa7uyiWX1zSIxfjXeGJki c66tfoO1+zQyKlTPRqW5I8QXZybQXpqnhogLS1xoAGdIdbpBD4kLwIGx/gJMMXNmqEFD E/vQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=IiqiHmJwUKlRUJT8e7Xl/rySAiPS/NlLl/9KjBlyPlc=; b=vYwSLWRiJVli1/jfPYJ831Nn8MmNzvwU6Ddilr80zb8WR220iJIsewVYEU63NiWQsE ESQ0W38Bq/QO7aQ//DRv84akSxGGjzNllcdibICJD3pxN3z2rmSd0Bd7q2gOF4okabtO 1iEWoIHuuaXafbX/rjqy2WRekSphvmxxure6hjthir2KzSjVTCahT/xdDVINYkklIz2+ BlQmsx9jcdLAFaVVu5jNUqR+mp+6q23zfv0sDyZrT3l53gWjZDB/32R9DCzuPo2cvqqp 8dh/6nwQpQ+QXPO1SoM93LCf4qmNpjpV4DCGrik3vLwETFFXaoPfqxRYTQ4tKTXpf1kK jKzQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w12si11265769ilo.99.2021.08.16.00.44.57; Mon, 16 Aug 2021 00:45:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234197AbhHPHns (ORCPT + 99 others); Mon, 16 Aug 2021 03:43:48 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:17023 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231499AbhHPHnr (ORCPT ); Mon, 16 Aug 2021 03:43:47 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Gp5dt5TbVzb2Qj; Mon, 16 Aug 2021 15:39:30 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 16 Aug 2021 15:43:13 +0800 Received: from localhost.localdomain.localdomain (10.175.113.25) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 16 Aug 2021 15:43:13 +0800 From: Kefeng Wang To: , Rob Herring , "Frank Rowand" CC: , Russell King , "Linus Walleij" , , Kefeng Wang Subject: [PATCH 2/3] Revert "ARM: amba: make use of -1 IRQs warn" Date: Mon, 16 Aug 2021 15:46:18 +0800 Message-ID: <20210816074619.177383-3-wangkefeng.wang@huawei.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210816074619.177383-1-wangkefeng.wang@huawei.com> References: <20210816074619.177383-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After commit 77a7300abad7 ("of/irq: Get rid of NO_IRQ usage"), no irq case has been removed, irq_of_parse_and_map() will return 0 in all cases when get error from parse and map an interrupt into linux virq space. amba_device_register() is only used on no-DT initialization, see s3c64xx_pl080_init() arch/arm/mach-s3c/pl080.c ep93xx_init_devices() arch/arm/mach-ep93xx/core.c They won't set -1 to irq[0], so no need the warn. This reverts commit 2eac58d5026e4ec8b17ff8b62877fea9e1d2f1b3. Cc: Russell King Signed-off-by: Kefeng Wang --- drivers/amba/bus.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c index 2f2137518be0..36f2f42c8014 100644 --- a/drivers/amba/bus.c +++ b/drivers/amba/bus.c @@ -377,9 +377,6 @@ static int amba_device_try_add(struct amba_device *dev, struct resource *parent) void __iomem *tmp; int i, ret; - WARN_ON(dev->irq[0] == (unsigned int)-1); - WARN_ON(dev->irq[1] == (unsigned int)-1); - ret = request_resource(parent, &dev->res); if (ret) goto err_out; -- 2.26.2