Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp155770pxb; Mon, 16 Aug 2021 02:18:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwX+22zVsRC+qX+CMF52348GlM/nEnmrcSRNYwE90l6lRhDWQy688q3RzAMqzBssTibMrUi X-Received: by 2002:a92:da87:: with SMTP id u7mr11506921iln.297.1629105526403; Mon, 16 Aug 2021 02:18:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629105526; cv=none; d=google.com; s=arc-20160816; b=Ng2kazqSVNrn1cqfrzanB+ve02AX+PhcyDNbQulXPsN95ArU7Ia3ICscWYr12Ftqz5 H9IwdBH4So1AO8C9VPaQ1HqzEoH5cI1owqKnACnuDzUWvsMVhg63b6tyzZ3SwH5Ukp0T Bb4GMhnJjeq2Ahf05vuum+5NZPbVDqQBz2L5LZAtZP8CE6wjArKjHPx464q7LXAijiiX z9FWbMGsS4FNf54IBKE/VGoZj5UwoGuGp7DQagrcKHGLCZCsWSgpiuFFH4tTMkKzdT45 xow3gGD1/0FmHfQvSnH++tOYnj56VVUXJMJuCm8/jWrw1oexg1xpNFSacaPuvfn1ZaF/ jVkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=+Cq8XhC/Hs5rWd5cGFsYgTVgUJ8lBvrSmNry25OJTIA=; b=R9ZwvM5miMn4xVDWthsL+ZtKP3z1elBNBtoK152iyGydZnIOiJqLsgkeFe4xmCPrVZ RB31EwUnJwoI0GG/OVE5o1SuEzhR2YzrdC2++dkEfytrKHXClcGHaB8ECmLgpLSbIXnB 9d+Tx8QharVvJjBdtsN8TrwpX19aKW+uazGkFytdWnwSxIAmcC9s+Q9iC2iqRmfl32HZ W8OCgCwV4LDIAZnR2HIEATwnRjGm5/uS2I76T1PjTkiGL8UFzCGxtdijUhgGqtemoZzQ gT66JLZ98XS6VIfzAAn12yvMjTGrZAhnIKWvlB0dU1qMWqU6YS5prAthNvnzGU+M4/TC SARQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=dDsx9TJi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v13si9850387ilj.65.2021.08.16.02.18.31; Mon, 16 Aug 2021 02:18:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=dDsx9TJi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235189AbhHPJR3 (ORCPT + 99 others); Mon, 16 Aug 2021 05:17:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235163AbhHPJR3 (ORCPT ); Mon, 16 Aug 2021 05:17:29 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEDD3C0613C1 for ; Mon, 16 Aug 2021 02:16:57 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id b10so21984928eju.9 for ; Mon, 16 Aug 2021 02:16:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+Cq8XhC/Hs5rWd5cGFsYgTVgUJ8lBvrSmNry25OJTIA=; b=dDsx9TJiocBa/R/cEkeQ8uaVbyiNfSsAAjbgHywE+iZH8fG6pf3M2NW/jsZRhJhNHw PyvBu9rLiim6NTYFHlk3odsCp+IJUbwOHMPUUhlbIXe51w4z5tB96e88I4fKio0omV4d 0fOfE2mqw8Z2G0ceqLU7RJPROqrET5idQqNFA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+Cq8XhC/Hs5rWd5cGFsYgTVgUJ8lBvrSmNry25OJTIA=; b=lCZCtOcIsRjH0dz+G6EanAA4RQoue0bsMl5Z5eYGt1trMsXT9euuQA+6N5t9m8JaFz Q7eFfNl/40VvpZgb7dUpIYAeNhz65t4WPJVbF+uT5nuHeUO4QwPjQxgtMvleG+GH4XZu wGldTPLPJy2hRfn67SEvipn1EgHsbhXkqjeyI3rmTgAcjzi9PmYhlXv3f20dVavjgHJl fmcpXkM+E1tswHYKwrSDuSf5wAWn/b0SoJDMritx3pnsr/glSthMlax0MGwnyf30PZJi Ix/4w0ayjz3RxPFxHATjZLrfTAMuj3icTIxFjxRgLod0f0qk3jZDmgQXQIayxjLkGyH0 +gPw== X-Gm-Message-State: AOAM530MPGNZ+q3DI6ENI3qt2fpNuLzUmaLUdfCKEIpL/YW7NpVLQsE5 Wl0LDHEMMFSu0AfTG4I5gPGMJfHkg1YdqoOxVCNrjQ== X-Received: by 2002:a17:906:a08a:: with SMTP id q10mr14893306ejy.100.1629105415853; Mon, 16 Aug 2021 02:16:55 -0700 (PDT) MIME-Version: 1.0 References: <20210816085531.12167-1-dinghao.liu@zju.edu.cn> In-Reply-To: <20210816085531.12167-1-dinghao.liu@zju.edu.cn> From: Selvin Xavier Date: Mon, 16 Aug 2021 14:46:44 +0530 Message-ID: Subject: Re: [PATCH] RDMA/bnxt_re: Remove redundant unlock in bnxt_re_dev_init To: Dinghao Liu Cc: kjlu@umn.edu, Naresh Kumar PBS , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org, linux-kernel Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000a27da105c9a9a9b3" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --000000000000a27da105c9a9a9b3 Content-Type: text/plain; charset="UTF-8" On Mon, Aug 16, 2021 at 2:26 PM Dinghao Liu wrote: > > Commit c2b777a95923 removes all rtnl_lock() and rtnl_unlock() > in function bnxt_re_dev_init(), but forgets to remove a rtnl_unlock() > in the error handling path of bnxt_re_register_netdev(), which may > cause a deadlock. This bug is suggested by a static analysis tool, > please advise. > > Fixes: c2b777a95923 ("RDMA/bnxt_re: Refactor device add/remove functionalities") > Signed-off-by: Dinghao Liu Acked-by: Selvin Xavier --000000000000a27da105c9a9a9b3 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQfAYJKoZIhvcNAQcCoIIQbTCCEGkCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3TMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBVswggRDoAMCAQICDF5r4Y1hK+0xlnInPDANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMTAyMjIxNDE4MjNaFw0yMjA5MjIxNDUxNDZaMIGc MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xIjAgBgNVBAMTGVNlbHZpbiBUaHlwYXJhbXBpbCBYYXZpZXIx KTAnBgkqhkiG9w0BCQEWGnNlbHZpbi54YXZpZXJAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0B AQEFAAOCAQ8AMIIBCgKCAQEAxUvDzFRYD8BTJrAMQdCDuIfwWINjz4kZW2bdRd3xs/PuwwulZFR9 IqmPAgBjM5dcqFtbSHi+/g+LZBMw6k/LfLLK02KsorxgMOZVCIOVCuM4Nj0vrIwtMJ+fNnaa6Dvu a85G89a0sBrN3Y6hDnOfpbimSOgwA82EFWkGY4VggzfB7w1rhwu515LAm0sN0WOsrGP7QI8ZJr8g od7PzGNQ3SgTYKl5XslMq+gpy+K8+egxMxo3D07c8snwyfU7Y7NQ8I1M986gsj9RUcp3oo0N+T1W rwVchQXTGD/Hwqc11XBU1H3JKSRkn7cTa9bMFnp0Asr3Y4/kB+4t6PhYi50ORwIDAQABo4IB2zCC AdcwDgYDVR0PAQH/BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDov L3NlY3VyZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAu Y3J0MEEGCCsGAQUFBzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29u YWxzaWduMmNhMjAyMDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0 cHM6Ly93d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBA MD6gPKA6hjhodHRwOi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2Ey MDIwLmNybDAlBgNVHREEHjAcgRpzZWx2aW4ueGF2aWVyQGJyb2FkY29tLmNvbTATBgNVHSUEDDAK BggrBgEFBQcDBDAfBgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQU6uPX 5eOTTGwUwIAAoXKF4qVZLfgwDQYJKoZIhvcNAQELBQADggEBAKAn7gHcWCrqvZPX7lw4FJEOMJ2s cPoLqoiJLhVttehI3r8nFmNe5WanBDnClSbn1WMa5fHtttEjxZkHOFZqWLHYRI/hnXtVBjF9YV/1 Hs3HTO02pYpYyHue4CSXgBtj45ZVZ0FjQNxgoLFvJOq3iSsy/tS2uVH5Pe1AW495cxp8+p5b3VGe HRzGet524jE0vZx0A/6qrYo6C7z4Djrt/QU2MZDbPb+kwkkomwcn0Nvr91KWSrbhhHtZ/EfXi08L x3R3oHtWjbmIW1nYkwVk4pQZoaLkRWkfTSGpwDwilhrd2F+d5rhCbAbfACk4Oly51GV4SI7jUm0D VbZWyuIx85gxggJtMIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWdu IG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIw Agxea+GNYSvtMZZyJzwwDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIGNx/vvNVZx2 guxnOWpTT0JatobUOW5jgXYeSyIu4zHtMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZI hvcNAQkFMQ8XDTIxMDgxNjA5MTY1NlowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJ YIZIAWUDBAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcN AQEHMAsGCWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQAKHPCYaMbD9/cyntz9JlmW57MaZD+S N/GNiYNLiEILJzuCcDOFv9+Oo/ccUnF1HAzXzXRXkmQa4aoHfQv3za+wDmUI9kgTcSFtC+L+p9Yb agGpm+kj1Pn96mAEYmbbzCYwTL6hJXhLxx79zcoObbcSFDfmiCeY8vYgnNVxaX9jU4OqVqBcaacG fsb7HuQiNAgZKUgh3yg0mzbQTLm4rN8BbrLYaZBN45APEHs1uZ/0aL/tv0jnAWBbGdf6JAKaDYt7 gfLXx9g5ctnvShan8SbBA+K8wo4qQrVJw726OUX3LoBJsHoSar5aRoiH8wkmgtz7hByzMaowzWwg fFf5408O --000000000000a27da105c9a9a9b3--