Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   =?iso-8859-1?Q?Christian_L=F6hle?= <CLoehle@hyperstone.com>
To:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>
Subject: [PATCH] scsi: sd: Do not exit sd_spinup_disk quietly
Thread-Topic: [PATCH] scsi: sd: Do not exit sd_spinup_disk quietly
Thread-Index: AQHXkoIH1dJPthk+/U+6Ae1Ef5Tiig==
Date:   Mon, 16 Aug 2021 09:37:51 +0000
Message-ID: <CWXP265MB26803209FD08A64222EEEA02C4FD9@CWXP265MB2680.GBRP265.PROD.OUTLOOK.COM>
Accept-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?AqV3c9kjYQScEG09e+qNYzRSyrCDgG/K1mDHHdiMkoNolcIzraFbYY3tZ6?=
 =?iso-8859-1?Q?frSnLus7O3s0QCWQSeSY0zxYlZyDvZH4YenOaXRkTJnQOxE8RbjhBd9wW4?=
 =?iso-8859-1?Q?dhYFbOxHFWQ3g536ijnZs8lva7FwxT4mOeq7mq7U80ykXfvJSS1H2VIvwJ?=
 =?iso-8859-1?Q?c94EMV3SHW15FnuTQN/5fqmmILuO8DRBQjGUqqZAUaO48LbjuLclW8yZ7/?=
 =?iso-8859-1?Q?2vth24AMQGxV3UcG/Joxci0sQKGrmYTRld+uFiFkZUBcco4JRDJ0WabzOe?=
 =?iso-8859-1?Q?4MI2/f+l/ejvrV6Iyw7efy8E1PVkEXdpcD5ZfBrwFi5Vcbm7FiGMcqWtcu?=
 =?iso-8859-1?Q?WB7aXo5sLHij2qzWL6WkaxC8X6X4fdPtAJNPHPiw0yUohsCh53b2XzKeRB?=
 =?iso-8859-1?Q?L6bvAJGyuTxlZgUtQoxClpCfaWaELIr8YI7TQMxEn/WWF+UlM63QotbuG/?=
 =?iso-8859-1?Q?qbMVc34bbjBbU1ixsX4YUqEjNHSBa6gwf3fEOn9il8HdUhCBKEImWdQH9B?=
 =?iso-8859-1?Q?O2IIMGvMQPp7x1fmfWYE7fu+N1pqTK23d0MnjpBMUYbRP55rkZxOEHSG9U?=
 =?iso-8859-1?Q?Rpv8QqPqAkxEB07m9zvr1G2Vuhlq+KHoOvn2lWJXDHEjZEu3jQTZ+olvTX?=
 =?iso-8859-1?Q?Ulb2CvPeJq0bjJZrPvNzhW9QVSUu0dWKQC/00CuugybRDt4lj12VfC6fzu?=
 =?iso-8859-1?Q?ULIVKRGPdGIUrMQwz6f+IVXDfo30lrnuzLmT+H7z3ry2X3oB7wDvKdj9AD?=
 =?iso-8859-1?Q?PRg56Mh4YnE1w1ruoW7Mu0S8tGdX7QJpeUqztKqDi02zr7nI7pjSyR9TqN?=
 =?iso-8859-1?Q?ZOko9FHpXXKzf62UPbw6drQcgr99JG2SqDFe58lg5/vI3gxFsHt0Oqjzg/?=
 =?iso-8859-1?Q?fSog3GF9vAQkcKNIP9clQpG+Vq2cG2yZHCZpFPF/PqZdKD9Mdh0vxLQKxO?=
 =?iso-8859-1?Q?MFK6mIUZFB6IvhEOjkueihGAYlfHGW+WGXiZaTfWdiKw5L4VsASJDsSQM4?=
 =?iso-8859-1?Q?4Bw2jckwmy4UNZqqJNJBdIMeiTW+76HgSR5BLjIXVlvee0JbIJAmwO8Ody?=
 =?iso-8859-1?Q?hO6wGILytk0O7NJShdwcvv+xuARRHX5bNgqqriEnnuNNAHJ6iPWvXLM6GI?=
 =?iso-8859-1?Q?rfwyEDLpbvecytL8R+PHB/QJ5mdcghOv55wm0L0iYR3m0sRqWvqsEeIYH6?=
 =?iso-8859-1?Q?ZR//wvB8FAApOwixuzApmU7gMZL8xIdMrWhIZPpbqS/g95YpL7G3X5msB+?=
 =?iso-8859-1?Q?K+LB4XFRHlZQQ0bdBdlUif28vJGxqkBKCAKg9zWOIUYy6n1dONINuZ3aW9?=
 =?iso-8859-1?Q?1/ejlsKoFRi+XSf0/pa7pqSdtm1YhVeZO8vLLA5cBpm7QO8=3D?=
x-ms-exchange-transport-forked: True
MIME-Version: 1.0
X-OriginatorOrg: hyperstone.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CWXP265MB2680.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a9829e2-baf4-4d03-804a-08d96099845a
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Aug 2021 09:37:51.5794
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 86f203eb-e878-4188-b297-34c118c18b11
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: m3iQ9Ie17MPngmfjeDHj9Et0irWp0j6VakUQaWFXXH97txYLh5KoYkXtUB5fs+8z8EJjTSVU6rIl2Pvnl6q1xA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWXP265MB3221
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: hyperstone.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The sd_spinup_disk function logs what is happening nicely.
Unfortunately this output stops if the media was marked removed
in the meantime. To prevent a puzzling output, add a print
for this case, too.

Signed-off-by: Christian Loehle <cloehle@hyperstone.com>
---
 drivers/scsi/sd.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index b8d55af763f9..7e556f5b57e0 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -2180,8 +2180,10 @@ sd_spinup_disk(struct scsi_disk *sdkp)
 			 * doesn't have any media in it, don't bother
 			 * with any more polling.
 			 */
-			if (media_not_present(sdkp, &sshdr))
+			if (media_not_present(sdkp, &sshdr)) {
+				sd_printk(KERN_NOTICE, sdkp, "Media removed, stopped polling\n");
 				return;
+			}
 
 			if (the_result)
 				sense_valid = scsi_sense_valid(&sshdr);
-- 
2.32.0

Hyperstone GmbH | Line-Eid-Strasse 3 | 78467 Konstanz
Managing Directors: Dr. Jan Peter Berns.
Commercial register of local courts: Freiburg HRB381782