Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp175381pxb; Mon, 16 Aug 2021 02:55:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJ52HZj2uHy2UGpQEDLoeAK8zJGRre3I4wvszjJtagKTAN+jTqAvvT22Dg1uwkNH8IBwl2 X-Received: by 2002:a5d:8195:: with SMTP id u21mr11822126ion.207.1629107735149; Mon, 16 Aug 2021 02:55:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629107735; cv=none; d=google.com; s=arc-20160816; b=gp7n2bKhoDjF0vLAha26VH97pIMSdANEf/J9ESKX5o+2G6fri8DJPU66lEcrBfeOaZ hRfldIGuraQWyC3X8edDGBDELq0djGC6E41y+PFgKX+us/cmGMuNEj676PaBs61ARlu6 dycVJLvTQPmtdazEEgWAd3nm4m5uBltW7kgPEsCT1lArtdB9yBNDbks4R7ghgONRMRfn J6/lp7+MQ4dL2trwyp/guRzVSw35jk6qTQfF+vOws4Zh1hBJn09vPKwbB46q+Am/0ywc /WDZzjHS30bdp1ZoCM2zg8AXAtg7bmgJmYo/qWZHmT/fOzEEYtdRcDVY39+KKW9kpGaw vKkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=rPHYIXTB11jTLUaw8xSCpjfzdCFfMm8VFV2GzvAfkb4=; b=lQbaAqCMaqIIj5CwcTz29xL3hDJ2eWN12+z1Ki8fYJ7va3YKUqnSOTBe6dgqY3M1/W m4Ed7su1tZ9RHJ8aA3D6cDmEB5cX2cR9RPCAVSvZ75GANc7V9ex290rtBlR61Ba1ll8+ OHWiJ2rmIlwro/Wo04AAy+l7//E4yAdeShqrRhEXRgQI+UEFR7SGXXSDxqcAIPbbScri W5orteFM4fIj6C+MoFYb4v9wkVWfl3Fs+gqmVspTcn7Bn/+VlmXMMrfh1wBprZ8WR2Pq LPqrJCiQx1lj1R2HROfKrOQ6mafhJ0IJi8sAVZiPopNRVALCefJCRbJVZRqPw8eGtkR1 BmvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="VRO2j5/p"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j14si11709685jat.60.2021.08.16.02.55.24; Mon, 16 Aug 2021 02:55:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="VRO2j5/p"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235494AbhHPJzL (ORCPT + 99 others); Mon, 16 Aug 2021 05:55:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:35436 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235336AbhHPJzL (ORCPT ); Mon, 16 Aug 2021 05:55:11 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5935461B72; Mon, 16 Aug 2021 09:54:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629107679; bh=rPHYIXTB11jTLUaw8xSCpjfzdCFfMm8VFV2GzvAfkb4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VRO2j5/pJm8WYPaiWFwt+7bLKrzguPBjC5t2HwDyEw/hO9mS9lnlYzT30/siBqKmo fihZOGhDsy5WPhwnCQb4NXdCmrYAmtUagg709AtqRy2ihFBZQGgsffrxZlUj8NLx/a kXEgVTEmul7EsrDKemw5iroi+8ats8kZgUx994kjA2aG13639FbgtrlStAyR8VAx2h iTWDF6Qrvj5lmxHw9qxl9y4PabIWaicc+p+vRnb7gl/EZE0uJsAiR61kDQN/NWnNrL yrlb3m1Puph3mSkyWDHLEOgCs21qyJBlOa+lGV818PHpLDgcsLkJ9oXz+g6StasqSc AQFxuyWZkbalg== Date: Mon, 16 Aug 2021 11:54:35 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: "Song, Yoong Siang" Cc: Russell King , Andrew Lunn , Heiner Kallweit , "David S . Miller" , Jakub Kicinski , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net-next 1/1] net: phy: marvell10g: Add WAKE_PHY support to WOL event Message-ID: <20210816115435.664d921b@dellmb> In-Reply-To: References: <20210813084536.182381-1-yoong.siang.song@intel.com> <20210814172656.GA22278@shell.armlinux.org.uk> <20210814194916.GB22278@shell.armlinux.org.uk> <20210816071419.GF22278@shell.armlinux.org.uk> <20210816081812.GH22278@shell.armlinux.org.uk> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 Aug 2021 08:56:36 +0000 "Song, Yoong Siang" wrote: > Yes, you are right. I missed the effect of get_wol. > Is it needed in future to implement link change interrupt in phy > driver? Cause I dint see much phy driver implement link change > interrupt. If there is a board that has interrupt pin wired correctly from the PHY and the interrupt controller is safe to use (i.e. it is not a PCA953x which cannot handle interrupt storms correctly), then I think the PHY driver should use the interrupt, instead of polling. Marek