Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 16 Aug 2021 15:00:59 +0200
From:   Michal Kubecek <mkubecek@suse.cz>
To:     linux-usb@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>,
        linux-input@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: [REGRESSION][BISECTED] flood of "hid-generic ... control queue full"
 since v5.14-rc1
Message-ID: <20210816130059.3yxtdvu2r7wo4uu3@lion.mk-sys.cz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="dfcrugjtzogdosw5"
Content-Disposition: inline
Precedence: bulk


--dfcrugjtzogdosw5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hello,

starting with v5.14-rc1, my kernel log gets flooded with messages

  hid-generic 0003:051D:0002.0002: control queue full

at rate of ~33 per second. Device 051d:0002 is an APC UPS (BR-650 VA).
I bisected the issue to commit

  7652dd2c5cb7 ("USB: core: Check buffer length matches wLength for control transfers")

Reverting this commit on top of v5.14-rc6 resolves the issue. I suspect
the problem is some missing cleanup when usb_submit_urb() bails out on
the newly added check but I'm not familiar enough with the code to see
what is missing or if the problem is on USB or HID side.

Michal

--dfcrugjtzogdosw5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEWN3j3bieVmp26mKO538sG/LRdpUFAmEaYYUACgkQ538sG/LR
dpX7dwf+LxmPuDJNPaEYvkYFNTmEZFTaTJQTu2gPVihcZfOY2rwsgukq1pmpoKS3
y18U9cvJ8dWwpGLhSbgDUYcBW9sntNWFEiF1Chqp9KMlh96GecESESnNG1gFdTba
iEeatloqTTMO4BOqoQiEoipff7zM62uSlizVB2M6dY/I+BZ4FfY6+b/zYoMiWm4J
rGuxhV9JnkY72ksHj16CsIHbAMo8rJhm1nTf3UKogak/wLw/tYJYFiufO9O478pk
fx1tC0WS4rGt/2+33uW2JU6c3yuLmW/Jv/JgcKuOnrg1u0wfK1QxkiUBjuhAfxym
1ByJ1INJOKNgC4ff3+1jOstnHMMtug==
=hxJS
-----END PGP SIGNATURE-----

--dfcrugjtzogdosw5--