Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Asmaa Mnebhi <asmaa@nvidia.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        David Thompson <davthompson@nvidia.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
CC:     Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Liming Sun <limings@nvidia.com>
Subject: RE: [PATCH v1 1/6] gpio: mlxbf2: Convert to device PM ops
Thread-Topic: [PATCH v1 1/6] gpio: mlxbf2: Convert to device PM ops
Thread-Index: AQHXkpZGM/yx3akJD0WfnrDIzZ0lYat2F2+Q
Date:   Mon, 16 Aug 2021 13:04:38 +0000
Message-ID: <CH2PR12MB3895C5A27672000417F0E90CD7FD9@CH2PR12MB3895.namprd12.prod.outlook.com>
References: <20210816115953.72533-1-andriy.shevchenko@linux.intel.com>
 <20210816115953.72533-2-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20210816115953.72533-2-andriy.shevchenko@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?r4G6SwrLu23greljENKELrvnTLTu++Z9nmKhnnndqVB0bKfc8d77WN5SLulx?=
 =?us-ascii?Q?1jpUF70KEkEgwqdiWWJq0cBqpmAgrK1zmk307LOv8+5hEAwfmm3+Dm91G9h/?=
 =?us-ascii?Q?3XbTW8DLACrGar44m/r3ukKehFx/K0LMLm9X0kQCOaq8rX7H58cNSwkn5Wl6?=
 =?us-ascii?Q?wlgxvRMNurtuGrCN2bKL10SZp4LTmjpXfigzXpNC5gWBmsKK9KK9HGvqjkFd?=
 =?us-ascii?Q?eqSgvamGaC90TXEWC9vdaSrHyj1QcAASxUoLfWsuRRgel2XJMAvjX3Z3en+l?=
 =?us-ascii?Q?gBQiibS8zZUNV+rbAlBBpGib6RRebGHq8rwmTZgaXnkUKe2zLrgbG7Yxx+Zw?=
 =?us-ascii?Q?xQDJWMP2E63a2nwDJHnHe60c1unZxLcVRLEFZdtMke/cmwWiJYuj04Wf7WYn?=
 =?us-ascii?Q?aZMlICkXBr2jvUIGC/xwXvjwKg6mDamMsmFB3DvQgcZ9nOkT1MBnEXu0o5qU?=
 =?us-ascii?Q?BBGG46E/cNYYlVt3iheev9cnlRJOgXWYpLKV42fKhGxibuSn2Tj9sR5FVt69?=
 =?us-ascii?Q?Yimece3SnPbdlk8Z4u0g/aUMHT2MQUKSafBZWmca4HHOi2hU0esU2lKKcwFV?=
 =?us-ascii?Q?dFY4UEhQqfK7uPOYQr4wdD9JhgYowebPasaTT8AZRq1AcaOevrEqEChZoXJu?=
 =?us-ascii?Q?DOZS8oTBkFWLhGBtssz9HjG2IVOJ/4KmfP+QqcxRoPkbtN/IhvSLkLPXElaB?=
 =?us-ascii?Q?VbyOl/vIDiuL35KeF6JIp+OKOFvuOWVxzg1QS6vqCeHU/ep5iqjY1Omjx/TF?=
 =?us-ascii?Q?idUGcqbWdXNWcpoMBLD5ysK00qpGiIlMOI7CmjwGnHi8TJiVphUQQ5ObkfwG?=
 =?us-ascii?Q?v0F60rLW8i7cSRR4jaDlJSGc8GDHSVj/y0z4+cccziJDYiuDy4lyd9VWLEOY?=
 =?us-ascii?Q?L9NXdSakgRUOP1q7nBscIrFJi0ij8Hyq/Ukg/DAq0xIAZg0P6IF/bZeqhYYR?=
 =?us-ascii?Q?u9ZzkekotfyGx7ABbNIYTwsdZ1Gcztaa0A5Hm75nxVUlbjrCANUyiaYLjqh5?=
 =?us-ascii?Q?2rkuAQuul+cbiiyHvELp5xC52lBC1gHMXZL2nbcXrT6f+dxqxg2LrA+cAywl?=
 =?us-ascii?Q?L9pZbXcLvVLBDpLxqmzeavSCH4uWtthq4zd0FTJemvuEfqCDZkE3ZF2k57cV?=
 =?us-ascii?Q?722WWmYUM2Gl/Wk34IRpqrTk8pOX8Jic1k1BKd5ard5ioKg/9CPo4NI8BFwp?=
 =?us-ascii?Q?/QmAjFZ7B+rhlyRHfjeMyKvnJlOuC5ibDhwngpbbbeoyXh/lIgeINcbxKR0I?=
 =?us-ascii?Q?1XROBjRGOhtIJAHer8aYgPbEyckbqFvr542qQf9RL++ClqWZUxGFc9NUuQ8B?=
 =?us-ascii?Q?j70HOBXjYw59V3wMv05HtIzO?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3895.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0153c21e-cffa-4544-7860-08d960b6678e
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Aug 2021 13:04:38.6310
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zG+oSs3pjcXtYyP03iBeSGRz/LDAsHnbD520bZ+uX+GAnXsofuCVz9f5J8VWBLdNK7BrtiUz/Lmr1cDctQzPWA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4246
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Acked-by: Asmaa Mnebhi <asmaa@nvidia.com>

-----Original Message-----
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>=20
Sent: Monday, August 16, 2021 8:00 AM
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>; David Thompson <da=
vthompson@nvidia.com>; linux-kernel@vger.kernel.org; linux-gpio@vger.kernel=
.org; netdev@vger.kernel.org; linux-acpi@vger.kernel.org
Cc: Linus Walleij <linus.walleij@linaro.org>; Bartosz Golaszewski <bgolasze=
wski@baylibre.com>; David S. Miller <davem@davemloft.net>; Jakub Kicinski <=
kuba@kernel.org>; Rafael J. Wysocki <rjw@rjwysocki.net>; Asmaa Mnebhi <asma=
a@nvidia.com>; Liming Sun <limings@nvidia.com>
Subject: [PATCH v1 1/6] gpio: mlxbf2: Convert to device PM ops
Importance: High

Convert driver to use modern device PM ops interface.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpio/gpio-mlxbf2.c | 21 ++++++---------------
 1 file changed, 6 insertions(+), 15 deletions(-)

diff --git a/drivers/gpio/gpio-mlxbf2.c b/drivers/gpio/gpio-mlxbf2.c index =
befa5e109943..68c471c10fa4 100644
--- a/drivers/gpio/gpio-mlxbf2.c
+++ b/drivers/gpio/gpio-mlxbf2.c
@@ -47,12 +47,10 @@
 #define YU_GPIO_MODE0_SET		0x54
 #define YU_GPIO_MODE0_CLEAR		0x58
=20
-#ifdef CONFIG_PM
 struct mlxbf2_gpio_context_save_regs {
 	u32 gpio_mode0;
 	u32 gpio_mode1;
 };
-#endif
=20
 /* BlueField-2 gpio block context structure. */  struct mlxbf2_gpio_contex=
t { @@ -61,9 +59,7 @@ struct mlxbf2_gpio_context {
 	/* YU GPIO blocks address */
 	void __iomem *gpio_io;
=20
-#ifdef CONFIG_PM
 	struct mlxbf2_gpio_context_save_regs *csave_regs; -#endif  };
=20
 /* BlueField-2 gpio shared structure. */ @@ -284,11 +280,9 @@ mlxbf2_gpio_=
probe(struct platform_device *pdev)
 	return 0;
 }
=20
-#ifdef CONFIG_PM
-static int mlxbf2_gpio_suspend(struct platform_device *pdev,
-				pm_message_t state)
+static int __maybe_unused mlxbf2_gpio_suspend(struct device *dev)
 {
-	struct mlxbf2_gpio_context *gs =3D platform_get_drvdata(pdev);
+	struct mlxbf2_gpio_context *gs =3D dev_get_drvdata(dev);
=20
 	gs->csave_regs->gpio_mode0 =3D readl(gs->gpio_io +
 		YU_GPIO_MODE0);
@@ -298,9 +292,9 @@ static int mlxbf2_gpio_suspend(struct platform_device *=
pdev,
 	return 0;
 }
=20
-static int mlxbf2_gpio_resume(struct platform_device *pdev)
+static int __maybe_unused mlxbf2_gpio_resume(struct device *dev)
 {
-	struct mlxbf2_gpio_context *gs =3D platform_get_drvdata(pdev);
+	struct mlxbf2_gpio_context *gs =3D dev_get_drvdata(dev);
=20
 	writel(gs->csave_regs->gpio_mode0, gs->gpio_io +
 		YU_GPIO_MODE0);
@@ -309,7 +303,7 @@ static int mlxbf2_gpio_resume(struct platform_device *p=
dev)
=20
 	return 0;
 }
-#endif
+static SIMPLE_DEV_PM_OPS(mlxbf2_pm_ops, mlxbf2_gpio_suspend,=20
+mlxbf2_gpio_resume);
=20
 static const struct acpi_device_id __maybe_unused mlxbf2_gpio_acpi_match[]=
 =3D {
 	{ "MLNXBF22", 0 },
@@ -321,12 +315,9 @@ static struct platform_driver mlxbf2_gpio_driver =3D {
 	.driver =3D {
 		.name =3D "mlxbf2_gpio",
 		.acpi_match_table =3D ACPI_PTR(mlxbf2_gpio_acpi_match),
+		.pm =3D &mlxbf2_pm_ops,
 	},
 	.probe    =3D mlxbf2_gpio_probe,
-#ifdef CONFIG_PM
-	.suspend  =3D mlxbf2_gpio_suspend,
-	.resume   =3D mlxbf2_gpio_resume,
-#endif
 };
=20
 module_platform_driver(mlxbf2_gpio_driver);
--
2.30.2