Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S276477AbRKOKYB>; Thu, 15 Nov 2001 05:24:01 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S278522AbRKOKXm>; Thu, 15 Nov 2001 05:23:42 -0500
Received: from ns.virtualhost.dk ([195.184.98.160]:11524 "EHLO virtualhost.dk")
	by vger.kernel.org with ESMTP id <S276477AbRKOKX0>;
	Thu, 15 Nov 2001 05:23:26 -0500
Date: Thu, 15 Nov 2001 11:23:00 +0100
From: Jens Axboe <axboe@suse.de>
To: Jonathan Lahr <lahr@us.ibm.com>
Cc: lahr@eng2.beaverton.ibm.com, linux-kernel@vger.kernel.org,
        linux-scsi@vger.kernel.org, lse-tech@lists.sourceforge.net
Subject: Re: [Lse-tech] SCSI io_request_lock patch
Message-ID: <20011115112300.S27010@suse.de>
In-Reply-To: <20011112130902.B26302@us.ibm.com> <20011113092311.L786@suse.de> <20011113104210.L26302@us.ibm.com> <20011114091129.H17933@suse.de> <20011114105433.O26302@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20011114105433.O26302@us.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 14 2001, Jonathan Lahr wrote:
> > It's absolutely worthless. Look, it ties in with the points I made
> > below. You are exporting the merge functions for instance, and setting
> > them in the queue. This will cause scsi_merge not to use it's own
> > functions, broken.
> 
> As in the baseline, initialize_merge_fn overwrites these pointers:
>      q->back_merge_fn = scsi_back_merge_fn_;
>      q->front_merge_fn = scsi_front_merge_fn_;
>      q->merge_requests_fn = scsi_merge_requests_fn_;

I had forgotten I had #if 0 out the check for already set back_merge etc
in scsi_merge -- however that's still beside the point. _Why_ are you
exporting the ll_rw_blk functions and setting them just to have them
overridden? Makes no sense.

Don't export the merge functions ever, define your own if you really
need them. You don't, though.

As I've mentioned before, go ahead with the make_request_fn replacement.
That is indeed what it is there for.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/