Received: by 2002:a05:6a10:1d13:0:0:0:0 with SMTP id pp19csp355121pxb; Mon, 16 Aug 2021 07:01:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxW4OWUdzVbkTWEQO4ydVEDTAm+Kypp2Cg/BBbu4bAAueNKlchVhl24ONY+17Pqs44nQm/H X-Received: by 2002:a5d:83c4:: with SMTP id u4mr13106489ior.21.1629122517452; Mon, 16 Aug 2021 07:01:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1629122517; cv=none; d=google.com; s=arc-20160816; b=qZZD/MEzlfhP/VTXg7cKQ6HYYhAbNIAXfJz2O/OfYGDn0g3YvZLJXO8TkAJduYNF2m pkm7KPUvmFVUDLixOAsvUceo7Cw37L6Jly1f/37Sa1v+ATzAph3ve6MuOTXu69OYup5F 6ljtlArwi5K5XRMxcCYAum/efJZ82VcW1oLrZXMAF3z8LhlSRzcFD8jKeAWM/VXxV2wa l84zD1yg99ScxT71Ww+mY0ORIIJLMll7jbexnmgRYMH+ZGFdOSHcL7j2wkic08+iVxHJ EWaAuQuxriQNFH4GJ0e/K2RabT+YF5CnuNKoYz4CVgJjk1XnSf+vI9RAYlQMfHVZapK7 IO9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version; bh=XVC/6gEUhU4vuXQZAwgAC2E+AXjHkZw8kmCwwJT5EkY=; b=pOf1KhlzTzsgRfmZ0qC3zOdVVlTRn+dd0jXKeDMMWNFMeXU/LEEiYqi8HF8f47YiCz g1Ws5PXQOWENGbR8LBSajvg6NdK28V2LHzr41nc2CCkjmy88oCFUO795TXeisrb51gFf BI3FmNddpqy5sCyArzLvzjclgS7Pfhpw6kAXNzvR7KA42k7b+29n2EtUnM5Vr3t+RVsr cBWHD2+ghwtAnWJE+9tJaFkHaBoG5S1mU6KUKKCaS3Hag6JEsKXeVbvK1puT546LAXHu HMO5z1zLnYbc0/uZU/m7K9RB/i/eHCGs4nOKD08f4KfZPRT/pgMXiIsX36kLr044lJJE 2BNw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v38si11932276jal.58.2021.08.16.07.01.45; Mon, 16 Aug 2021 07:01:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233564AbhHPOBE (ORCPT + 99 others); Mon, 16 Aug 2021 10:01:04 -0400 Received: from mail-oi1-f172.google.com ([209.85.167.172]:44778 "EHLO mail-oi1-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231445AbhHPN7y (ORCPT ); Mon, 16 Aug 2021 09:59:54 -0400 Received: by mail-oi1-f172.google.com with SMTP id w6so26702841oiv.11; Mon, 16 Aug 2021 06:58:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XVC/6gEUhU4vuXQZAwgAC2E+AXjHkZw8kmCwwJT5EkY=; b=o/meJLg2KkDJCYyiLCtWNi/xp4tMAeJFU4ojzVzTzLvSr2yK4E7KYaUMgrm2W73CDp gFZBwwjXv3XUxkONbauz3OT8c+GtX8K32jLtaLoCrn9Bie5aczrX+jSCC3XSVcse6csb 2LPokq5h0z6vnIKCTztMFXLpW6/oBJ3DHsjkQvNmCOy89TKJYHHz+lxaYoGbvVTlehia GUIcokyRB2CbSVKtuzVKYqCHYV/5RMCvXQ6BKKo8WEoQ4iJFKFuZsFEOPiRTxo4YdFSr dZufibB96H6M97pnJRK+PYKy76SamCL9dC5F+E7xotQc0C8roS+IKr1NPWaNGaOYaKR/ TG0A== X-Gm-Message-State: AOAM532d/QDOe/ZmkWcvStc+ZokQUbmKnjp/JzdsPKR1aSCRgtgfUrHn vDtyTrADeuJPS8N9POd6uE+gQawxee2ChKx0gS8= X-Received: by 2002:a05:6808:10c1:: with SMTP id s1mr1029801ois.69.1629122300340; Mon, 16 Aug 2021 06:58:20 -0700 (PDT) MIME-Version: 1.0 References: <20210726100026.12538-1-lorenzo.pieralisi@arm.com> <20210802152359.12623-2-lorenzo.pieralisi@arm.com> <20210811145508.GA3650@lpieralisi> <20210816095854.GA2599@lpieralisi> In-Reply-To: From: "Rafael J. Wysocki" Date: Mon, 16 Aug 2021 15:57:54 +0200 Message-ID: Subject: Re: [PATCH v2 1/3] ACPI: osl: Add __force attribute in acpi_os_map_iomem() cast To: Ard Biesheuvel , Lorenzo Pieralisi Cc: Christoph Hellwig , Linux Kernel Mailing List , "Rafael J. Wysocki" , ACPI Devel Maling List , Linux ARM , Veronika kabatova , Robin Murphy , Will Deacon , Hanjun Guo , Sudeep Holla , Catalin Marinas Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 16, 2021 at 12:22 PM Ard Biesheuvel wrote: > > On Mon, 16 Aug 2021 at 11:59, Lorenzo Pieralisi > wrote: > > > > On Wed, Aug 11, 2021 at 03:55:08PM +0100, Lorenzo Pieralisi wrote: > > > On Wed, Aug 11, 2021 at 03:08:24PM +0100, Christoph Hellwig wrote: > > > > On Wed, Aug 11, 2021 at 12:40:28PM +0200, Ard Biesheuvel wrote: > > > > > The whole problem we are solving here is that ACPI, being based on > > > > > x86, conflates MMIO mappings with memory mappings, and has been using > > > > > the same underlying infrastructure for either. > > > > > > > > So let's fix that problem instead of papering over it. > > > > > > Patch (3) in this series is a fix - I would ask whether it makes > > > sense to merge patches (2-3) now and think about reworking the current > > > ACPI IO/MEM mapping API later, it can be an invasive change for a fix, > > > assuming we agree on how to rework the ACPI IO/MEM mapping API. > > > > What should we do then with this series ? > > > > It is not even clear that reworking the ACPI core is feasible to begin > with, OTOH, fixing a sparse warning is arguably not a critical bug fix > either, so I'd suggest we just drop that bit. So I'm assuming that one more iteration of this series will be posted.